Merge pull request brianc#32 from hetul/fix-closing-finished-connections

brianc · web-flow · commit e34c6021ef87 · 2019-12-18T12:38:30.000-06:00
Fix closing a finished cursor without supplying a callback
diff --git a/index.js b/index.js
@@ -175,7 +175,11 @@ Cursor.prototype.end = util.deprecate(function(cb) {
 
 Cursor.prototype.close = function(cb) {
   if (this.state === 'done') {
-    return setImmediate(cb)
+    if (cb) {
+      return setImmediate(cb)
+    } else {
+      return
+    }
   }
   this._closePortal()
   this.state = 'done'
diff --git a/test/close.js b/test/close.js
@@ -10,6 +10,16 @@ describe('close', function() {
     client.on('drain', client.end.bind(client))
   })
 
+  it('can close a finished cursor without a callback', function(done) {
+    const cursor = new Cursor(text)
+    this.client.query(cursor)
+    this.client.query('SELECT NOW()', done)
+    cursor.read(100, function(err) {
+      assert.ifError(err)
+      cursor.close()
+    })
+  })
+
   it('closes cursor early', function(done) {
     const cursor = new Cursor(text)
     this.client.query(cursor)
