From aba77b136105f0def60615bea82fce0fb297b8e6 Mon Sep 17 00:00:00 2001 From: tub5 Date: Tue, 31 Aug 2021 11:56:26 +0100 Subject: [PATCH 1/4] Update README.md Fixed versions on the README --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e6e1533a..36b9978e 100644 --- a/README.md +++ b/README.md @@ -188,9 +188,9 @@ MIT-licensed ## 📝 Important notes -### ElectronNET.API & ElectronNET.CLI Version 9.31.2 +### ElectronNET.API & ElectronNET.CLI Version 13.5.1 -Make sure you also have the new Electron.NET API & CLI 9.31.2 version. +Make sure you also have the new Electron.NET API & CLI 13.5.1 version. ``` dotnet tool update ElectronNET.CLI -g From 9892a90038e5b34fd919e9bdfebb2f6596cbaaab Mon Sep 17 00:00:00 2001 From: Cristian Giagante Date: Sun, 26 Sep 2021 19:54:25 -0300 Subject: [PATCH 2/4] Adds help regarding to modify publish parameters --- ElectronNET.CLI/Commands/BuildCommand.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ElectronNET.CLI/Commands/BuildCommand.cs b/ElectronNET.CLI/Commands/BuildCommand.cs index d9c07465..1f64df1e 100644 --- a/ElectronNET.CLI/Commands/BuildCommand.cs +++ b/ElectronNET.CLI/Commands/BuildCommand.cs @@ -23,7 +23,8 @@ public class BuildCommand : ICommand "Optional: '/install-modules' to force node module install. Implied by '/package-json'" + Environment.NewLine + "Optional: '/Version' to specify the version that should be applied to both the `dotnet publish` and `electron-builder` commands. Implied by '/Version'" + Environment.NewLine + "Optional: '/p:[property]' or '/property:[property]' to pass in dotnet publish properties. Example: '/property:Version=1.0.0' to override the FileVersion" + Environment.NewLine + - "Full example for a 32bit debug build with electron prune: build /target custom win7-x86;win32 /dotnet-configuration Debug /electron-arch ia32 /electron-params \"--prune=true \""; + "Full example for a 32bit debug build with electron prune: build /target custom win7-x86;win32 /dotnet-configuration Debug /electron-arch ia32 /electron-params \"--prune=true \"" + Environment.NewLine + + "Full example to pass publish parameters: build /PublishReadyToRun false /PublishSingleFile false /target custom win7-x86;win32 /dotnet-configuration Debug /electron-arch ia32 /electron-params \"--prune=true \""; public static IList CommandOptions { get; set; } = new List(); From 5274fec200ea37abe0b74a1cb8ddc53fc249f7aa Mon Sep 17 00:00:00 2001 From: AndreasJagiella-EH <67098649+AndreasJagiella-EH@users.noreply.github.com> Date: Mon, 4 Oct 2021 14:54:02 +0200 Subject: [PATCH 3/4] Set PublishSingleFile default back to false for NET5 compatibility --- ElectronNET.CLI/Commands/BuildCommand.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ElectronNET.CLI/Commands/BuildCommand.cs b/ElectronNET.CLI/Commands/BuildCommand.cs index d9c07465..0ca3a7b5 100644 --- a/ElectronNET.CLI/Commands/BuildCommand.cs +++ b/ElectronNET.CLI/Commands/BuildCommand.cs @@ -211,7 +211,7 @@ private Dictionary GetDotNetPublishFlags(SimpleCommandLineParser var dotNetPublishFlags = new Dictionary { {"/p:PublishReadyToRun", parser.TryGet(_paramPublishReadyToRun, out var rtr) ? rtr[0] : "true"}, - {"/p:PublishSingleFile", parser.TryGet(_paramPublishSingleFile, out var psf) ? psf[0] : "true"}, + {"/p:PublishSingleFile", parser.TryGet(_paramPublishSingleFile, out var psf) ? psf[0] : "false"}, }; if (parser.Arguments.ContainsKey(_paramVersion)) @@ -252,4 +252,4 @@ private Dictionary GetDotNetPublishFlags(SimpleCommandLineParser return dotNetPublishFlags; } } -} \ No newline at end of file +} From 5cd152c1edff44b02143115de1085ae61258dfd9 Mon Sep 17 00:00:00 2001 From: Grey Wang Date: Sat, 9 Oct 2021 20:41:12 +1300 Subject: [PATCH 4/4] Fix build command logic when target is not specified --- ElectronNET.CLI/Commands/BuildCommand.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ElectronNET.CLI/Commands/BuildCommand.cs b/ElectronNET.CLI/Commands/BuildCommand.cs index d9c07465..e3692007 100644 --- a/ElectronNET.CLI/Commands/BuildCommand.cs +++ b/ElectronNET.CLI/Commands/BuildCommand.cs @@ -61,7 +61,7 @@ public Task ExecuteAsync() if (parser.Arguments.ContainsKey(_paramVersion)) version = parser.Arguments[_paramVersion][0]; - if (!parser.Arguments.ContainsKey(_paramTarget)) + if (!parser.Arguments.ContainsKey(_paramTarget) || parser.Arguments[_paramTarget].Length == 0) { Console.WriteLine($"Error: missing '{_paramTarget}' argument."); Console.WriteLine(COMMAND_ARGUMENTS);