-
Notifications
You must be signed in to change notification settings - Fork 4
Add documentation for CommandAPI/CommandAPI#517 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b7f9683 to
085078e
Compare
…ead of PlayerArgument
willkroboth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The separate modules in reference-code look good! It looks like the only compile issues are from the test toolkit, which I will fix in #13.
- Functions page needs a rewrite - The IntegerRange/DoubleRange argument page needs a new screenshot - Apparently there might be some rendering issues with the diff on the upgrade page to 11.0.0?
Also might include a fix for the diff language not being detected correctly
willkroboth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this comment is still unresolved.
TODO: load-mock-commandapi page
Co-authored-by: willkroboth <46540330+willkroboth@users.noreply.github.com>
willkroboth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess there are still some open issues as mentioned on Discord, but those can be addressed later since they're not critical to the main documentation release.
TODO:
commandapi-paper-core,commandapi-paper-shade,commandapi-spigot-coreandcomandapi-spigot-shadeinstead ofcommandapi-bukkit-coreandcommandapi-bukkit-shadeCommandAPIPaperConfig/CommandAPISpigotConfiginstead ofCommandAPIBukkitConfigFloatRangeArgument -> DoubleRangeArgumentPlayerArgument/OfflinePlayerArgument -> PlayerProfileArgumentAsyncOfflinePlayerArgument -> AsyncPlayerProfileArgumentChatArgumentreturns aSignedMessageon PaperBlockStateArgumentnow returnsBlockStateinstead ofBlockDatasafe_suggestions.md)