Fix RGB colors in CustomArgument#CustomArgumentException#fromString #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I should have committed this to dev/dev, but I'm hoping that we can merge dev/rgb-errors to dev/dev soon enough that this will be relevant. This seems to have been a new change introduced in Spigot here: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/67a52a64854b21060cfd6eb7ca8bb7c2cdf02d1b#src/main/java/org/bukkit/craftbukkit/CraftParticle.java
I honestly DO NOT know why this fix works and why this doesn't work with the original code. I've stared at bytecode for ages and haven't cracked it. I think we'll just end up spending so much time staring at this nonsense that it's not going to be worth anyone's time, even from a Java learning perspective. My current theory is it's probably a funky bug in Java's compiler or something. Who knows.
…ementations#getExceptionFromString
Member
|
Global changelog entry? |
JorelAli
approved these changes
Nov 23, 2023
willkroboth
approved these changes
Nov 23, 2023
willkroboth
reviewed
Nov 23, 2023
...kkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/CustomArgument.java
Outdated
Show resolved
Hide resolved
Co-authored-by: willkroboth <46540330+willkroboth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #473