Skip to content

Add a MapArgument to the CommandAPI #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Mar 4, 2023
Merged

Add a MapArgument to the CommandAPI #418

merged 48 commits into from
Mar 4, 2023

Conversation

@JorelAli
Copy link
Member

@JorelAli JorelAli commented Mar 3, 2023

No description provided.

@DerEchtePilz
Initial commit of the MapArgument
fe6f87b
@DerEchtePilz
Remove continue statements
f12f055
@DerEchtePilz
Revert "Remove continue statements"
b06ed20
@DerEchtePilz
Limit the type of key values
3274f0c
@DerEchtePilz
Adds tests for float and integer keys
43c25f6
@DerEchtePilz
Fix JavaDocs of the MapArgument
eefe64b
@DerEchtePilz
Improve JavaDocs of the MapArgument
a2a7658
@DerEchtePilz
Prepare to implement suggestions
d10e29a
@DerEchtePilz
First commit of implementing suggestions (doesn't work correctly)
18adf8e
@DerEchtePilz
Fix suggestions (the suggestions, depite being correct, show up at th…
3e5023e 
…e wrong spots)
@DerEchtePilz
Finish suggestions for the MapArgument
bbe69d9
@DerEchtePilz
Remove test command from CommandAPIMain.java
674d96a
@DerEchtePilz
Fix MapArgument tests
2fbe304
@DerEchtePilz
Removes MapArgumentKeyType
d7b9bd5
@DerEchtePilz
Finally make suggestions work correctly
12c9fb0
@DerEchtePilz
Make the MapArgument return a LinkedHashMap
483690c
@DerEchtePilz
Enable commandapi-bukkit-kotlin-test again
b6dedf7
@DerEchtePilz
Fix values actually being removed from the list of suggestions if all…
8cc72e0 
…owValueDuplicates is false
@DerEchtePilz
Refactor MapArgument#parseArgument and MapArgument#getSuggestionCode
9e5869b
@DerEchtePilz
More SonarCloud stuff
574096c
@DerEchtePilz
Revert the latest refactoring commits and implement an enum to determ…
5e7fb47 
…ine what to suggest
@DerEchtePilz
Throws a CommandSyntaxException if keys or values were provided which…
25a3c73 
… are not present in the suggestion list
@DerEchtePilz
Implement tests for invalid keys and values
005b210
@DerEchtePilz
Adds tests while using withoutKeyList()/withoutValueList()
5134349
@DerEchtePilz
Create documentation page. Rename withKeyType() to withKeyMapper()
249d1ea
@DerEchtePilz
Adds documentation for the MapArgument
6a2f2dc
@DerEchtePilz
Adds a check to validate keys when building the MapArgument
5871989
@DerEchtePilz
Fix check that validates keys when building the MapArgument
0b826b7
@DerEchtePilz
Throw a CommandSyntaxException if duplicate values have been entered …
aa1afed 
…when not allowed. Fix the check that validates keys when building the MapArgument again.
@DerEchtePilz
Removes AMapArgument.java
b58341b
DerEchtePilz and others added 18 commits February 4, 2023 20:20
@DerEchtePilz
Adds MapArgument entry to arguments.md
081eb0b
@DerEchtePilz
Improve removing suggestions when duplicates are not allowed
8d8dba7
@DerEchtePilz
Removes an unused field
3611281
@DerEchtePilz
Fix documentation for the MapArgument
01279b0
@DerEchtePilz
Fix some formatting in argument_map.md
d490f2b
@DerEchtePilz
Fix MapArgument allowing incomplete maps
037a21a
@DerEchtePilz
Does this fix a 'bug' SonarCloud is complaining about?
1ca3653
@JorelAli
Use the same StringBuilder for both keyBuilder and valueBuilder
0c2205e 
If we're building a key, that means we're not building a value and vice versa. There's no need to have two builders when using one is sufficient.
@DerEchtePilz
Merge branch 'dev/dev' into dev/map-argument
1caabb6
@DerEchtePilz
Fix MapArgument#parseArgument to use the CommandArguments class
129b2bc
@DerEchtePilz
Adding some more tests
4f0dd4a
@DerEchtePilz
Implement suggestion tests for the MapArgument
91aab9f
@DerEchtePilz
Adds suggestion tests without values being removed
4f75e95
@DerEchtePilz
Catch exception that is thrown when the mapping function fails and th…
0ebb148 
…row a CommandSyntaxException with a nice message
@DerEchtePilz
Adds a missing test when parsing arguments
fb5e5b5
@JorelAli
Wrap map argument syntax in a code block
03a256f
@DerEchtePilz
Merge dev/dev into dev/map-argument
c8d67c8
@DerEchtePilz
Merge JorelAli:dev/map-argument into dev/map-argument
47d6c61
@JorelAli JorelAli merged commit dd10d09 into dev/dev Mar 4, 2023
@JorelAli JorelAli deleted the dev/map-argument branch April 7, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JorelAli @DerEchtePilz