Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@dennisseah
Copy link
Collaborator

A few things that I have missing during the review

  1. align the error i18n keys with the other commands
  2. break negative tests into different tests and call out what the test is about
  3. added missing await in test

@dennisseah dennisseah merged commit 8d8852d into master Apr 9, 2020
@dennisseah dennisseah deleted the fixGetServiceNameCmd branch April 9, 2020 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants