This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Adding spk service get-display-name command #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated bedrock.yaml `services` to contain a list of services instead of a map
indexed by path.
- Auto-migration of bedrock.yaml is hooked into `read()` function of the
`bedrockYaml.ts` file.
- `read()` is now the only function used for loading the bedrock.yaml file;
`Bedrock()` in `config.ts` is now noted as deprecated and now calls
`read()` under the hood.
- `path` property for a service now tracks the path to the service.
- Documentation references all updated.
- `spk service create <service-name>` now follows the spec
`spk service create <service-name> <service-path>`
- Documentation references all updated.
- Integration tests updated.
- Updated bedrock.yaml `services` to contain a list of services instead of a map
indexed by path.
- Auto-migration of bedrock.yaml is hooked into `read()` function of the
`bedrockYaml.ts` file.
- `read()` is now the only function used for loading the bedrock.yaml file;
`Bedrock()` in `config.ts` is now noted as deprecated and now calls
`read()` under the hood.
- `path` property for a service now tracks the path to the service.
- Documentation references all updated.
- `spk service create <service-name>` now follows the spec
`spk service create <service-name> <service-path>`
- Documentation references all updated.
- Integration tests updated.
…stCode/spk into 1117-bedrock-svc-refactor
samiyaakhtar
commented
Apr 7, 2020
mtarng
suggested changes
Apr 7, 2020
Collaborator
mtarng
left a comment
There was a problem hiding this comment.
Hm. Overall I think this logic should probably fall under spk service commands, and there should be a parameter for the service "index" or path.
Is this command designed to run in the service build pipeline, and so the design assumes you're in the service directory?
dennisseah
reviewed
Apr 7, 2020
dennisseah
reviewed
Apr 7, 2020
dennisseah
suggested changes
Apr 7, 2020
dennisseah
suggested changes
Apr 7, 2020
Collaborator
dennisseah
left a comment
There was a problem hiding this comment.
where is get-display-name.md?
please write more tests, like
- opts.path is incorrect.
- yaml file does not have the service name.
please do not stop are only these two tests
thanks
dennisseah
reviewed
Apr 7, 2020
dennisseah
reviewed
Apr 7, 2020
mtarng
reviewed
Apr 8, 2020
mtarng
reviewed
Apr 8, 2020
mtarng
approved these changes
Apr 8, 2020
yradsmikham
approved these changes
Apr 8, 2020
dennisseah
approved these changes
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of microsoft/bedrock#1173. The second part will be running this command as part of pipelines to get the right service name, but that will be merged after an spk release is available with the changes in this PR.
Related to microsoft/bedrock#1173