Fix Remove commas from numeric strings before conversion to prevent casting errors… (PowerShell#25396)

AbishekPonmudi · web-flow · commit 936096446038 · 2025-04-22T12:03:06.000+05:30
diff --git a/src/System.Management.Automation/engine/LanguagePrimitives.cs b/src/System.Management.Automation/engine/LanguagePrimitives.cs
@@ -199,8 +199,14 @@ public override bool CanConvertFrom(object sourceValue, Type destinationType)
         /// <exception cref="PSInvalidCastException">When no conversion was possible.</exception>
         public override object ConvertFrom(object sourceValue, Type destinationType, IFormatProvider formatProvider, bool ignoreCase)
         {
-            string sourceAsString = (string)LanguagePrimitives.ConvertTo(sourceValue, typeof(string), formatProvider);
-            return LanguagePrimitives.ConvertTo(sourceAsString, destinationType, formatProvider);
+           string sourceAsString = LanguagePrimitives.ConvertTo(sourceValue, typeof(string), formatProvider) as string;
+            if (sourceAsString != null){
+                string groupSeparator = formatProvider?.GetFormat(typeof(NumberFormatInfo)) is NumberFormatInfo nfi 
+                    ? nfi.NumberGroupSeparator 
+                    : CultureInfo.CurrentCulture.NumberFormat.NumberGroupSeparator;
+                sourceAsString = sourceAsString.Replace(groupSeparator, string.Empty); // Remove culture-specific group separator
+                }
+                return LanguagePrimitives.ConvertTo(sourceAsString, destinationType, formatProvider);
         }
 
         /// <summary>
