From 2aae150981b03f6a275d3d96fca946b398128275 Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:25:10 -0400 Subject: [PATCH 1/7] Hopefully Fix coverity scanning --- .github/workflows/weekly-coverity-scan.yaml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index 8659a53e7c4..349464f7ddb 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -2,13 +2,16 @@ name: Weekly Coverity Scan for Freespace Open # adapted from code by "albert-github" on the doxygen repository # many thanks for figuring this out first so it could be less painful for us! +# keep this from running on everyone's fork +# if: github.ref == 'refs/heads/master' + #This mode is for testing #on: [push, pull_request] # In production, push on a specific schedule on: schedule: - - cron: "5 0 * * 5" # Run once per a week on Friday morning (midnight UTC, 4 AM EST), to avoid Coverity's submission limits + - cron: "5 7 * * 5" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits env: QT_VERSION: 5.12.12 @@ -18,19 +21,17 @@ env: jobs: build: name: Build FSO With Coverity Wrapper - runs-on: ${{ matrix.config.os }} + runs-on: ubuntu-latest container: ghcr.io/scp-fs2open/linux_build:sha-1ff82e8 strategy: fail-fast: false - matrix: - config: - - { name: "GCC on ubuntu", os: ubuntu-latest, build_type: "Release" } + steps: - name: Checkout uses: actions/checkout@v1 with: - submodules: recursive # `true` to checkout submodules, `recursive` to recursively checkout submodules + submodules: true # `true` to checkout submodules, `recursive` to recursively checkout submodules # pipe results of wget to a log file because it's very verbose and rarely fails - name: Install Coverity @@ -46,8 +47,8 @@ jobs: - name: Configure CMake for FSO env: - CONFIGURATION: Release - compiler: gcc-9 + CONFIGURATION: FastDebug + COMPILER: gcc-9 ENABLE_QTFRED: OFF run: $GITHUB_WORKSPACE/ci/linux/configure_cmake.sh From 3d6c02ffe2ddce2fde628acf69039a71d0609998 Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:32:08 -0400 Subject: [PATCH 2/7] Temporary workflow dispatch --- .github/workflows/weekly-coverity-scan.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index 349464f7ddb..a51321ce159 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -12,7 +12,8 @@ name: Weekly Coverity Scan for Freespace Open on: schedule: - cron: "5 7 * * 5" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits - + workflow_dispatch: + env: QT_VERSION: 5.12.12 coverity_email: SirKnightlySCP@gmail.com From ce2fd88c24e5516724804d765169f3e5cc6666d4 Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:40:32 -0400 Subject: [PATCH 3/7] Try this cron expression for testing --- .github/workflows/weekly-coverity-scan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index a51321ce159..93b92916e0a 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -11,7 +11,7 @@ name: Weekly Coverity Scan for Freespace Open # In production, push on a specific schedule on: schedule: - - cron: "5 7 * * 5" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits + - cron: "0 0,42 0,18 ? * * 2024" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits workflow_dispatch: env: From 760b035a3a865ff752bd8afa10d6fa5ba5e18c69 Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:43:30 -0400 Subject: [PATCH 4/7] Try again --- .github/workflows/weekly-coverity-scan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index 93b92916e0a..61e892fd964 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -11,7 +11,7 @@ name: Weekly Coverity Scan for Freespace Open # In production, push on a specific schedule on: schedule: - - cron: "0 0,42 0,18 ? * * 2024" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits + - cron: "0 44 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits workflow_dispatch: env: From bc7654392a8042f0d46f63046493499bfe39698d Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:45:55 -0400 Subject: [PATCH 5/7] POSIX cron syntax --- .github/workflows/weekly-coverity-scan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index 61e892fd964..33c9762d9f5 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -11,7 +11,7 @@ name: Weekly Coverity Scan for Freespace Open # In production, push on a specific schedule on: schedule: - - cron: "0 44 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits + - cron: "47 18 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits workflow_dispatch: env: From 95f26ef625578db2934d0c4304eafa188edf3b07 Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:50:13 -0400 Subject: [PATCH 6/7] account for 0 index --- .github/workflows/weekly-coverity-scan.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index 33c9762d9f5..dbda3c69c5e 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -11,7 +11,7 @@ name: Weekly Coverity Scan for Freespace Open # In production, push on a specific schedule on: schedule: - - cron: "47 18 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits + - cron: "51 17 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits workflow_dispatch: env: From db5a90c955271a7d42075503fa342df1e7aba2cf Mon Sep 17 00:00:00 2001 From: JohnAFernandez Date: Mon, 27 May 2024 14:56:04 -0400 Subject: [PATCH 7/7] Ok, that wasn't it. Try reloading UTC time And getting rid of the workflow dispatch --- .github/workflows/weekly-coverity-scan.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/weekly-coverity-scan.yaml b/.github/workflows/weekly-coverity-scan.yaml index dbda3c69c5e..84977526350 100644 --- a/.github/workflows/weekly-coverity-scan.yaml +++ b/.github/workflows/weekly-coverity-scan.yaml @@ -11,8 +11,7 @@ name: Weekly Coverity Scan for Freespace Open # In production, push on a specific schedule on: schedule: - - cron: "51 17 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits - workflow_dispatch: + - cron: "57 18 * * *" # Run once per a week on Friday morning (4 AM EST), to avoid Coverity's submission limits env: QT_VERSION: 5.12.12