Simplify power of two validation (#48)

XBagon · web-flow · commit 963398a7ac04 · 2021-11-22T21:32:07.000-05:00
Simplify power of two validation

Use the std function instead of direct bit arithmetic.
diff --git a/blockalloc/src/lib.rs b/blockalloc/src/lib.rs
@@ -47,8 +47,7 @@ impl Block {
     /// Instantiate a new block of the given size. Size must be a power of two.
     // ANCHOR: BlockNew
     pub fn new(size: BlockSize) -> Result<Block, BlockError> {
-        // validate that size is a power of two
-        if !(size & (size - 1) == 0) {
+        if !size.is_power_of_two() {
             return Err(BlockError::BadRequest);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,7 @@ impl Block {`
`47`	`47`	`/// Instantiate a new block of the given size. Size must be a power of two.`
`48`	`48`	`// ANCHOR: BlockNew`
`49`	`49`	`pub fn new(size: BlockSize) -> Result<Block, BlockError> {`
`50`		`- // validate that size is a power of two`
`51`		`- if !(size & (size - 1) == 0) {`
	`50`	`+ if !size.is_power_of_two() {`
`52`	`51`	`return Err(BlockError::BadRequest);`
`53`	`52`	`}`
`54`	`53`