From 574e194bc32fb92b7146413be300742aa0787951 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Sat, 13 Nov 2021 09:18:22 +0100 Subject: [PATCH 01/35] Delay instantiation to prevent further logging attempts (#174) * Delay instantiation to prevent further logging attempts Note that this commit changes 'import()' in the sense that it no longer returns the instance. However, there's no documentation that it should. * Adjust expectation that 'import()' returns a factory instance --- lib/Workflow/Factory.pm | 9 ++++++--- t/factory.t | 6 +----- t/factory_subclass.t | 6 +----- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index 28a99f93..fcf0c26f 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -23,14 +23,17 @@ sub import { my $log = get_logger(__PACKAGE__); if ( defined $_[0] && $_[0] eq 'FACTORY' ) { shift; - my $instance = _initialize_instance($class); + my $instance; my $import_target = $package . '::FACTORY'; no strict 'refs'; unless ( defined &{$import_target} ) { - *{$import_target} = sub { return $instance }; + *{$import_target} = sub { + return $instance if $instance; + $instance = _initialize_instance($class); + return $instance; + }; } - return $instance; } $class->SUPER::import(@_); } diff --git a/t/factory.t b/t/factory.t index cd866399..7b76ba7d 100644 --- a/t/factory.t +++ b/t/factory.t @@ -3,7 +3,7 @@ use strict; use lib qw(../lib lib ../t t); use TestUtil; -use Test::More tests => 7; +use Test::More tests => 6; use Test::Exception; require_ok( 'Workflow::Factory' ); @@ -18,10 +18,6 @@ my $factory_new = eval { Workflow::Factory->new() }; is( ref( $@ ), 'Workflow::Exception', 'Call to new() throws proper exception' ); -my $i_factory = Workflow::Factory->import( 'FACTORY' ); -is( $i_factory, $factory, - 'Imported factory returns the same object' ); - lives_ok { $factory->add_config_from_file( workflow => 'workflow.xml', action => [ 'workflow_action.xml', 'workflow_action_type.xml', 'workflow_action.perl', ], validator => [ 'workflow_validator.xml', 'workflow_validator.perl' ], diff --git a/t/factory_subclass.t b/t/factory_subclass.t index df51716d..ab876632 100644 --- a/t/factory_subclass.t +++ b/t/factory_subclass.t @@ -3,7 +3,7 @@ use strict; use lib qw(../lib lib ../t t); use TestUtil; -use Test::More tests => 5; +use Test::More tests => 4; require_ok( 'FactorySubclass' ); my $factory = FactorySubclass->instance(); @@ -16,7 +16,3 @@ my $factory_new = eval { FactorySubclass->new() }; is( ref( $@ ), 'Workflow::Exception', 'Call to new() throws proper exception' ); -my $i_factory = FactorySubclass->import( 'FACTORY' ); -is( $i_factory, $factory, - 'Imported factory returns the same object' ); - From 4ab9368bae1eb50c6d516711bcf15369f609d2b4 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Thu, 27 Jan 2022 21:24:04 +0100 Subject: [PATCH 02/35] Backport 1219ff9 (require minimum Perl version v5.14) Manually backported due to merge conflicts. --- lib/Workflow.pm | 2 +- t/TestApp/CustomWorkflow.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index 676f8ef6..c83cdeb5 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -2,7 +2,7 @@ package Workflow; use warnings; use strict; -use 5.006; # warnings +use v5.14.0; # warnings use base qw( Workflow::Base ); use Log::Log4perl qw( get_logger ); use Workflow::Context; diff --git a/t/TestApp/CustomWorkflow.pm b/t/TestApp/CustomWorkflow.pm index 839211d2..424d7982 100644 --- a/t/TestApp/CustomWorkflow.pm +++ b/t/TestApp/CustomWorkflow.pm @@ -2,7 +2,7 @@ package TestApp::CustomWorkflow; use warnings; use strict; -use 5.006; +use v5.14.0; use base qw( Workflow ); $TestApp::CustomWorkflow::VERSION = '0.01'; From a39f0569565819f456eb99ea71031ea30d83d72b Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Dec 2021 20:50:52 +0100 Subject: [PATCH 03/35] Addressed Perl::Critic violation of policy Modules::RequireEndWithOne --- lib/Workflow/Factory.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index fcf0c26f..e3631fda 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -796,12 +796,12 @@ sub get_validators { return @validators; } -1; - sub _validate_action_config { return $VALIDATE_ACTION_CONFIG; } +1; + __END__ =pod From 9657f12ad4b4264c13c16a4fd8293dda0feef6f3 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Dec 2021 21:03:11 +0100 Subject: [PATCH 04/35] Addressed Perl::Critic policy violation of ValuesAndExpressions::ProhibitMixedBooleanOperators --- lib/Workflow/State.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index bd1ae1ab..bf33db5a 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -242,7 +242,7 @@ sub _assign_next_state_from_array { my @errors = (); my %new_resulting = (); foreach my $map ( @{$resulting} ) { - if ( !$map->{state} or !defined $map->{return} ) { + if ( not $map->{state} or not defined $map->{return} ) { push @errors, "Must have both 'state' ($map->{state}) and 'return' " . "($map->{return}) keys defined."; From 090affbcbc4ad59a6c6b0058d34f5e5effb1d480 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Dec 2021 23:03:45 +0100 Subject: [PATCH 05/35] Addressed several Perl::Critic violation, several disabled project scope in rc file other locally, more work to be done, but this addresses somewhat issue #43 (closes #43) --- cpanfile | 55 ++++++++++++++++++++++++++++++++++ lib/Workflow/Action/Null.pm | 2 +- lib/Workflow/Base.pm | 9 ++---- lib/Workflow/Factory.pm | 3 +- lib/Workflow/Persister/DBI.pm | 41 +++++++++++++++++-------- lib/Workflow/Persister/File.pm | 1 + t/perlcriticrc | 55 ++++++++++++++++++++++++++-------- 7 files changed, 134 insertions(+), 32 deletions(-) create mode 100644 cpanfile diff --git a/cpanfile b/cpanfile new file mode 100644 index 00000000..6a83b401 --- /dev/null +++ b/cpanfile @@ -0,0 +1,55 @@ +#!perl + +requires 'perl' => '5.014'; +requires 'parent'; +requires 'Carp'; +requires 'Class::Accessor' => '0.18'; +requires 'Class::Factory' => '1.00'; +requires 'Data::Dumper'; +requires 'Data::UUID'; +requires 'DBI'; +requires 'DateTime' => '0.15'; +requires 'DateTime::Format::Strptime' => '1.00'; +requires 'Exception::Class' => '1.10'; +requires 'File::Slurp'; +requires 'Log::Any' => '1.050'; # added structural and contextual logging +requires 'Module::Runtime'; +requires 'Safe'; +requires 'Scalar::Util'; +requires 'Syntax::Keyword::Try' => '0.25'; +requires 'XML::Simple' => '2.00'; +requires 'Readonly'; + +feature examples => + ("The example ticketing application" => + sub { + requires 'DBD::SQLite'; + requires 'DBI'; + requires 'File::Spec::Functions'; + requires 'Getopt::Long'; + + # specific for the CGI & web application: + requires 'CGI'; + requires 'CGI::Cookie'; + requires 'Cwd'; + requires 'HTTP::Daemon'; + requires 'HTTP::Request'; + requires 'HTTP::Response'; + requires 'HTTP::Status'; + requires 'Template'; + }); + + +on test => sub { + requires 'DBD::Mock' => '0.10'; + requires 'List::MoreUtils'; + requires 'Mock::MonkeyPatch'; + requires 'Test::Exception'; + requires 'Test::More' => '0.88'; + requires 'Test::Without::Module' => '0.20'; +}; + +on develop => sub { + # Note that Dist::Zilla injects its own dependencies for AUTHOR_TESTS + requires 'Test::Pod::Links' => '0.003'; +}; diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index 310aa419..4e9c4403 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -8,7 +8,7 @@ $Workflow::Action::Null::VERSION = '1.57'; sub execute { my ($self) = @_; - return undef; + return; } 1; diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index 736938ce..a451c0cf 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -45,7 +45,7 @@ sub param { if ( exists $self->{PARAMS}{$name} ) { return $self->{PARAMS}{$name}; } - return undef; + return; } return $self->{PARAMS}{$name} = $value; } @@ -53,8 +53,7 @@ sub param { sub delete_param { my ( $self, $name ) = @_; unless ( defined $name ) { - ## this is an error - perhaps an exception is too radical - return undef; + return; } # Allow multiple parameters to be deleted at once... @@ -74,9 +73,7 @@ sub delete_param { delete $self->{PARAMS}{$name}; return $value; } - - ## this is an error - perhaps an exception is too radical - return undef; + return; } sub clear_params { diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index e3631fda..548c82c8 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -386,7 +386,8 @@ sub fetch_workflow { my $wf_info = $persister->fetch_workflow($wf_id); $wf_class = $wf_config->{class} || 'Workflow' unless ($wf_class); - return undef unless ($wf_info); + return unless ($wf_info); + $wf_info->{last_update} ||= ''; $self->log->debug( "Fetched data for workflow '$wf_id' ok: ", diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 4dc20a68..2b5bec30 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -14,6 +14,11 @@ use Workflow::Persister::DBI::AutoGeneratedId; use Workflow::Persister::DBI::SequenceId; use Carp qw(croak); use English qw( -no_match_vars ); +use Syntax::Keyword::Try; +use Readonly; + +Readonly::Scalar my $TRUE => 1; +Readonly::Scalar my $FALSE => 0; $Workflow::Persister::DBI::VERSION = '1.57'; @@ -30,7 +35,7 @@ sub init { $self->date_format('%Y-%m-%d %H:%M'); # Default to autocommit on for backward compatibility. - $self->autocommit(1); + $self->autocommit($TRUE); # Load user-provided values from config. for (qw( dsn user password date_format autocommit )) { @@ -76,9 +81,9 @@ sub create_handle { if ($EVAL_ERROR) { persist_error $EVAL_ERROR; } - $dbh->{RaiseError} = 1; - $dbh->{PrintError} = 0; - $dbh->{ChopBlanks} = 1; + $dbh->{RaiseError} = $TRUE; + $dbh->{PrintError} = $FALSE; + $dbh->{ChopBlanks} = $TRUE; $dbh->{AutoCommit} = $self->autocommit(); $self->log->debug( "Connected to database '", $self->dsn, "' and ", "assigned to persister ok" ); @@ -185,7 +190,7 @@ sub create_workflow { $self->_init_fields(); my @wf_fields = @{ $self->_wf_fields }; - my @fields = @wf_fields[ 1, 2, 3 ]; + my @fields = @wf_fields[ $WORKFLOW_TYPE_FIELD_POS, $WORKFLOW_STATE_FIELD_POS, $WORKFLOW_LAST_UPDATE_FIELD_POS ]; my @values = ( $wf->type, $wf->state, @@ -196,7 +201,7 @@ sub create_workflow { my $id = $self->workflow_id_generator->pre_fetch_id($dbh); if ($id) { - push @fields, $wf_fields[0]; + push @fields, $wf_fields[$WORKFLOW_ID_FIELD_POS]; push @values, $id; $self->log->debug("Got ID from pre_fetch_id: $id"); } @@ -239,9 +244,9 @@ sub fetch_workflow { my $sql = q{SELECT %s, %s FROM %s WHERE %s = ?}; my @wf_fields = @{ $self->_wf_fields }; $sql = sprintf $sql, - $wf_fields[2], $wf_fields[3], + $wf_fields[$WORKFLOW_STATE_FIELD_POS], $wf_fields[$WORKFLOW_LAST_UPDATE_FIELD_POS], $self->handle->quote_identifier( $self->workflow_table ), - $wf_fields[0]; + $wf_fields[$WORKFLOW_ID_FIELD_POS]; if ( $self->log->is_debug ) { $self->log->debug("Will use SQL: $sql"); @@ -257,7 +262,7 @@ sub fetch_workflow { persist_error "Cannot fetch workflow: $EVAL_ERROR"; } my $row = $sth->fetchrow_arrayref; - return undef unless ($row); + return unless ($row); return { state => $row->[0], @@ -272,7 +277,7 @@ sub update_workflow { my @wf_fields = @{ $self->_wf_fields }; $sql = sprintf $sql, $self->handle->quote_identifier( $self->workflow_table ), - $wf_fields[2], $wf_fields[3], $wf_fields[0]; + $wf_fields[$WORKFLOW_STATE_FIELD_POS], $wf_fields[$WORKFLOW_LAST_UPDATE_FIELD_POS], $wf_fields[$WORKFLOW_ID_FIELD_POS]; my $update_date = DateTime->now( time_zone => $wf->time_zone() ) ->strftime( $self->date_format() ); @@ -303,7 +308,7 @@ sub create_history { next if ( $h->is_saved ); my $id = $generator->pre_fetch_id($dbh); my @hist_fields = @{ $self->_hist_fields }; - my @fields = @hist_fields[ 1 .. 6 ]; + my @fields = @hist_fields[ $WORKFLOW_ID_HIST_FIELD_POS .. $WORKFLOW_DATE_HIST_FIELD_POS ]; my @values = ( $wf->id, $h->action, $h->description, $h->state, $h->user, $h->date->strftime( $self->date_format() ), @@ -352,7 +357,7 @@ sub fetch_history { my $history_fields = join ', ', @hist_fields; $sql = sprintf $sql, $history_fields, $self->handle->quote_identifier($self->history_table), - $hist_fields[1], $hist_fields[6]; + $hist_fields[$WORKFLOW_ID_HIST_FIELD_POS], $hist_fields[$WORKFLOW_DATE_HIST_FIELD_POS]; if ( $self->log->is_debug ) { $self->log->debug("Will use SQL: $sql"); @@ -383,8 +388,20 @@ sub fetch_history { } ); $self->log->debug("Fetched history object '$row->[0]'"); +<<<<<<< HEAD $hist->set_saved(); push @history, $hist; +======= + push @history, { + id => $row->[$WORKFLOW_HIST_ID_FIELD_POS], + workflow_id => $row->[$WORKFLOW_ID_HIST_FIELD_POS], + action => $row->[$WORKFLOW_ACTION_HIST_FIELD_POS], + description => $row->[$WORKFLOW_DESC_HIST_FIELD_POS], + state => $row->[$WORKFLOW_STATE_HIST_FIELD_POS], + user => $row->[$WORKFLOW_USER_HIST_FIELD_POS], + date => $self->parser->parse_datetime( $row->[$WORKFLOW_DATE_HIST_FIELD_POS] ), + }; +>>>>>>> 03f6d57 (Addressed several Perl::Critic violation, several disabled project scope in rc file other locally, more work to be done, but this addresses somewhat issue #43 (closes #43)) } $sth->finish; return @history; diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 2161208f..4935dc43 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -45,6 +45,7 @@ sub create_workflow { $self->log->debug("Generated workflow ID '$wf_id'"); $self->_serialize_workflow($wf); my $full_history_path = $self->_get_history_path($wf); + ## no critic (ProhibitMagicNumbers) mkdir( $full_history_path, 0777 ) || persist_error "Cannot create history dir '$full_history_path': $!"; diff --git a/t/perlcriticrc b/t/perlcriticrc index d23d1d1b..838ace37 100644 --- a/t/perlcriticrc +++ b/t/perlcriticrc @@ -1,41 +1,72 @@ -# $Id$ - severity = 5 -verbose = 8 +verbose = 3 #------------------------------------------------------------------------------ +# REF: https://metacpan.org/pod/Perl::Critic::Policy::Documentation::RequirePodSections [Documentation::RequirePodSections] lib_sections = NAME|DESCRIPTION|SYNOPSIS|AUTHORS|COPYRIGHT script_sections = NAME|DESCRIPTION|SYNOPSIS|AUTHORS|COPYRIGHT +# REF: https://metacpan.org/pod/Perl::Critic::Policy::TestingAndDebugging::RequireUseWarnings [TestingAndDebugging::RequireUseWarnings] + +# REF: https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitMagicNumbers [ValuesAndExpressions::ProhibitMagicNumbers] -#Might be to late to address -[-Subroutines::ProhibitExplicitReturnUndef] +# Might be to late to address, so it is disabled at various places in the code, could perhaps be +# revisited with a major release, since it would break backwards compatibility, the recommeded +# solution is bare return +# REF: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef +[Subroutines::ProhibitExplicitReturnUndef] -#The violater of this is an overwrite for Class::Accessor +# The violater of this is an overwrite for Class::Accessor +# REF: https://metacpan.org/pod/Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames [-NamingConventions::ProhibitAmbiguousNames] -#We are using Constants +# We are using Constants +# Perhaps exchange this for Readonly? +# REF: https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitConstantPragma [-ValuesAndExpressions::ProhibitConstantPragma] -#We currently utilize a package variable deliberately, should be addressed -#again +# We currently utilize a package variable deliberately, should be addressed again +# REF: https://metacpan.org/pod/Perl::Critic::Policy::Variables::ProhibitPackageVars [-Variables::ProhibitPackageVars] -#For embedded SQL this is perfectly ok +# For embedded SQL this is perfectly ok +# REF: https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitImplicitNewlines [-ValuesAndExpressions::ProhibitImplicitNewlines] -#Exchange for Module::Load? +# Exchange for Module::Load? +# REF: https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval [-BuiltinFunctions::ProhibitStringyEval] +# We use log +# REF: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitBuiltinHomonyms +[-Subroutines::ProhibitBuiltinHomonyms] + #------------------------------------------------------------------------------ # TODO +# REF: https://metacpan.org/pod/Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict [-TestingAndDebugging::ProhibitNoStrict] -[-InputOutput::ProhibitBarewordFileHandles] \ No newline at end of file +# REF: https://metacpan.org/pod/Perl::Critic::Policy::TestingAndDebugging::ProhibitProlongedStrictureOverride +[-TestingAndDebugging::ProhibitProlongedStrictureOverride] + +# REF: https://metacpan.org/pod/Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles +[-InputOutput::ProhibitBarewordFileHandles] + +# REF: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::RequireFinalReturn +[-Subroutines::RequireFinalReturn] + +# REF: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::RequireArgUnpacking +[-Subroutines::RequireArgUnpacking] + +# REF: https://metacpan.org/pod/Perl::Critic::Policy::InputOutput::RequireBriefOpen +[-InputOutput::RequireBriefOpen] + +# REF: https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements +[-ValuesAndExpressions::ProhibitCommaSeparatedStatements] From 8f54ce19f8e28e3771511f28efef9b4b7097646a Mon Sep 17 00:00:00 2001 From: jonasbn Date: Thu, 27 Jan 2022 22:47:11 +0100 Subject: [PATCH 06/35] Manual correction to bad merge --- lib/Workflow/Persister/DBI.pm | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 2b5bec30..01743068 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -190,7 +190,7 @@ sub create_workflow { $self->_init_fields(); my @wf_fields = @{ $self->_wf_fields }; - my @fields = @wf_fields[ $WORKFLOW_TYPE_FIELD_POS, $WORKFLOW_STATE_FIELD_POS, $WORKFLOW_LAST_UPDATE_FIELD_POS ]; + my @fields = @wf_fields[ 1, 2, 3 ]; my @values = ( $wf->type, $wf->state, @@ -201,7 +201,7 @@ sub create_workflow { my $id = $self->workflow_id_generator->pre_fetch_id($dbh); if ($id) { - push @fields, $wf_fields[$WORKFLOW_ID_FIELD_POS]; + push @fields, $wf_fields[0]; push @values, $id; $self->log->debug("Got ID from pre_fetch_id: $id"); } @@ -244,9 +244,9 @@ sub fetch_workflow { my $sql = q{SELECT %s, %s FROM %s WHERE %s = ?}; my @wf_fields = @{ $self->_wf_fields }; $sql = sprintf $sql, - $wf_fields[$WORKFLOW_STATE_FIELD_POS], $wf_fields[$WORKFLOW_LAST_UPDATE_FIELD_POS], + $wf_fields[2], $wf_fields[3], $self->handle->quote_identifier( $self->workflow_table ), - $wf_fields[$WORKFLOW_ID_FIELD_POS]; + $wf_fields[0]; if ( $self->log->is_debug ) { $self->log->debug("Will use SQL: $sql"); @@ -277,7 +277,7 @@ sub update_workflow { my @wf_fields = @{ $self->_wf_fields }; $sql = sprintf $sql, $self->handle->quote_identifier( $self->workflow_table ), - $wf_fields[$WORKFLOW_STATE_FIELD_POS], $wf_fields[$WORKFLOW_LAST_UPDATE_FIELD_POS], $wf_fields[$WORKFLOW_ID_FIELD_POS]; + $wf_fields[2], $wf_fields[3], $wf_fields[0]; my $update_date = DateTime->now( time_zone => $wf->time_zone() ) ->strftime( $self->date_format() ); @@ -308,7 +308,7 @@ sub create_history { next if ( $h->is_saved ); my $id = $generator->pre_fetch_id($dbh); my @hist_fields = @{ $self->_hist_fields }; - my @fields = @hist_fields[ $WORKFLOW_ID_HIST_FIELD_POS .. $WORKFLOW_DATE_HIST_FIELD_POS ]; + my @fields = @hist_fields[ 1 .. 6 ]; my @values = ( $wf->id, $h->action, $h->description, $h->state, $h->user, $h->date->strftime( $self->date_format() ), @@ -357,7 +357,7 @@ sub fetch_history { my $history_fields = join ', ', @hist_fields; $sql = sprintf $sql, $history_fields, $self->handle->quote_identifier($self->history_table), - $hist_fields[$WORKFLOW_ID_HIST_FIELD_POS], $hist_fields[$WORKFLOW_DATE_HIST_FIELD_POS]; + $hist_fields[1], $hist_fields[6]; if ( $self->log->is_debug ) { $self->log->debug("Will use SQL: $sql"); @@ -388,20 +388,8 @@ sub fetch_history { } ); $self->log->debug("Fetched history object '$row->[0]'"); -<<<<<<< HEAD $hist->set_saved(); push @history, $hist; -======= - push @history, { - id => $row->[$WORKFLOW_HIST_ID_FIELD_POS], - workflow_id => $row->[$WORKFLOW_ID_HIST_FIELD_POS], - action => $row->[$WORKFLOW_ACTION_HIST_FIELD_POS], - description => $row->[$WORKFLOW_DESC_HIST_FIELD_POS], - state => $row->[$WORKFLOW_STATE_HIST_FIELD_POS], - user => $row->[$WORKFLOW_USER_HIST_FIELD_POS], - date => $self->parser->parse_datetime( $row->[$WORKFLOW_DATE_HIST_FIELD_POS] ), - }; ->>>>>>> 03f6d57 (Addressed several Perl::Critic violation, several disabled project scope in rc file other locally, more work to be done, but this addresses somewhat issue #43 (closes #43)) } $sth->finish; return @history; From 47f1fc5dbe36f2ae20bf6e4f6cc6b3f88b631b73 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Thu, 27 Jan 2022 23:09:03 +0100 Subject: [PATCH 07/35] Adjusted cpanfile --- cpanfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpanfile b/cpanfile index 6a83b401..f22764ca 100644 --- a/cpanfile +++ b/cpanfile @@ -12,8 +12,7 @@ requires 'DateTime' => '0.15'; requires 'DateTime::Format::Strptime' => '1.00'; requires 'Exception::Class' => '1.10'; requires 'File::Slurp'; -requires 'Log::Any' => '1.050'; # added structural and contextual logging -requires 'Module::Runtime'; +requires 'Log::Log4perl' => '0.34';requires 'Module::Runtime'; requires 'Safe'; requires 'Scalar::Util'; requires 'Syntax::Keyword::Try' => '0.25'; From 37b92f9317d2af93ee8e08160e97c94deb9b9c6d Mon Sep 17 00:00:00 2001 From: jonasbn Date: Thu, 27 Jan 2022 23:21:44 +0100 Subject: [PATCH 08/35] Followed up on the bad merge --- lib/Workflow/Persister/DBI.pm | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 01743068..418e97e8 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -377,19 +377,17 @@ sub fetch_history { my @history = (); while ( my $row = $sth->fetchrow_arrayref ) { - my $hist = Workflow::History->new( - { id => $row->[0], - workflow_id => $row->[1], - action => $row->[2], - description => $row->[3], - state => $row->[4], - user => $row->[5], - date => $self->parser->parse_datetime( $row->[6] ), - } - ); $self->log->debug("Fetched history object '$row->[0]'"); - $hist->set_saved(); - push @history, $hist; + + push @history, { + id => $row->[0], + workflow_id => $row->[1], + action => $row->[2], + description => $row->[3], + state => $row->[4], + user => $row->[5], + date => $self->parser->parse_datetime( $row->[6] ), + }; } $sth->finish; return @history; From 936ed2d3f6a9362b45d676446b58ebca4629fe24 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Thu, 27 Jan 2022 23:31:48 +0100 Subject: [PATCH 09/35] Instantiate an object as the DBI persister return value The backport was to 1.x, which has a slightly different persister protocol than 2.x: 2.x disentangled object construction from persisting which means that the 2.0 code doesn't instantiate objects but returns hashes. --- lib/Workflow/Persister/DBI.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 418e97e8..ff5e9894 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -378,8 +378,8 @@ sub fetch_history { my @history = (); while ( my $row = $sth->fetchrow_arrayref ) { $self->log->debug("Fetched history object '$row->[0]'"); - - push @history, { + + my $hist = Workflow::History->new({ id => $row->[0], workflow_id => $row->[1], action => $row->[2], @@ -387,7 +387,9 @@ sub fetch_history { state => $row->[4], user => $row->[5], date => $self->parser->parse_datetime( $row->[6] ), - }; + }); + $hist->set_saved(); + push @history, $hist; } $sth->finish; return @history; From 9507d0fe41ccd428e864ecac1dd7bf49fb6b7170 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Wed, 2 Feb 2022 18:21:11 +0100 Subject: [PATCH 10/35] Added vscode configuration to gitignore --- perl-workflow.code-workspace | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 perl-workflow.code-workspace diff --git a/perl-workflow.code-workspace b/perl-workflow.code-workspace new file mode 100644 index 00000000..876a1499 --- /dev/null +++ b/perl-workflow.code-workspace @@ -0,0 +1,8 @@ +{ + "folders": [ + { + "path": "." + } + ], + "settings": {} +} \ No newline at end of file From d1b7e1dc068c85dec2387e87977afeb8cdea8090 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Br=C3=B8ms=C3=B8?= Date: Wed, 2 Feb 2022 18:22:33 +0100 Subject: [PATCH 11/35] 1.58 candidate (#188) * Updated inline coverage report and bumped all versions * Outlined released 1.58 * Bumped copyright year accordingly --- Changes.md | 14 +++ lib/Workflow.pm | 89 ++++++++++--------- lib/Workflow/Action.pm | 6 +- lib/Workflow/Action/InputField.pm | 6 +- lib/Workflow/Action/Mailer.pm | 6 +- lib/Workflow/Action/Null.pm | 6 +- lib/Workflow/Base.pm | 6 +- lib/Workflow/Condition.pm | 6 +- lib/Workflow/Condition/CheckReturn.pm | 6 +- lib/Workflow/Condition/Evaluate.pm | 6 +- lib/Workflow/Condition/GreedyOR.pm | 6 +- lib/Workflow/Condition/HasUser.pm | 6 +- lib/Workflow/Condition/LazyAND.pm | 6 +- lib/Workflow/Condition/LazyOR.pm | 6 +- lib/Workflow/Condition/Negated.pm | 6 +- lib/Workflow/Condition/Nested.pm | 6 +- lib/Workflow/Config.pm | 6 +- lib/Workflow/Config/Perl.pm | 6 +- lib/Workflow/Config/XML.pm | 6 +- lib/Workflow/Context.pm | 6 +- lib/Workflow/Exception.pm | 6 +- lib/Workflow/Factory.pm | 6 +- lib/Workflow/History.pm | 6 +- lib/Workflow/Persister.pm | 6 +- lib/Workflow/Persister/DBI.pm | 6 +- lib/Workflow/Persister/DBI/AutoGeneratedId.pm | 6 +- lib/Workflow/Persister/DBI/ExtraData.pm | 6 +- lib/Workflow/Persister/DBI/SequenceId.pm | 6 +- lib/Workflow/Persister/File.pm | 6 +- lib/Workflow/Persister/RandomId.pm | 6 +- lib/Workflow/Persister/SPOPS.pm | 6 +- lib/Workflow/Persister/UUID.pm | 6 +- lib/Workflow/State.pm | 8 +- lib/Workflow/Validator.pm | 6 +- lib/Workflow/Validator/HasRequiredField.pm | 6 +- lib/Workflow/Validator/InEnumeratedType.pm | 6 +- lib/Workflow/Validator/MatchesDateFormat.pm | 6 +- 37 files changed, 167 insertions(+), 148 deletions(-) diff --git a/Changes.md b/Changes.md index b5432e29..55bfc939 100644 --- a/Changes.md +++ b/Changes.md @@ -6,6 +6,20 @@ SPOPS was developed by the original author of Workflow and the two have worked in parallel for a long time. The Workflow developers have come to a crossroad and focus of resources and efforts are aimed at modernizing workflow. +## 1.58 2022-02-02 Maintenance release, update not required + +- Addressed violations of [Perl::Critic](https://metacpan.org/pod/Perl::Critic) policies: + - [Subroutines::ProhibitExplicitReturnUndef](https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef) + - [ValuesAndExpressions::ProhibitMixedBooleanOperators](https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators) + + Adjustments to Perl::Critic resourcefile (`t/perlcriticrc`), this somewhat addresses issue [#43](https://github.com/jonasbn/perl-workflow/issues/43), there is more work to be done in this area, this will be adressed eventually + + By Jonas Brømsø (@jonasbn) + +- Requirement for Perl 5.14 has been made more explicit, see also PR [#185](https://github.com/jonasbn/perl-workflow/pull/185) by Erik Huelsmann (@ehuelsmann) + +- Delay of instantation, prevents additional loggings attempts, this makes logging less noisy when running tests. Via PR [#174](https://github.com/jonasbn/perl-workflow/pull/174) from Erik Huelsmann (@ehuelsmann) + ## 1.57 2021-10-17 Bug fix release, update recommended - PR [#170](https://github.com/jonasbn/perl-workflow/pull/170) addresses an issue where Workflow tries to log during the execution of `use` statements, at which time it's highly unlikely that the logger has already been initialized, resulting in warnings being printed on the console diff --git a/lib/Workflow.pm b/lib/Workflow.pm index c83cdeb5..f7d9b0ae 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -16,7 +16,7 @@ my @FIELDS = qw( id type description state last_update time_zone ); my @INTERNAL = qw( _factory _observers ); __PACKAGE__->mk_accessors( @FIELDS, @INTERNAL ); -$Workflow::VERSION = '1.57'; +$Workflow::VERSION = '1.58'; use constant NO_CHANGE_VALUE => 'NOCHANGE'; @@ -377,7 +377,7 @@ Workflow - Simple, flexible system to implement workflows =head1 VERSION -This documentation describes version 1.57 of Workflow +This documentation describes version 1.58 of Workflow =head1 SYNOPSIS @@ -1256,48 +1256,53 @@ The test suite can be run using, L % ./Build test Some of the tests are reserved for the developers and are only run of the -environment variable TEST_AUTHOR is set to true. +environment variable C is set to true. =head1 TEST COVERAGE -This is the current test coverage of Workflow version 1.32, with the TEST_AUTHOR -flag enabled. - - ---------------------------- ------ ------ ------ ------ ------ ------ ------ - File stmt bran cond sub pod time total - ---------------------------- ------ ------ ------ ------ ------ ------ ------ - blib/lib/Workflow.pm 79.8 50.0 50.0 87.5 100.0 9.9 71.6 - blib/lib/Workflow/Action.pm 90.8 66.7 n/a 88.2 100.0 4.1 89.9 - ...flow/Action/InputField.pm 97.0 92.9 87.5 100.0 100.0 5.9 95.8 - ...Workflow/Action/Mailer.pm 100.0 n/a n/a 100.0 100.0 0.1 100.0 - ...b/Workflow/Action/Null.pm 100.0 n/a n/a 100.0 100.0 0.2 100.0 - blib/lib/Workflow/Base.pm 96.6 86.4 100.0 100.0 100.0 9.6 95.0 - ...lib/Workflow/Condition.pm 100.0 n/a n/a 100.0 100.0 0.8 100.0 - ...low/Condition/Evaluate.pm 59.0 16.7 33.3 87.5 100.0 0.9 53.0 - ...flow/Condition/HasUser.pm 57.7 0.0 0.0 71.4 100.0 0.1 51.2 - blib/lib/Workflow/Config.pm 96.2 81.2 33.3 100.0 100.0 6.1 92.2 - ...b/Workflow/Config/Perl.pm 96.8 75.0 66.7 100.0 100.0 4.1 91.0 - ...ib/Workflow/Config/XML.pm 92.3 50.0 60.0 100.0 100.0 4.9 81.4 - blib/lib/Workflow/Context.pm 100.0 n/a n/a 100.0 100.0 0.4 100.0 - ...lib/Workflow/Exception.pm 89.2 50.0 n/a 91.7 100.0 3.1 89.5 - blib/lib/Workflow/Factory.pm 86.3 61.2 37.5 92.3 100.0 19.6 75.4 - blib/lib/Workflow/History.pm 100.0 87.5 n/a 100.0 100.0 1.8 98.1 - ...lib/Workflow/Persister.pm 90.5 75.0 57.1 88.9 100.0 1.9 87.5 - ...Workflow/Persister/DBI.pm 75.3 51.2 25.0 83.3 100.0 7.4 67.5 - ...er/DBI/AutoGeneratedId.pm 77.8 40.0 n/a 100.0 100.0 0.4 70.1 - ...ersister/DBI/ExtraData.pm 25.9 0.0 0.0 71.4 100.0 0.1 22.9 - ...rsister/DBI/SequenceId.pm 56.2 0.0 0.0 75.0 100.0 0.3 53.1 - ...orkflow/Persister/File.pm 94.4 48.0 33.3 100.0 100.0 2.1 83.1 - ...low/Persister/RandomId.pm 100.0 n/a 100.0 100.0 100.0 1.8 100.0 - ...rkflow/Persister/SPOPS.pm 89.6 50.0 n/a 100.0 100.0 0.3 85.0 - ...orkflow/Persister/UUID.pm 100.0 n/a n/a 100.0 100.0 0.2 100.0 - blib/lib/Workflow/State.pm 74.4 44.2 25.0 91.7 100.0 11.0 64.3 - ...lib/Workflow/Validator.pm 100.0 100.0 n/a 100.0 100.0 1.1 100.0 - ...dator/HasRequiredField.pm 90.0 50.0 n/a 100.0 100.0 0.6 86.7 - ...dator/InEnumeratedType.pm 100.0 100.0 n/a 100.0 100.0 0.4 100.0 - ...ator/MatchesDateFormat.pm 93.3 70.0 66.7 100.0 100.0 0.8 88.2 - Total 83.9 54.7 39.7 93.0 100.0 100.0 76.8 - ---------------------------- ------ ------ ------ ------ ------ ------ ------ +This is the current test coverage of Workflow version 1.58, with the C +flag enabled + + TEST_AUTHOR=1 dzil cover + + ---------------------------- ------ ------ ------ ------ ------ ------ ------ + File stmt bran cond sub pod time total + ---------------------------- ------ ------ ------ ------ ------ ------ ------ + blib/lib/Workflow.pm 91.6 68.7 60.0 93.3 100.0 1.2 86.7 + blib/lib/Workflow/Action.pm 93.5 60.0 n/a 94.1 100.0 4.4 91.4 + ...b/Workflow/Action/Null.pm 100.0 n/a n/a 100.0 100.0 2.3 100.0 + blib/lib/Workflow/Base.pm 96.7 86.3 83.3 100.0 100.0 3.0 94.5 + ...lib/Workflow/Condition.pm 100.0 100.0 100.0 100.0 100.0 4.4 100.0 + .../Condition/CheckReturn.pm 71.7 35.7 n/a 100.0 100.0 0.0 67.6 + ...low/Condition/Evaluate.pm 96.7 75.0 n/a 100.0 100.0 3.4 95.4 + ...low/Condition/GreedyOR.pm 100.0 100.0 n/a 100.0 100.0 0.0 100.0 + ...flow/Condition/HasUser.pm 70.0 n/a 33.3 83.3 100.0 0.0 70.0 + ...flow/Condition/LazyAND.pm 100.0 100.0 n/a 100.0 100.0 0.0 100.0 + ...kflow/Condition/LazyOR.pm 100.0 100.0 n/a 100.0 100.0 0.0 100.0 + ...flow/Condition/Negated.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 + blib/lib/Workflow/Config.pm 96.2 81.2 33.3 100.0 100.0 3.1 92.2 + ...b/Workflow/Config/Perl.pm 96.1 83.3 66.6 92.8 100.0 0.1 92.9 + ...ib/Workflow/Config/XML.pm 94.1 62.5 50.0 100.0 100.0 4.6 90.2 + blib/lib/Workflow/Context.pm 100.0 n/a n/a 100.0 100.0 2.3 100.0 + ...lib/Workflow/Exception.pm 100.0 100.0 n/a 100.0 100.0 0.9 100.0 + blib/lib/Workflow/Factory.pm 87.4 79.3 61.5 84.6 100.0 30.9 84.3 + blib/lib/Workflow/History.pm 100.0 87.5 n/a 100.0 100.0 4.3 98.2 + ...ib/Workflow/InputField.pm 98.6 96.1 87.5 100.0 100.0 2.5 97.6 + ...lib/Workflow/Persister.pm 98.4 100.0 71.4 94.7 100.0 2.4 96.4 + ...Workflow/Persister/DBI.pm 86.7 72.0 35.2 90.6 100.0 7.7 83.0 + ...er/DBI/AutoGeneratedId.pm 91.8 75.0 83.3 100.0 100.0 0.0 88.7 + ...ersister/DBI/ExtraData.pm 29.8 0.0 0.0 60.0 100.0 0.6 29.7 + ...rsister/DBI/SequenceId.pm 100.0 n/a 50.0 100.0 100.0 0.0 98.0 + ...orkflow/Persister/File.pm 94.4 50.0 33.3 100.0 100.0 0.2 88.5 + ...low/Persister/RandomId.pm 100.0 n/a 100.0 100.0 100.0 2.3 100.0 + ...orkflow/Persister/UUID.pm 100.0 n/a n/a 100.0 100.0 2.2 100.0 + blib/lib/Workflow/State.pm 88.1 62.5 16.6 96.3 100.0 4.9 81.7 + ...lib/Workflow/Validator.pm 100.0 83.3 n/a 100.0 100.0 2.4 97.5 + ...dator/HasRequiredField.pm 90.9 50.0 n/a 100.0 100.0 2.3 87.8 + ...dator/InEnumeratedType.pm 100.0 100.0 n/a 100.0 100.0 2.3 100.0 + ...ator/MatchesDateFormat.pm 100.0 100.0 100.0 100.0 100.0 4.0 100.0 + Total 90.7 73.6 57.6 94.9 100.0 100.0 87.8 + ---------------------------- ------ ------ ------ ------ ------ ------ ------ Activities to get improved coverage are ongoing. @@ -1400,7 +1405,7 @@ L =head1 COPYRIGHT Copyright (c) 2003 Chris Winters and Arvato Direct; -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index cd9993bc..aec97c47 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -12,7 +12,7 @@ use Workflow::Validator::HasRequiredField; use Workflow::Factory qw( FACTORY ); use Carp qw(croak); -$Workflow::Action::VERSION = '1.57'; +$Workflow::Action::VERSION = '1.58'; my @PROPS = qw( name class description group ); my @INTERNAL = qw( _factory ); @@ -167,7 +167,7 @@ Workflow::Action - Base class for Workflow actions =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -486,7 +486,7 @@ fields. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index 276daf57..d9211f90 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); use English qw( -no_match_vars ); -$Workflow::Action::InputField::VERSION = '1.57'; +$Workflow::Action::InputField::VERSION = '1.58'; my @PROPS = qw( name label description type requirement source_class source_list class ); @@ -121,7 +121,7 @@ Workflow::Action::InputField - Metadata about information required by an Action =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -311,7 +311,7 @@ example. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action/Mailer.pm b/lib/Workflow/Action/Mailer.pm index 1f79c335..5a0be616 100644 --- a/lib/Workflow/Action/Mailer.pm +++ b/lib/Workflow/Action/Mailer.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Mailer::VERSION = '1.57'; +$Workflow::Action::Mailer::VERSION = '1.58'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Mailer - a stub for a SMTP capable action =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -49,7 +49,7 @@ I =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index 4e9c4403..c2517eb8 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Null::VERSION = '1.57'; +$Workflow::Action::Null::VERSION = '1.58'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Null - Workflow action for the terminally lazy =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -60,7 +60,7 @@ it by returning C. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index a451c0cf..74d5afa5 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Class::Accessor ); use Log::Log4perl; -$Workflow::Base::VERSION = '1.57'; +$Workflow::Base::VERSION = '1.58'; sub new { my ( $class, @params ) = @_; @@ -99,7 +99,7 @@ Workflow::Base - Base class with constructor =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -199,7 +199,7 @@ it in a list. If given neither return an empty list. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index 1eb53a20..9b46e750 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -9,7 +9,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( workflow_error condition_error ); $Workflow::Condition::CACHE_RESULTS = 1; -$Workflow::Condition::VERSION = '1.57'; +$Workflow::Condition::VERSION = '1.58'; my $log; my @FIELDS = qw( name class ); @@ -118,7 +118,7 @@ Workflow::Condition - Evaluate a condition depending on the workflow state and e =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -319,7 +319,7 @@ consider it to be the value returned. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index bfda5ce3..cb9caa0f 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -3,7 +3,7 @@ package Workflow::Condition::CheckReturn; use strict; use warnings; -our $VERSION = '1.57'; +our $VERSION = '1.58'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -90,7 +90,7 @@ Workflow::Condition::CheckReturn =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 DESCRIPTION @@ -164,7 +164,7 @@ above strings map to the following numeric operators internally: =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 200d9904..7ba8573d 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -8,7 +8,7 @@ use Safe; use Workflow::Exception qw( condition_error configuration_error ); use English qw( -no_match_vars ); -$Workflow::Condition::Evaluate::VERSION = '1.57'; +$Workflow::Condition::Evaluate::VERSION = '1.58'; my @FIELDS = qw( test ); __PACKAGE__->mk_accessors(@FIELDS); @@ -68,7 +68,7 @@ Workflow::Condition::Evaluate - Inline condition that evaluates perl code for tr =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -137,7 +137,7 @@ A hashref of all the parameters in the L object =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/GreedyOR.pm b/lib/Workflow/Condition/GreedyOR.pm index eb135ebf..3a6f3ec4 100644 --- a/lib/Workflow/Condition/GreedyOR.pm +++ b/lib/Workflow/Condition/GreedyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::GreedyOR; use strict; use warnings; -our $VERSION = '1.57'; +our $VERSION = '1.58'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::GreedyOR =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 DESCRIPTION @@ -119,7 +119,7 @@ B =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/HasUser.pm b/lib/Workflow/Condition/HasUser.pm index 5e9a264c..e806790c 100644 --- a/lib/Workflow/Condition/HasUser.pm +++ b/lib/Workflow/Condition/HasUser.pm @@ -6,7 +6,7 @@ use base qw( Workflow::Condition ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( condition_error ); -$Workflow::Condition::HasUser::VERSION = '1.57'; +$Workflow::Condition::HasUser::VERSION = '1.58'; my $DEFAULT_USER_KEY = 'current_user'; @@ -41,7 +41,7 @@ Workflow::Condition::HasUser - Condition to determine if a user is available =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -108,7 +108,7 @@ Throws L if evaluation fails =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/LazyAND.pm b/lib/Workflow/Condition/LazyAND.pm index 9ee86541..487eedd9 100644 --- a/lib/Workflow/Condition/LazyAND.pm +++ b/lib/Workflow/Condition/LazyAND.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyAND; use strict; use warnings; -our $VERSION = '1.57'; +our $VERSION = '1.58'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::LazyAND =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 DESCRIPTION @@ -113,7 +113,7 @@ B =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/LazyOR.pm b/lib/Workflow/Condition/LazyOR.pm index 59fd265a..c23ea58b 100644 --- a/lib/Workflow/Condition/LazyOR.pm +++ b/lib/Workflow/Condition/LazyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyOR; use strict; use warnings; -our $VERSION = '1.57'; +our $VERSION = '1.58'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -55,7 +55,7 @@ Workflow::Condition::LazyOR =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 DESCRIPTION @@ -111,7 +111,7 @@ B =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/Negated.pm b/lib/Workflow/Condition/Negated.pm index 615f1b13..aeda7067 100644 --- a/lib/Workflow/Condition/Negated.pm +++ b/lib/Workflow/Condition/Negated.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Negated; use strict; use warnings; -our $VERSION = '1.57'; +our $VERSION = '1.58'; use base qw( Workflow::Condition ); @@ -36,7 +36,7 @@ Workflow::Condition::Negated - Negate workflow condition result =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 DESCRIPTION @@ -73,7 +73,7 @@ See L =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/Nested.pm b/lib/Workflow/Condition/Nested.pm index 63ebdda5..bf31553f 100644 --- a/lib/Workflow/Condition/Nested.pm +++ b/lib/Workflow/Condition/Nested.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Nested; use strict; use warnings; -our $VERSION = '1.57'; +our $VERSION = '1.58'; use base qw( Workflow::Condition ); @@ -19,7 +19,7 @@ Workflow::Condition::Nested - Evaluate nested workflow conditions =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 DESCRIPTION @@ -86,7 +86,7 @@ See L =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index edadee0a..b893cb68 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -7,7 +7,7 @@ use Data::Dumper qw( Dumper ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Config::VERSION = '1.57'; +$Workflow::Config::VERSION = '1.58'; # Map the valid type to the top-level XML tag or data # structure to look for. @@ -114,7 +114,7 @@ Workflow::Config - Parse configuration files for the workflow components =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -493,7 +493,7 @@ For documentation of the other keys, please refer to the respective classes. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index d4e3757b..bbe74ca6 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Data::Dumper qw( Dumper ); use English qw( -no_match_vars ); -$Workflow::Config::Perl::VERSION = '1.57'; +$Workflow::Config::Perl::VERSION = '1.58'; sub parse { my ( $self, $type, @items ) = @_; @@ -104,7 +104,7 @@ Workflow::Config::Perl - Parse workflow configurations as Perl data structures =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -150,7 +150,7 @@ The method returns a list of configuration parameters. =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index abba883d..fc3c3029 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Config::XML::VERSION = '1.57'; +$Workflow::Config::XML::VERSION = '1.58'; my ($log); @@ -107,7 +107,7 @@ Workflow::Config::XML - Parse workflow configurations from XML content =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -143,7 +143,7 @@ Returns a list of config parameters as a array upon success. =head1 COPYRIGHT -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Context.pm b/lib/Workflow/Context.pm index 02559a0c..a4409547 100644 --- a/lib/Workflow/Context.pm +++ b/lib/Workflow/Context.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Base ); -$Workflow::Context::VERSION = '1.57'; +$Workflow::Context::VERSION = '1.58'; sub init { @@ -35,7 +35,7 @@ Workflow::Context - Data blackboard for Workflows, Actions, Conditions and Valid =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -95,7 +95,7 @@ C<$other_context> wins. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Exception.pm b/lib/Workflow/Exception.pm index 83906f23..ca253a6a 100644 --- a/lib/Workflow/Exception.pm +++ b/lib/Workflow/Exception.pm @@ -44,7 +44,7 @@ my %TYPE_LOGGING = ( ); -$Workflow::Exception::VERSION = '1.57'; +$Workflow::Exception::VERSION = '1.58'; @Workflow::Exception::ISA = qw( Exporter Exception::Class::Base ); @Workflow::Exception::EXPORT_OK = keys %TYPE_CLASSES; @@ -129,7 +129,7 @@ Workflow::Exception - Base class for workflow exceptions =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -246,7 +246,7 @@ This exception is thrown via when input data or similar of a workflow =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index 548c82c8..aea0472f 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error workflow_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Factory::VERSION = '1.57'; +$Workflow::Factory::VERSION = '1.58'; # Extra action attribute validation is off by default for compatibility. our $VALIDATE_ACTION_CONFIG = 0; @@ -813,7 +813,7 @@ Workflow::Factory - Generates new workflow and supporting objects =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -1220,7 +1220,7 @@ of L configs. See L for details. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/History.pm b/lib/Workflow/History.pm index 045515e9..df043119 100644 --- a/lib/Workflow/History.pm +++ b/lib/Workflow/History.pm @@ -5,7 +5,7 @@ use strict; use base qw( Class::Accessor ); use DateTime; -$Workflow::History::VERSION = '1.57'; +$Workflow::History::VERSION = '1.58'; my @FIELDS = qw( id workflow_id action description date user state time_zone ); @@ -66,7 +66,7 @@ Workflow::History - Recorded work on a workflow action or workflow itself =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -185,7 +185,7 @@ Sets saved state to true and returns 1 =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index 40031b7f..832df602 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -9,7 +9,7 @@ use Workflow::Exception qw( persist_error ); use constant DEFAULT_ID_LENGTH => 8; -$Workflow::Persister::VERSION = '1.57'; +$Workflow::Persister::VERSION = '1.58'; my @FIELDS = qw( name class use_random use_uuid @@ -160,7 +160,7 @@ Workflow::Persister - Base class for workflow persistence =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -333,7 +333,7 @@ we shift parameters in? =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index ff5e9894..9d6eb5f5 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -20,7 +20,7 @@ use Readonly; Readonly::Scalar my $TRUE => 1; Readonly::Scalar my $FALSE => 0; -$Workflow::Persister::DBI::VERSION = '1.57'; +$Workflow::Persister::DBI::VERSION = '1.58'; my @FIELDS = qw( _wf_fields _hist_fields handle dsn user password driver workflow_table history_table date_format parser autocommit); @@ -464,7 +464,7 @@ Workflow::Persister::DBI - Persist workflow and history to DBI database =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -804,7 +804,7 @@ Returns nothing =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm index a79bf3db..83102a82 100644 --- a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm +++ b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm @@ -6,7 +6,7 @@ use base qw( Class::Accessor ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.57'; +$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.58'; my @FIELDS = qw( log from_handle handle_property func_property ); __PACKAGE__->mk_accessors(@FIELDS); @@ -65,7 +65,7 @@ Workflow::Persister::DBI::AutoGeneratedId - Pull IDs from databases that autogen =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -130,7 +130,7 @@ database handle, based on the statement handle. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index 2e2cd86a..51377673 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::ExtraData::VERSION = '1.57'; +$Workflow::Persister::DBI::ExtraData::VERSION = '1.58'; my @FIELDS = qw( table data_field context_key ); __PACKAGE__->mk_accessors(@FIELDS); @@ -106,7 +106,7 @@ Workflow::Persister::DBI::ExtraData - Fetch extra data with each workflow and pu =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -220,7 +220,7 @@ Throws L if retrieval is not successful. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index fdd2f074..33921350 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::SequenceId::VERSION = '1.57'; +$Workflow::Persister::DBI::SequenceId::VERSION = '1.58'; my @FIELDS = qw( log sequence_name sequence_select ); __PACKAGE__->mk_accessors(@FIELDS); @@ -53,7 +53,7 @@ Workflow::Persister::DBI::SequenceId - Persister to fetch ID from a sequence =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -112,7 +112,7 @@ This is a I method, use L =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 4935dc43..ef06fd2d 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -11,7 +11,7 @@ use Workflow::Persister::RandomId; use File::Slurp qw(slurp); use English qw( -no_match_vars ); -$Workflow::Persister::File::VERSION = '1.57'; +$Workflow::Persister::File::VERSION = '1.58'; my @FIELDS = qw( path ); __PACKAGE__->mk_accessors(@FIELDS); @@ -179,7 +179,7 @@ Workflow::Persister::File - Persist workflow and history to the filesystem =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -291,7 +291,7 @@ to deserialization attempt. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/RandomId.pm b/lib/Workflow/Persister/RandomId.pm index dc58e4ce..ba44615b 100644 --- a/lib/Workflow/Persister/RandomId.pm +++ b/lib/Workflow/Persister/RandomId.pm @@ -8,7 +8,7 @@ use constant DEFAULT_ID_LENGTH => 8; use constant RANDOM_SEED => 26; use constant CONSTANT_INCREMENT => 65; -$Workflow::Persister::RandomId::VERSION = '1.57'; +$Workflow::Persister::RandomId::VERSION = '1.58'; my @FIELDS = qw( id_length ); __PACKAGE__->mk_accessors(@FIELDS); @@ -42,7 +42,7 @@ Workflow::Persister::RandomId - Persister to generate random ID =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -84,7 +84,7 @@ This method is unimplemented at this time, please see the TODO. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/SPOPS.pm b/lib/Workflow/Persister/SPOPS.pm index 4ca86e40..cd81e132 100644 --- a/lib/Workflow/Persister/SPOPS.pm +++ b/lib/Workflow/Persister/SPOPS.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::SPOPS::VERSION = '1.57'; +$Workflow::Persister::SPOPS::VERSION = '1.58'; my @FIELDS = qw( workflow_class history_class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -143,7 +143,7 @@ Workflow::Persister::SPOPS - Persist workflows using SPOPS =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -249,7 +249,7 @@ Returns an array of workflow history objects upon success =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/UUID.pm b/lib/Workflow/Persister/UUID.pm index 08c45ba5..7f181ab7 100644 --- a/lib/Workflow/Persister/UUID.pm +++ b/lib/Workflow/Persister/UUID.pm @@ -4,7 +4,7 @@ use warnings; use strict; use Data::UUID; -$Workflow::Persister::UUID::VERSION = '1.57'; +$Workflow::Persister::UUID::VERSION = '1.58'; sub new { my ( $class, $params ) = @_; @@ -31,7 +31,7 @@ Workflow::Persister::UUID - Persister to generate Universally Unique Identifiers =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -84,7 +84,7 @@ This method is unimplemented at this time, please see the TODO. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index bf33db5a..85cac9c7 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -11,7 +11,7 @@ use Exception::Class; use Workflow::Factory qw( FACTORY ); use English qw( -no_match_vars ); -$Workflow::State::VERSION = '1.57'; +$Workflow::State::VERSION = '1.58'; my @FIELDS = qw( state description type ); my @INTERNAL = qw( _test_condition_count _factory _actions _conditions @@ -353,7 +353,7 @@ Workflow::State - Information about an individual state in a workflow =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -503,7 +503,7 @@ Returns name of action to be used for autorunning the state. =head3 clear_condition_cache ( ) -Deprecated, kept for 1.57 compatibility. +Deprecated, kept for 1.58 compatibility. Used to empties the condition result cache for a given state. @@ -555,7 +555,7 @@ performing some sanity checks like ensuring every action has a =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator.pm b/lib/Workflow/Validator.pm index 1abcf131..6dffafa8 100644 --- a/lib/Workflow/Validator.pm +++ b/lib/Workflow/Validator.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Base ); use Carp qw(croak); -$Workflow::Validator::VERSION = '1.57'; +$Workflow::Validator::VERSION = '1.58'; my @FIELDS = qw( name class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -43,7 +43,7 @@ Workflow::Validator - Ensure data are valid =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -147,7 +147,7 @@ get the application context information from the C<$workflow> object. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator/HasRequiredField.pm b/lib/Workflow/Validator/HasRequiredField.pm index c8d14443..ce2d660c 100644 --- a/lib/Workflow/Validator/HasRequiredField.pm +++ b/lib/Workflow/Validator/HasRequiredField.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( validation_error ); -$Workflow::Validator::HasRequiredField::VERSION = '1.57'; +$Workflow::Validator::HasRequiredField::VERSION = '1.58'; sub validate { my ( $self, $wf, @required_fields ) = @_; @@ -34,7 +34,7 @@ Workflow::Validator::HasRequiredField - Validator to ensure certain data are in =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -103,7 +103,7 @@ L's are thrown in case of missing fields. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator/InEnumeratedType.pm b/lib/Workflow/Validator/InEnumeratedType.pm index 97512005..c62e7341 100644 --- a/lib/Workflow/Validator/InEnumeratedType.pm +++ b/lib/Workflow/Validator/InEnumeratedType.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( configuration_error validation_error ); -$Workflow::Validator::InEnumeratedType::VERSION = '1.57'; +$Workflow::Validator::InEnumeratedType::VERSION = '1.58'; sub _init { my ( $self, $params ) = @_; @@ -59,7 +59,7 @@ Workflow::Validator::InEnumeratedType - Ensure a value is one of a declared set =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -215,7 +215,7 @@ part of the set. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index c85432d1..d1c78ca8 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error validation_error ); use English qw( -no_match_vars ); use Carp qw(carp); -$Workflow::Validator::MatchesDateFormat::VERSION = '1.57'; +$Workflow::Validator::MatchesDateFormat::VERSION = '1.58'; __PACKAGE__->mk_accessors('formatter'); @@ -64,7 +64,7 @@ Workflow::Validator::MatchesDateFormat - Ensure a stringified date matches a giv =head1 VERSION -This documentation describes version 1.57 of this package +This documentation describes version 1.58 of this package =head1 SYNOPSIS @@ -140,7 +140,7 @@ parameter, which should adhere to a predefined date format. =head1 COPYRIGHT -Copyright (c) 2003-2021 Chris Winters. All rights reserved. +Copyright (c) 2003-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. From 9f5bb164876703b6f10eb6e9e96e15d3cb25fb64 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Wed, 2 Feb 2022 21:37:08 +0100 Subject: [PATCH 12/35] [1.x] Fix dependency declarations * Add Readonly dependency * Remove unused Syntax::Keyword::Try module accidentally backported * Remove cpanfile dependency declaration unused by Dist::Zilla in 1.x --- cpanfile | 54 ----------------------------------- dist.ini | 1 + lib/Workflow/Persister/DBI.pm | 1 - 3 files changed, 1 insertion(+), 55 deletions(-) delete mode 100644 cpanfile diff --git a/cpanfile b/cpanfile deleted file mode 100644 index f22764ca..00000000 --- a/cpanfile +++ /dev/null @@ -1,54 +0,0 @@ -#!perl - -requires 'perl' => '5.014'; -requires 'parent'; -requires 'Carp'; -requires 'Class::Accessor' => '0.18'; -requires 'Class::Factory' => '1.00'; -requires 'Data::Dumper'; -requires 'Data::UUID'; -requires 'DBI'; -requires 'DateTime' => '0.15'; -requires 'DateTime::Format::Strptime' => '1.00'; -requires 'Exception::Class' => '1.10'; -requires 'File::Slurp'; -requires 'Log::Log4perl' => '0.34';requires 'Module::Runtime'; -requires 'Safe'; -requires 'Scalar::Util'; -requires 'Syntax::Keyword::Try' => '0.25'; -requires 'XML::Simple' => '2.00'; -requires 'Readonly'; - -feature examples => - ("The example ticketing application" => - sub { - requires 'DBD::SQLite'; - requires 'DBI'; - requires 'File::Spec::Functions'; - requires 'Getopt::Long'; - - # specific for the CGI & web application: - requires 'CGI'; - requires 'CGI::Cookie'; - requires 'Cwd'; - requires 'HTTP::Daemon'; - requires 'HTTP::Request'; - requires 'HTTP::Response'; - requires 'HTTP::Status'; - requires 'Template'; - }); - - -on test => sub { - requires 'DBD::Mock' => '0.10'; - requires 'List::MoreUtils'; - requires 'Mock::MonkeyPatch'; - requires 'Test::Exception'; - requires 'Test::More' => '0.88'; - requires 'Test::Without::Module' => '0.20'; -}; - -on develop => sub { - # Note that Dist::Zilla injects its own dependencies for AUTHOR_TESTS - requires 'Test::Pod::Links' => '0.003'; -}; diff --git a/dist.ini b/dist.ini index 73f3a8bf..d1712800 100644 --- a/dist.ini +++ b/dist.ini @@ -81,6 +81,7 @@ Data::Dumper = 0 Carp = 0 File::Slurp = 0 Data::UUID = 0 +Readonly = 0 ; REF: Dist::Zilla https://metacpan.org/pod/Dist::Zilla [Prereqs / Recommends] diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 9d6eb5f5..1e55f899 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -14,7 +14,6 @@ use Workflow::Persister::DBI::AutoGeneratedId; use Workflow::Persister::DBI::SequenceId; use Carp qw(croak); use English qw( -no_match_vars ); -use Syntax::Keyword::Try; use Readonly; Readonly::Scalar my $TRUE => 1; From c9afcd7d16426314a9f11bc159ad0357abfcc2e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Br=C3=B8ms=C3=B8?= Date: Thu, 3 Feb 2022 07:45:55 +0100 Subject: [PATCH 13/35] Preparing release 1.59 (#191) * Preparing release 1.59 * Corrected spelling error found in review --- Changes.md | 6 ++ README.md | 87 ++++++++++--------- lib/Workflow.pm | 6 +- lib/Workflow/Action.pm | 4 +- lib/Workflow/Action/InputField.pm | 4 +- lib/Workflow/Action/Mailer.pm | 4 +- lib/Workflow/Action/Null.pm | 4 +- lib/Workflow/Base.pm | 4 +- lib/Workflow/Condition.pm | 4 +- lib/Workflow/Condition/CheckReturn.pm | 4 +- lib/Workflow/Condition/Evaluate.pm | 4 +- lib/Workflow/Condition/GreedyOR.pm | 4 +- lib/Workflow/Condition/HasUser.pm | 4 +- lib/Workflow/Condition/LazyAND.pm | 4 +- lib/Workflow/Condition/LazyOR.pm | 4 +- lib/Workflow/Condition/Negated.pm | 4 +- lib/Workflow/Condition/Nested.pm | 4 +- lib/Workflow/Config.pm | 4 +- lib/Workflow/Config/Perl.pm | 4 +- lib/Workflow/Config/XML.pm | 4 +- lib/Workflow/Context.pm | 4 +- lib/Workflow/Exception.pm | 4 +- lib/Workflow/Factory.pm | 4 +- lib/Workflow/History.pm | 4 +- lib/Workflow/Persister.pm | 4 +- lib/Workflow/Persister/DBI.pm | 4 +- lib/Workflow/Persister/DBI/AutoGeneratedId.pm | 4 +- lib/Workflow/Persister/DBI/ExtraData.pm | 4 +- lib/Workflow/Persister/DBI/SequenceId.pm | 4 +- lib/Workflow/Persister/File.pm | 4 +- lib/Workflow/Persister/RandomId.pm | 4 +- lib/Workflow/Persister/SPOPS.pm | 4 +- lib/Workflow/Persister/UUID.pm | 4 +- lib/Workflow/State.pm | 6 +- lib/Workflow/Validator.pm | 4 +- lib/Workflow/Validator/HasRequiredField.pm | 4 +- lib/Workflow/Validator/InEnumeratedType.pm | 4 +- lib/Workflow/Validator/MatchesDateFormat.pm | 4 +- 38 files changed, 126 insertions(+), 115 deletions(-) diff --git a/Changes.md b/Changes.md index 55bfc939..06b30385 100644 --- a/Changes.md +++ b/Changes.md @@ -6,6 +6,12 @@ SPOPS was developed by the original author of Workflow and the two have worked in parallel for a long time. The Workflow developers have come to a crossroad and focus of resources and efforts are aimed at modernizing workflow. +## 1.59 2022-02-02 bug fix release, update required + +- Unfortunately we discovered a minor mishap, where a dependency was referenced without being properly declared as a dependency, which could result in inability for the distribution to work in a clean environment. This has now been addressed via PR [#190](https://github.com/jonasbn/perl-workflow/pull/190) + +We are sorry about any inconvenience this might have caused + ## 1.58 2022-02-02 Maintenance release, update not required - Addressed violations of [Perl::Critic](https://metacpan.org/pod/Perl::Critic) policies: diff --git a/README.md b/README.md index 08761f03..aed6358d 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ Workflow - Simple, flexible system to implement workflows # VERSION -This documentation describes version 1.57 of Workflow +This documentation describes version 1.59 of Workflow # SYNOPSIS @@ -769,48 +769,53 @@ The test suite can be run using, [Module::Build](https://metacpan.org/pod/Module % ./Build test Some of the tests are reserved for the developers and are only run of the -environment variable TEST\_AUTHOR is set to true. +environment variable `TEST_AUTHOR` is set to true. # TEST COVERAGE -This is the current test coverage of Workflow version 1.32, with the TEST\_AUTHOR -flag enabled. - - ---------------------------- ------ ------ ------ ------ ------ ------ ------ - File stmt bran cond sub pod time total - ---------------------------- ------ ------ ------ ------ ------ ------ ------ - blib/lib/Workflow.pm 79.8 50.0 50.0 87.5 100.0 9.9 71.6 - blib/lib/Workflow/Action.pm 90.8 66.7 n/a 88.2 100.0 4.1 89.9 - ...flow/Action/InputField.pm 97.0 92.9 87.5 100.0 100.0 5.9 95.8 - ...Workflow/Action/Mailer.pm 100.0 n/a n/a 100.0 100.0 0.1 100.0 - ...b/Workflow/Action/Null.pm 100.0 n/a n/a 100.0 100.0 0.2 100.0 - blib/lib/Workflow/Base.pm 96.6 86.4 100.0 100.0 100.0 9.6 95.0 - ...lib/Workflow/Condition.pm 100.0 n/a n/a 100.0 100.0 0.8 100.0 - ...low/Condition/Evaluate.pm 59.0 16.7 33.3 87.5 100.0 0.9 53.0 - ...flow/Condition/HasUser.pm 57.7 0.0 0.0 71.4 100.0 0.1 51.2 - blib/lib/Workflow/Config.pm 96.2 81.2 33.3 100.0 100.0 6.1 92.2 - ...b/Workflow/Config/Perl.pm 96.8 75.0 66.7 100.0 100.0 4.1 91.0 - ...ib/Workflow/Config/XML.pm 92.3 50.0 60.0 100.0 100.0 4.9 81.4 - blib/lib/Workflow/Context.pm 100.0 n/a n/a 100.0 100.0 0.4 100.0 - ...lib/Workflow/Exception.pm 89.2 50.0 n/a 91.7 100.0 3.1 89.5 - blib/lib/Workflow/Factory.pm 86.3 61.2 37.5 92.3 100.0 19.6 75.4 - blib/lib/Workflow/History.pm 100.0 87.5 n/a 100.0 100.0 1.8 98.1 - ...lib/Workflow/Persister.pm 90.5 75.0 57.1 88.9 100.0 1.9 87.5 - ...Workflow/Persister/DBI.pm 75.3 51.2 25.0 83.3 100.0 7.4 67.5 - ...er/DBI/AutoGeneratedId.pm 77.8 40.0 n/a 100.0 100.0 0.4 70.1 - ...ersister/DBI/ExtraData.pm 25.9 0.0 0.0 71.4 100.0 0.1 22.9 - ...rsister/DBI/SequenceId.pm 56.2 0.0 0.0 75.0 100.0 0.3 53.1 - ...orkflow/Persister/File.pm 94.4 48.0 33.3 100.0 100.0 2.1 83.1 - ...low/Persister/RandomId.pm 100.0 n/a 100.0 100.0 100.0 1.8 100.0 - ...rkflow/Persister/SPOPS.pm 89.6 50.0 n/a 100.0 100.0 0.3 85.0 - ...orkflow/Persister/UUID.pm 100.0 n/a n/a 100.0 100.0 0.2 100.0 - blib/lib/Workflow/State.pm 74.4 44.2 25.0 91.7 100.0 11.0 64.3 - ...lib/Workflow/Validator.pm 100.0 100.0 n/a 100.0 100.0 1.1 100.0 - ...dator/HasRequiredField.pm 90.0 50.0 n/a 100.0 100.0 0.6 86.7 - ...dator/InEnumeratedType.pm 100.0 100.0 n/a 100.0 100.0 0.4 100.0 - ...ator/MatchesDateFormat.pm 93.3 70.0 66.7 100.0 100.0 0.8 88.2 - Total 83.9 54.7 39.7 93.0 100.0 100.0 76.8 - ---------------------------- ------ ------ ------ ------ ------ ------ ------ +This is the current test coverage of Workflow version 1.58, with the `TEST_AUTHOR` +flag enabled + + TEST_AUTHOR=1 dzil cover + + ---------------------------- ------ ------ ------ ------ ------ ------ ------ + File stmt bran cond sub pod time total + ---------------------------- ------ ------ ------ ------ ------ ------ ------ + blib/lib/Workflow.pm 91.6 68.7 60.0 93.3 100.0 1.2 86.7 + blib/lib/Workflow/Action.pm 93.5 60.0 n/a 94.1 100.0 4.4 91.4 + ...b/Workflow/Action/Null.pm 100.0 n/a n/a 100.0 100.0 2.3 100.0 + blib/lib/Workflow/Base.pm 96.7 86.3 83.3 100.0 100.0 3.0 94.5 + ...lib/Workflow/Condition.pm 100.0 100.0 100.0 100.0 100.0 4.4 100.0 + .../Condition/CheckReturn.pm 71.7 35.7 n/a 100.0 100.0 0.0 67.6 + ...low/Condition/Evaluate.pm 96.7 75.0 n/a 100.0 100.0 3.4 95.4 + ...low/Condition/GreedyOR.pm 100.0 100.0 n/a 100.0 100.0 0.0 100.0 + ...flow/Condition/HasUser.pm 70.0 n/a 33.3 83.3 100.0 0.0 70.0 + ...flow/Condition/LazyAND.pm 100.0 100.0 n/a 100.0 100.0 0.0 100.0 + ...kflow/Condition/LazyOR.pm 100.0 100.0 n/a 100.0 100.0 0.0 100.0 + ...flow/Condition/Negated.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 + blib/lib/Workflow/Config.pm 96.2 81.2 33.3 100.0 100.0 3.1 92.2 + ...b/Workflow/Config/Perl.pm 96.1 83.3 66.6 92.8 100.0 0.1 92.9 + ...ib/Workflow/Config/XML.pm 94.1 62.5 50.0 100.0 100.0 4.6 90.2 + blib/lib/Workflow/Context.pm 100.0 n/a n/a 100.0 100.0 2.3 100.0 + ...lib/Workflow/Exception.pm 100.0 100.0 n/a 100.0 100.0 0.9 100.0 + blib/lib/Workflow/Factory.pm 87.4 79.3 61.5 84.6 100.0 30.9 84.3 + blib/lib/Workflow/History.pm 100.0 87.5 n/a 100.0 100.0 4.3 98.2 + ...ib/Workflow/InputField.pm 98.6 96.1 87.5 100.0 100.0 2.5 97.6 + ...lib/Workflow/Persister.pm 98.4 100.0 71.4 94.7 100.0 2.4 96.4 + ...Workflow/Persister/DBI.pm 86.7 72.0 35.2 90.6 100.0 7.7 83.0 + ...er/DBI/AutoGeneratedId.pm 91.8 75.0 83.3 100.0 100.0 0.0 88.7 + ...ersister/DBI/ExtraData.pm 29.8 0.0 0.0 60.0 100.0 0.6 29.7 + ...rsister/DBI/SequenceId.pm 100.0 n/a 50.0 100.0 100.0 0.0 98.0 + ...orkflow/Persister/File.pm 94.4 50.0 33.3 100.0 100.0 0.2 88.5 + ...low/Persister/RandomId.pm 100.0 n/a 100.0 100.0 100.0 2.3 100.0 + ...orkflow/Persister/UUID.pm 100.0 n/a n/a 100.0 100.0 2.2 100.0 + blib/lib/Workflow/State.pm 88.1 62.5 16.6 96.3 100.0 4.9 81.7 + ...lib/Workflow/Validator.pm 100.0 83.3 n/a 100.0 100.0 2.4 97.5 + ...dator/HasRequiredField.pm 90.9 50.0 n/a 100.0 100.0 2.3 87.8 + ...dator/InEnumeratedType.pm 100.0 100.0 n/a 100.0 100.0 2.3 100.0 + ...ator/MatchesDateFormat.pm 100.0 100.0 100.0 100.0 100.0 4.0 100.0 + Total 90.7 73.6 57.6 94.9 100.0 100.0 87.8 + ---------------------------- ------ ------ ------ ------ ------ ------ ------ Activities to get improved coverage are ongoing. @@ -889,7 +894,7 @@ The code is kept under revision control using Git: # COPYRIGHT Copyright (c) 2003 Chris Winters and Arvato Direct; -Copyright (c) 2004-2021 Chris Winters. All rights reserved. +Copyright (c) 2004-2022 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow.pm b/lib/Workflow.pm index f7d9b0ae..795439df 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -16,7 +16,7 @@ my @FIELDS = qw( id type description state last_update time_zone ); my @INTERNAL = qw( _factory _observers ); __PACKAGE__->mk_accessors( @FIELDS, @INTERNAL ); -$Workflow::VERSION = '1.58'; +$Workflow::VERSION = '1.59'; use constant NO_CHANGE_VALUE => 'NOCHANGE'; @@ -377,7 +377,7 @@ Workflow - Simple, flexible system to implement workflows =head1 VERSION -This documentation describes version 1.58 of Workflow +This documentation describes version 1.59 of Workflow =head1 SYNOPSIS @@ -1263,7 +1263,7 @@ environment variable C is set to true. This is the current test coverage of Workflow version 1.58, with the C flag enabled - TEST_AUTHOR=1 dzil cover + TEST_AUTHOR=1 dzil cover ---------------------------- ------ ------ ------ ------ ------ ------ ------ File stmt bran cond sub pod time total diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index aec97c47..bfbdfdf9 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -12,7 +12,7 @@ use Workflow::Validator::HasRequiredField; use Workflow::Factory qw( FACTORY ); use Carp qw(croak); -$Workflow::Action::VERSION = '1.58'; +$Workflow::Action::VERSION = '1.59'; my @PROPS = qw( name class description group ); my @INTERNAL = qw( _factory ); @@ -167,7 +167,7 @@ Workflow::Action - Base class for Workflow actions =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index d9211f90..b141bb2d 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); use English qw( -no_match_vars ); -$Workflow::Action::InputField::VERSION = '1.58'; +$Workflow::Action::InputField::VERSION = '1.59'; my @PROPS = qw( name label description type requirement source_class source_list class ); @@ -121,7 +121,7 @@ Workflow::Action::InputField - Metadata about information required by an Action =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Mailer.pm b/lib/Workflow/Action/Mailer.pm index 5a0be616..1e31bc2f 100644 --- a/lib/Workflow/Action/Mailer.pm +++ b/lib/Workflow/Action/Mailer.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Mailer::VERSION = '1.58'; +$Workflow::Action::Mailer::VERSION = '1.59'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Mailer - a stub for a SMTP capable action =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index c2517eb8..e186b213 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Null::VERSION = '1.58'; +$Workflow::Action::Null::VERSION = '1.59'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Null - Workflow action for the terminally lazy =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index 74d5afa5..fc178570 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Class::Accessor ); use Log::Log4perl; -$Workflow::Base::VERSION = '1.58'; +$Workflow::Base::VERSION = '1.59'; sub new { my ( $class, @params ) = @_; @@ -99,7 +99,7 @@ Workflow::Base - Base class with constructor =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index 9b46e750..fea73682 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -9,7 +9,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( workflow_error condition_error ); $Workflow::Condition::CACHE_RESULTS = 1; -$Workflow::Condition::VERSION = '1.58'; +$Workflow::Condition::VERSION = '1.59'; my $log; my @FIELDS = qw( name class ); @@ -118,7 +118,7 @@ Workflow::Condition - Evaluate a condition depending on the workflow state and e =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index cb9caa0f..9e1d2ec2 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -3,7 +3,7 @@ package Workflow::Condition::CheckReturn; use strict; use warnings; -our $VERSION = '1.58'; +our $VERSION = '1.59'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -90,7 +90,7 @@ Workflow::Condition::CheckReturn =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 7ba8573d..52a25966 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -8,7 +8,7 @@ use Safe; use Workflow::Exception qw( condition_error configuration_error ); use English qw( -no_match_vars ); -$Workflow::Condition::Evaluate::VERSION = '1.58'; +$Workflow::Condition::Evaluate::VERSION = '1.59'; my @FIELDS = qw( test ); __PACKAGE__->mk_accessors(@FIELDS); @@ -68,7 +68,7 @@ Workflow::Condition::Evaluate - Inline condition that evaluates perl code for tr =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/GreedyOR.pm b/lib/Workflow/Condition/GreedyOR.pm index 3a6f3ec4..fe51ea88 100644 --- a/lib/Workflow/Condition/GreedyOR.pm +++ b/lib/Workflow/Condition/GreedyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::GreedyOR; use strict; use warnings; -our $VERSION = '1.58'; +our $VERSION = '1.59'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::GreedyOR =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/HasUser.pm b/lib/Workflow/Condition/HasUser.pm index e806790c..82dac430 100644 --- a/lib/Workflow/Condition/HasUser.pm +++ b/lib/Workflow/Condition/HasUser.pm @@ -6,7 +6,7 @@ use base qw( Workflow::Condition ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( condition_error ); -$Workflow::Condition::HasUser::VERSION = '1.58'; +$Workflow::Condition::HasUser::VERSION = '1.59'; my $DEFAULT_USER_KEY = 'current_user'; @@ -41,7 +41,7 @@ Workflow::Condition::HasUser - Condition to determine if a user is available =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/LazyAND.pm b/lib/Workflow/Condition/LazyAND.pm index 487eedd9..57eefdd1 100644 --- a/lib/Workflow/Condition/LazyAND.pm +++ b/lib/Workflow/Condition/LazyAND.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyAND; use strict; use warnings; -our $VERSION = '1.58'; +our $VERSION = '1.59'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::LazyAND =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/LazyOR.pm b/lib/Workflow/Condition/LazyOR.pm index c23ea58b..b350d0f2 100644 --- a/lib/Workflow/Condition/LazyOR.pm +++ b/lib/Workflow/Condition/LazyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyOR; use strict; use warnings; -our $VERSION = '1.58'; +our $VERSION = '1.59'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -55,7 +55,7 @@ Workflow::Condition::LazyOR =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Negated.pm b/lib/Workflow/Condition/Negated.pm index aeda7067..ba79dfde 100644 --- a/lib/Workflow/Condition/Negated.pm +++ b/lib/Workflow/Condition/Negated.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Negated; use strict; use warnings; -our $VERSION = '1.58'; +our $VERSION = '1.59'; use base qw( Workflow::Condition ); @@ -36,7 +36,7 @@ Workflow::Condition::Negated - Negate workflow condition result =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Nested.pm b/lib/Workflow/Condition/Nested.pm index bf31553f..4722ccab 100644 --- a/lib/Workflow/Condition/Nested.pm +++ b/lib/Workflow/Condition/Nested.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Nested; use strict; use warnings; -our $VERSION = '1.58'; +our $VERSION = '1.59'; use base qw( Workflow::Condition ); @@ -19,7 +19,7 @@ Workflow::Condition::Nested - Evaluate nested workflow conditions =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index b893cb68..ccf23c46 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -7,7 +7,7 @@ use Data::Dumper qw( Dumper ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Config::VERSION = '1.58'; +$Workflow::Config::VERSION = '1.59'; # Map the valid type to the top-level XML tag or data # structure to look for. @@ -114,7 +114,7 @@ Workflow::Config - Parse configuration files for the workflow components =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index bbe74ca6..4fe5e1d7 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Data::Dumper qw( Dumper ); use English qw( -no_match_vars ); -$Workflow::Config::Perl::VERSION = '1.58'; +$Workflow::Config::Perl::VERSION = '1.59'; sub parse { my ( $self, $type, @items ) = @_; @@ -104,7 +104,7 @@ Workflow::Config::Perl - Parse workflow configurations as Perl data structures =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index fc3c3029..99bf0733 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Config::XML::VERSION = '1.58'; +$Workflow::Config::XML::VERSION = '1.59'; my ($log); @@ -107,7 +107,7 @@ Workflow::Config::XML - Parse workflow configurations from XML content =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Context.pm b/lib/Workflow/Context.pm index a4409547..74568ee4 100644 --- a/lib/Workflow/Context.pm +++ b/lib/Workflow/Context.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Base ); -$Workflow::Context::VERSION = '1.58'; +$Workflow::Context::VERSION = '1.59'; sub init { @@ -35,7 +35,7 @@ Workflow::Context - Data blackboard for Workflows, Actions, Conditions and Valid =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Exception.pm b/lib/Workflow/Exception.pm index ca253a6a..44e93cd7 100644 --- a/lib/Workflow/Exception.pm +++ b/lib/Workflow/Exception.pm @@ -44,7 +44,7 @@ my %TYPE_LOGGING = ( ); -$Workflow::Exception::VERSION = '1.58'; +$Workflow::Exception::VERSION = '1.59'; @Workflow::Exception::ISA = qw( Exporter Exception::Class::Base ); @Workflow::Exception::EXPORT_OK = keys %TYPE_CLASSES; @@ -129,7 +129,7 @@ Workflow::Exception - Base class for workflow exceptions =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index aea0472f..7ed0ca26 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error workflow_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Factory::VERSION = '1.58'; +$Workflow::Factory::VERSION = '1.59'; # Extra action attribute validation is off by default for compatibility. our $VALIDATE_ACTION_CONFIG = 0; @@ -813,7 +813,7 @@ Workflow::Factory - Generates new workflow and supporting objects =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/History.pm b/lib/Workflow/History.pm index df043119..9a7278c0 100644 --- a/lib/Workflow/History.pm +++ b/lib/Workflow/History.pm @@ -5,7 +5,7 @@ use strict; use base qw( Class::Accessor ); use DateTime; -$Workflow::History::VERSION = '1.58'; +$Workflow::History::VERSION = '1.59'; my @FIELDS = qw( id workflow_id action description date user state time_zone ); @@ -66,7 +66,7 @@ Workflow::History - Recorded work on a workflow action or workflow itself =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index 832df602..dd0625c0 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -9,7 +9,7 @@ use Workflow::Exception qw( persist_error ); use constant DEFAULT_ID_LENGTH => 8; -$Workflow::Persister::VERSION = '1.58'; +$Workflow::Persister::VERSION = '1.59'; my @FIELDS = qw( name class use_random use_uuid @@ -160,7 +160,7 @@ Workflow::Persister - Base class for workflow persistence =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 1e55f899..b36c8a6c 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -19,7 +19,7 @@ use Readonly; Readonly::Scalar my $TRUE => 1; Readonly::Scalar my $FALSE => 0; -$Workflow::Persister::DBI::VERSION = '1.58'; +$Workflow::Persister::DBI::VERSION = '1.59'; my @FIELDS = qw( _wf_fields _hist_fields handle dsn user password driver workflow_table history_table date_format parser autocommit); @@ -463,7 +463,7 @@ Workflow::Persister::DBI - Persist workflow and history to DBI database =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm index 83102a82..6b53857b 100644 --- a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm +++ b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm @@ -6,7 +6,7 @@ use base qw( Class::Accessor ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.58'; +$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.59'; my @FIELDS = qw( log from_handle handle_property func_property ); __PACKAGE__->mk_accessors(@FIELDS); @@ -65,7 +65,7 @@ Workflow::Persister::DBI::AutoGeneratedId - Pull IDs from databases that autogen =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index 51377673..ca668fa9 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::ExtraData::VERSION = '1.58'; +$Workflow::Persister::DBI::ExtraData::VERSION = '1.59'; my @FIELDS = qw( table data_field context_key ); __PACKAGE__->mk_accessors(@FIELDS); @@ -106,7 +106,7 @@ Workflow::Persister::DBI::ExtraData - Fetch extra data with each workflow and pu =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index 33921350..c0b9a3e5 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::SequenceId::VERSION = '1.58'; +$Workflow::Persister::DBI::SequenceId::VERSION = '1.59'; my @FIELDS = qw( log sequence_name sequence_select ); __PACKAGE__->mk_accessors(@FIELDS); @@ -53,7 +53,7 @@ Workflow::Persister::DBI::SequenceId - Persister to fetch ID from a sequence =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index ef06fd2d..9c6c9db1 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -11,7 +11,7 @@ use Workflow::Persister::RandomId; use File::Slurp qw(slurp); use English qw( -no_match_vars ); -$Workflow::Persister::File::VERSION = '1.58'; +$Workflow::Persister::File::VERSION = '1.59'; my @FIELDS = qw( path ); __PACKAGE__->mk_accessors(@FIELDS); @@ -179,7 +179,7 @@ Workflow::Persister::File - Persist workflow and history to the filesystem =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/RandomId.pm b/lib/Workflow/Persister/RandomId.pm index ba44615b..c5e855d6 100644 --- a/lib/Workflow/Persister/RandomId.pm +++ b/lib/Workflow/Persister/RandomId.pm @@ -8,7 +8,7 @@ use constant DEFAULT_ID_LENGTH => 8; use constant RANDOM_SEED => 26; use constant CONSTANT_INCREMENT => 65; -$Workflow::Persister::RandomId::VERSION = '1.58'; +$Workflow::Persister::RandomId::VERSION = '1.59'; my @FIELDS = qw( id_length ); __PACKAGE__->mk_accessors(@FIELDS); @@ -42,7 +42,7 @@ Workflow::Persister::RandomId - Persister to generate random ID =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/SPOPS.pm b/lib/Workflow/Persister/SPOPS.pm index cd81e132..85c1c23d 100644 --- a/lib/Workflow/Persister/SPOPS.pm +++ b/lib/Workflow/Persister/SPOPS.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::SPOPS::VERSION = '1.58'; +$Workflow::Persister::SPOPS::VERSION = '1.59'; my @FIELDS = qw( workflow_class history_class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -143,7 +143,7 @@ Workflow::Persister::SPOPS - Persist workflows using SPOPS =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/UUID.pm b/lib/Workflow/Persister/UUID.pm index 7f181ab7..aa5fe297 100644 --- a/lib/Workflow/Persister/UUID.pm +++ b/lib/Workflow/Persister/UUID.pm @@ -4,7 +4,7 @@ use warnings; use strict; use Data::UUID; -$Workflow::Persister::UUID::VERSION = '1.58'; +$Workflow::Persister::UUID::VERSION = '1.59'; sub new { my ( $class, $params ) = @_; @@ -31,7 +31,7 @@ Workflow::Persister::UUID - Persister to generate Universally Unique Identifiers =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index 85cac9c7..6866220f 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -11,7 +11,7 @@ use Exception::Class; use Workflow::Factory qw( FACTORY ); use English qw( -no_match_vars ); -$Workflow::State::VERSION = '1.58'; +$Workflow::State::VERSION = '1.59'; my @FIELDS = qw( state description type ); my @INTERNAL = qw( _test_condition_count _factory _actions _conditions @@ -353,7 +353,7 @@ Workflow::State - Information about an individual state in a workflow =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS @@ -503,7 +503,7 @@ Returns name of action to be used for autorunning the state. =head3 clear_condition_cache ( ) -Deprecated, kept for 1.58 compatibility. +Deprecated, kept for 1.59 compatibility. Used to empties the condition result cache for a given state. diff --git a/lib/Workflow/Validator.pm b/lib/Workflow/Validator.pm index 6dffafa8..4ea71223 100644 --- a/lib/Workflow/Validator.pm +++ b/lib/Workflow/Validator.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Base ); use Carp qw(croak); -$Workflow::Validator::VERSION = '1.58'; +$Workflow::Validator::VERSION = '1.59'; my @FIELDS = qw( name class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -43,7 +43,7 @@ Workflow::Validator - Ensure data are valid =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/HasRequiredField.pm b/lib/Workflow/Validator/HasRequiredField.pm index ce2d660c..c1d3e8cc 100644 --- a/lib/Workflow/Validator/HasRequiredField.pm +++ b/lib/Workflow/Validator/HasRequiredField.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( validation_error ); -$Workflow::Validator::HasRequiredField::VERSION = '1.58'; +$Workflow::Validator::HasRequiredField::VERSION = '1.59'; sub validate { my ( $self, $wf, @required_fields ) = @_; @@ -34,7 +34,7 @@ Workflow::Validator::HasRequiredField - Validator to ensure certain data are in =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/InEnumeratedType.pm b/lib/Workflow/Validator/InEnumeratedType.pm index c62e7341..e23a8ec4 100644 --- a/lib/Workflow/Validator/InEnumeratedType.pm +++ b/lib/Workflow/Validator/InEnumeratedType.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( configuration_error validation_error ); -$Workflow::Validator::InEnumeratedType::VERSION = '1.58'; +$Workflow::Validator::InEnumeratedType::VERSION = '1.59'; sub _init { my ( $self, $params ) = @_; @@ -59,7 +59,7 @@ Workflow::Validator::InEnumeratedType - Ensure a value is one of a declared set =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index d1c78ca8..987f9fe3 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error validation_error ); use English qw( -no_match_vars ); use Carp qw(carp); -$Workflow::Validator::MatchesDateFormat::VERSION = '1.58'; +$Workflow::Validator::MatchesDateFormat::VERSION = '1.59'; __PACKAGE__->mk_accessors('formatter'); @@ -64,7 +64,7 @@ Workflow::Validator::MatchesDateFormat - Ensure a stringified date matches a giv =head1 VERSION -This documentation describes version 1.58 of this package +This documentation describes version 1.59 of this package =head1 SYNOPSIS From 8616fb31804f56c5a4f50d0d5b8a63c4a1583f25 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Mon, 28 Feb 2022 22:10:56 +0100 Subject: [PATCH 14/35] Always return a value from Workflow::Base->param() (#195) In 1.58 and 1.59, Workflow was changed to return an empty list instead of `undef` when the param entry does not exist. This, however, causes two regressions in LedgerSMB where `param` is called in list context, but expected to return `undef` (as it used to before 1.58). --- lib/Workflow/Base.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index fc178570..14c211eb 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -42,10 +42,7 @@ sub param { } unless ( defined $value ) { - if ( exists $self->{PARAMS}{$name} ) { - return $self->{PARAMS}{$name}; - } - return; + return $self->{PARAMS}{$name}; } return $self->{PARAMS}{$name} = $value; } From 0fa8cdab848d3efd841f315809eafc01ccd97b51 Mon Sep 17 00:00:00 2001 From: Oliver Welter Date: Wed, 2 Mar 2022 08:35:32 +0100 Subject: [PATCH 15/35] Enforce call to context->param as scalar This is a follow up to the problem fixed by #195. When a parameter given in the argument list of a validator does not exist this is evaluated as list context and the empty list does not change the runtime_args with the consequence that the position of the arguments changes in the list, breaking the functionality of the validator. --- lib/Workflow/Action.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index bfbdfdf9..fa2e5619 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -80,7 +80,7 @@ sub validate { my @runtime_args = ($wf); foreach my $arg ( @{$args} ) { if ( $arg =~ /^\$(.*)$/ ) { - push @runtime_args, $context->param($1); + push @runtime_args, scalar $context->param($1); } else { push @runtime_args, $arg; } From 6e90bc99fc145f8c48e2f02d90f1c860c7763308 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Wed, 2 Mar 2022 19:21:06 +0100 Subject: [PATCH 16/35] Bumped version number --- lib/Workflow.pm | 4 ++-- lib/Workflow/Action.pm | 4 ++-- lib/Workflow/Action/InputField.pm | 4 ++-- lib/Workflow/Action/Mailer.pm | 4 ++-- lib/Workflow/Action/Null.pm | 4 ++-- lib/Workflow/Base.pm | 4 ++-- lib/Workflow/Condition.pm | 4 ++-- lib/Workflow/Condition/CheckReturn.pm | 4 ++-- lib/Workflow/Condition/Evaluate.pm | 4 ++-- lib/Workflow/Condition/GreedyOR.pm | 4 ++-- lib/Workflow/Condition/HasUser.pm | 4 ++-- lib/Workflow/Condition/LazyAND.pm | 4 ++-- lib/Workflow/Condition/LazyOR.pm | 4 ++-- lib/Workflow/Condition/Negated.pm | 4 ++-- lib/Workflow/Condition/Nested.pm | 4 ++-- lib/Workflow/Config.pm | 4 ++-- lib/Workflow/Config/Perl.pm | 4 ++-- lib/Workflow/Config/XML.pm | 4 ++-- lib/Workflow/Context.pm | 4 ++-- lib/Workflow/Exception.pm | 4 ++-- lib/Workflow/Factory.pm | 4 ++-- lib/Workflow/History.pm | 4 ++-- lib/Workflow/Persister.pm | 4 ++-- lib/Workflow/Persister/DBI.pm | 4 ++-- lib/Workflow/Persister/DBI/AutoGeneratedId.pm | 4 ++-- lib/Workflow/Persister/DBI/ExtraData.pm | 4 ++-- lib/Workflow/Persister/DBI/SequenceId.pm | 4 ++-- lib/Workflow/Persister/File.pm | 4 ++-- lib/Workflow/Persister/RandomId.pm | 4 ++-- lib/Workflow/Persister/SPOPS.pm | 4 ++-- lib/Workflow/Persister/UUID.pm | 4 ++-- lib/Workflow/State.pm | 6 +++--- lib/Workflow/Validator.pm | 4 ++-- lib/Workflow/Validator/HasRequiredField.pm | 4 ++-- lib/Workflow/Validator/InEnumeratedType.pm | 4 ++-- lib/Workflow/Validator/MatchesDateFormat.pm | 4 ++-- 36 files changed, 73 insertions(+), 73 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index 795439df..a6b6ab6a 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -16,7 +16,7 @@ my @FIELDS = qw( id type description state last_update time_zone ); my @INTERNAL = qw( _factory _observers ); __PACKAGE__->mk_accessors( @FIELDS, @INTERNAL ); -$Workflow::VERSION = '1.59'; +$Workflow::VERSION = '1.60'; use constant NO_CHANGE_VALUE => 'NOCHANGE'; @@ -377,7 +377,7 @@ Workflow - Simple, flexible system to implement workflows =head1 VERSION -This documentation describes version 1.59 of Workflow +This documentation describes version 1.60 of Workflow =head1 SYNOPSIS diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index fa2e5619..bfd28a05 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -12,7 +12,7 @@ use Workflow::Validator::HasRequiredField; use Workflow::Factory qw( FACTORY ); use Carp qw(croak); -$Workflow::Action::VERSION = '1.59'; +$Workflow::Action::VERSION = '1.60'; my @PROPS = qw( name class description group ); my @INTERNAL = qw( _factory ); @@ -167,7 +167,7 @@ Workflow::Action - Base class for Workflow actions =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index b141bb2d..c52b5ab7 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); use English qw( -no_match_vars ); -$Workflow::Action::InputField::VERSION = '1.59'; +$Workflow::Action::InputField::VERSION = '1.60'; my @PROPS = qw( name label description type requirement source_class source_list class ); @@ -121,7 +121,7 @@ Workflow::Action::InputField - Metadata about information required by an Action =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Mailer.pm b/lib/Workflow/Action/Mailer.pm index 1e31bc2f..ef18aae2 100644 --- a/lib/Workflow/Action/Mailer.pm +++ b/lib/Workflow/Action/Mailer.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Mailer::VERSION = '1.59'; +$Workflow::Action::Mailer::VERSION = '1.60'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Mailer - a stub for a SMTP capable action =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index e186b213..e236e831 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Null::VERSION = '1.59'; +$Workflow::Action::Null::VERSION = '1.60'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Null - Workflow action for the terminally lazy =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index 14c211eb..7ebe51f2 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Class::Accessor ); use Log::Log4perl; -$Workflow::Base::VERSION = '1.59'; +$Workflow::Base::VERSION = '1.60'; sub new { my ( $class, @params ) = @_; @@ -96,7 +96,7 @@ Workflow::Base - Base class with constructor =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index fea73682..b88e7898 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -9,7 +9,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( workflow_error condition_error ); $Workflow::Condition::CACHE_RESULTS = 1; -$Workflow::Condition::VERSION = '1.59'; +$Workflow::Condition::VERSION = '1.60'; my $log; my @FIELDS = qw( name class ); @@ -118,7 +118,7 @@ Workflow::Condition - Evaluate a condition depending on the workflow state and e =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index 9e1d2ec2..a2cc4933 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -3,7 +3,7 @@ package Workflow::Condition::CheckReturn; use strict; use warnings; -our $VERSION = '1.59'; +our $VERSION = '1.60'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -90,7 +90,7 @@ Workflow::Condition::CheckReturn =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 52a25966..6813208e 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -8,7 +8,7 @@ use Safe; use Workflow::Exception qw( condition_error configuration_error ); use English qw( -no_match_vars ); -$Workflow::Condition::Evaluate::VERSION = '1.59'; +$Workflow::Condition::Evaluate::VERSION = '1.60'; my @FIELDS = qw( test ); __PACKAGE__->mk_accessors(@FIELDS); @@ -68,7 +68,7 @@ Workflow::Condition::Evaluate - Inline condition that evaluates perl code for tr =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/GreedyOR.pm b/lib/Workflow/Condition/GreedyOR.pm index fe51ea88..89d444a8 100644 --- a/lib/Workflow/Condition/GreedyOR.pm +++ b/lib/Workflow/Condition/GreedyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::GreedyOR; use strict; use warnings; -our $VERSION = '1.59'; +our $VERSION = '1.60'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::GreedyOR =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/HasUser.pm b/lib/Workflow/Condition/HasUser.pm index 82dac430..b3c3fd4e 100644 --- a/lib/Workflow/Condition/HasUser.pm +++ b/lib/Workflow/Condition/HasUser.pm @@ -6,7 +6,7 @@ use base qw( Workflow::Condition ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( condition_error ); -$Workflow::Condition::HasUser::VERSION = '1.59'; +$Workflow::Condition::HasUser::VERSION = '1.60'; my $DEFAULT_USER_KEY = 'current_user'; @@ -41,7 +41,7 @@ Workflow::Condition::HasUser - Condition to determine if a user is available =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/LazyAND.pm b/lib/Workflow/Condition/LazyAND.pm index 57eefdd1..778c9d59 100644 --- a/lib/Workflow/Condition/LazyAND.pm +++ b/lib/Workflow/Condition/LazyAND.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyAND; use strict; use warnings; -our $VERSION = '1.59'; +our $VERSION = '1.60'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::LazyAND =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/LazyOR.pm b/lib/Workflow/Condition/LazyOR.pm index b350d0f2..37858988 100644 --- a/lib/Workflow/Condition/LazyOR.pm +++ b/lib/Workflow/Condition/LazyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyOR; use strict; use warnings; -our $VERSION = '1.59'; +our $VERSION = '1.60'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -55,7 +55,7 @@ Workflow::Condition::LazyOR =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Negated.pm b/lib/Workflow/Condition/Negated.pm index ba79dfde..4d33340d 100644 --- a/lib/Workflow/Condition/Negated.pm +++ b/lib/Workflow/Condition/Negated.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Negated; use strict; use warnings; -our $VERSION = '1.59'; +our $VERSION = '1.60'; use base qw( Workflow::Condition ); @@ -36,7 +36,7 @@ Workflow::Condition::Negated - Negate workflow condition result =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Nested.pm b/lib/Workflow/Condition/Nested.pm index 4722ccab..3c1f2a64 100644 --- a/lib/Workflow/Condition/Nested.pm +++ b/lib/Workflow/Condition/Nested.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Nested; use strict; use warnings; -our $VERSION = '1.59'; +our $VERSION = '1.60'; use base qw( Workflow::Condition ); @@ -19,7 +19,7 @@ Workflow::Condition::Nested - Evaluate nested workflow conditions =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index ccf23c46..0031fd03 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -7,7 +7,7 @@ use Data::Dumper qw( Dumper ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Config::VERSION = '1.59'; +$Workflow::Config::VERSION = '1.60'; # Map the valid type to the top-level XML tag or data # structure to look for. @@ -114,7 +114,7 @@ Workflow::Config - Parse configuration files for the workflow components =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index 4fe5e1d7..00c0668f 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Data::Dumper qw( Dumper ); use English qw( -no_match_vars ); -$Workflow::Config::Perl::VERSION = '1.59'; +$Workflow::Config::Perl::VERSION = '1.60'; sub parse { my ( $self, $type, @items ) = @_; @@ -104,7 +104,7 @@ Workflow::Config::Perl - Parse workflow configurations as Perl data structures =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index 99bf0733..7f597b85 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Config::XML::VERSION = '1.59'; +$Workflow::Config::XML::VERSION = '1.60'; my ($log); @@ -107,7 +107,7 @@ Workflow::Config::XML - Parse workflow configurations from XML content =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Context.pm b/lib/Workflow/Context.pm index 74568ee4..b863d129 100644 --- a/lib/Workflow/Context.pm +++ b/lib/Workflow/Context.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Base ); -$Workflow::Context::VERSION = '1.59'; +$Workflow::Context::VERSION = '1.60'; sub init { @@ -35,7 +35,7 @@ Workflow::Context - Data blackboard for Workflows, Actions, Conditions and Valid =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Exception.pm b/lib/Workflow/Exception.pm index 44e93cd7..f26efbee 100644 --- a/lib/Workflow/Exception.pm +++ b/lib/Workflow/Exception.pm @@ -44,7 +44,7 @@ my %TYPE_LOGGING = ( ); -$Workflow::Exception::VERSION = '1.59'; +$Workflow::Exception::VERSION = '1.60'; @Workflow::Exception::ISA = qw( Exporter Exception::Class::Base ); @Workflow::Exception::EXPORT_OK = keys %TYPE_CLASSES; @@ -129,7 +129,7 @@ Workflow::Exception - Base class for workflow exceptions =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index 7ed0ca26..f144832c 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error workflow_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Factory::VERSION = '1.59'; +$Workflow::Factory::VERSION = '1.60'; # Extra action attribute validation is off by default for compatibility. our $VALIDATE_ACTION_CONFIG = 0; @@ -813,7 +813,7 @@ Workflow::Factory - Generates new workflow and supporting objects =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/History.pm b/lib/Workflow/History.pm index 9a7278c0..251762ca 100644 --- a/lib/Workflow/History.pm +++ b/lib/Workflow/History.pm @@ -5,7 +5,7 @@ use strict; use base qw( Class::Accessor ); use DateTime; -$Workflow::History::VERSION = '1.59'; +$Workflow::History::VERSION = '1.60'; my @FIELDS = qw( id workflow_id action description date user state time_zone ); @@ -66,7 +66,7 @@ Workflow::History - Recorded work on a workflow action or workflow itself =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index dd0625c0..f48cc0f1 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -9,7 +9,7 @@ use Workflow::Exception qw( persist_error ); use constant DEFAULT_ID_LENGTH => 8; -$Workflow::Persister::VERSION = '1.59'; +$Workflow::Persister::VERSION = '1.60'; my @FIELDS = qw( name class use_random use_uuid @@ -160,7 +160,7 @@ Workflow::Persister - Base class for workflow persistence =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index b36c8a6c..34c2ea01 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -19,7 +19,7 @@ use Readonly; Readonly::Scalar my $TRUE => 1; Readonly::Scalar my $FALSE => 0; -$Workflow::Persister::DBI::VERSION = '1.59'; +$Workflow::Persister::DBI::VERSION = '1.60'; my @FIELDS = qw( _wf_fields _hist_fields handle dsn user password driver workflow_table history_table date_format parser autocommit); @@ -463,7 +463,7 @@ Workflow::Persister::DBI - Persist workflow and history to DBI database =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm index 6b53857b..5d93de01 100644 --- a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm +++ b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm @@ -6,7 +6,7 @@ use base qw( Class::Accessor ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.59'; +$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.60'; my @FIELDS = qw( log from_handle handle_property func_property ); __PACKAGE__->mk_accessors(@FIELDS); @@ -65,7 +65,7 @@ Workflow::Persister::DBI::AutoGeneratedId - Pull IDs from databases that autogen =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index ca668fa9..b11eec4d 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::ExtraData::VERSION = '1.59'; +$Workflow::Persister::DBI::ExtraData::VERSION = '1.60'; my @FIELDS = qw( table data_field context_key ); __PACKAGE__->mk_accessors(@FIELDS); @@ -106,7 +106,7 @@ Workflow::Persister::DBI::ExtraData - Fetch extra data with each workflow and pu =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index c0b9a3e5..58da1018 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::SequenceId::VERSION = '1.59'; +$Workflow::Persister::DBI::SequenceId::VERSION = '1.60'; my @FIELDS = qw( log sequence_name sequence_select ); __PACKAGE__->mk_accessors(@FIELDS); @@ -53,7 +53,7 @@ Workflow::Persister::DBI::SequenceId - Persister to fetch ID from a sequence =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 9c6c9db1..5942d666 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -11,7 +11,7 @@ use Workflow::Persister::RandomId; use File::Slurp qw(slurp); use English qw( -no_match_vars ); -$Workflow::Persister::File::VERSION = '1.59'; +$Workflow::Persister::File::VERSION = '1.60'; my @FIELDS = qw( path ); __PACKAGE__->mk_accessors(@FIELDS); @@ -179,7 +179,7 @@ Workflow::Persister::File - Persist workflow and history to the filesystem =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/RandomId.pm b/lib/Workflow/Persister/RandomId.pm index c5e855d6..6fb6e784 100644 --- a/lib/Workflow/Persister/RandomId.pm +++ b/lib/Workflow/Persister/RandomId.pm @@ -8,7 +8,7 @@ use constant DEFAULT_ID_LENGTH => 8; use constant RANDOM_SEED => 26; use constant CONSTANT_INCREMENT => 65; -$Workflow::Persister::RandomId::VERSION = '1.59'; +$Workflow::Persister::RandomId::VERSION = '1.60'; my @FIELDS = qw( id_length ); __PACKAGE__->mk_accessors(@FIELDS); @@ -42,7 +42,7 @@ Workflow::Persister::RandomId - Persister to generate random ID =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/SPOPS.pm b/lib/Workflow/Persister/SPOPS.pm index 85c1c23d..93487c6b 100644 --- a/lib/Workflow/Persister/SPOPS.pm +++ b/lib/Workflow/Persister/SPOPS.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::SPOPS::VERSION = '1.59'; +$Workflow::Persister::SPOPS::VERSION = '1.60'; my @FIELDS = qw( workflow_class history_class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -143,7 +143,7 @@ Workflow::Persister::SPOPS - Persist workflows using SPOPS =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/UUID.pm b/lib/Workflow/Persister/UUID.pm index aa5fe297..b2a8ea21 100644 --- a/lib/Workflow/Persister/UUID.pm +++ b/lib/Workflow/Persister/UUID.pm @@ -4,7 +4,7 @@ use warnings; use strict; use Data::UUID; -$Workflow::Persister::UUID::VERSION = '1.59'; +$Workflow::Persister::UUID::VERSION = '1.60'; sub new { my ( $class, $params ) = @_; @@ -31,7 +31,7 @@ Workflow::Persister::UUID - Persister to generate Universally Unique Identifiers =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index 6866220f..8e2d9ff7 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -11,7 +11,7 @@ use Exception::Class; use Workflow::Factory qw( FACTORY ); use English qw( -no_match_vars ); -$Workflow::State::VERSION = '1.59'; +$Workflow::State::VERSION = '1.60'; my @FIELDS = qw( state description type ); my @INTERNAL = qw( _test_condition_count _factory _actions _conditions @@ -353,7 +353,7 @@ Workflow::State - Information about an individual state in a workflow =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS @@ -503,7 +503,7 @@ Returns name of action to be used for autorunning the state. =head3 clear_condition_cache ( ) -Deprecated, kept for 1.59 compatibility. +Deprecated, kept for 1.60 compatibility. Used to empties the condition result cache for a given state. diff --git a/lib/Workflow/Validator.pm b/lib/Workflow/Validator.pm index 4ea71223..a44e5b39 100644 --- a/lib/Workflow/Validator.pm +++ b/lib/Workflow/Validator.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Base ); use Carp qw(croak); -$Workflow::Validator::VERSION = '1.59'; +$Workflow::Validator::VERSION = '1.60'; my @FIELDS = qw( name class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -43,7 +43,7 @@ Workflow::Validator - Ensure data are valid =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/HasRequiredField.pm b/lib/Workflow/Validator/HasRequiredField.pm index c1d3e8cc..56422d7d 100644 --- a/lib/Workflow/Validator/HasRequiredField.pm +++ b/lib/Workflow/Validator/HasRequiredField.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( validation_error ); -$Workflow::Validator::HasRequiredField::VERSION = '1.59'; +$Workflow::Validator::HasRequiredField::VERSION = '1.60'; sub validate { my ( $self, $wf, @required_fields ) = @_; @@ -34,7 +34,7 @@ Workflow::Validator::HasRequiredField - Validator to ensure certain data are in =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/InEnumeratedType.pm b/lib/Workflow/Validator/InEnumeratedType.pm index e23a8ec4..145c1edc 100644 --- a/lib/Workflow/Validator/InEnumeratedType.pm +++ b/lib/Workflow/Validator/InEnumeratedType.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( configuration_error validation_error ); -$Workflow::Validator::InEnumeratedType::VERSION = '1.59'; +$Workflow::Validator::InEnumeratedType::VERSION = '1.60'; sub _init { my ( $self, $params ) = @_; @@ -59,7 +59,7 @@ Workflow::Validator::InEnumeratedType - Ensure a value is one of a declared set =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index 987f9fe3..d87a4693 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error validation_error ); use English qw( -no_match_vars ); use Carp qw(carp); -$Workflow::Validator::MatchesDateFormat::VERSION = '1.59'; +$Workflow::Validator::MatchesDateFormat::VERSION = '1.60'; __PACKAGE__->mk_accessors('formatter'); @@ -64,7 +64,7 @@ Workflow::Validator::MatchesDateFormat - Ensure a stringified date matches a giv =head1 VERSION -This documentation describes version 1.59 of this package +This documentation describes version 1.60 of this package =head1 SYNOPSIS From f50944a81e19e813dad1ac9c47c247ad2705df74 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Wed, 2 Mar 2022 19:21:26 +0100 Subject: [PATCH 17/35] Minor additions --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 7013123a..b1fcaac4 100644 --- a/.gitignore +++ b/.gitignore @@ -28,3 +28,5 @@ t/workflow_tests.log local/ eg/ticket/db/ eg/ticket/workflow.log +perl-workflow.code-workspace +db/workflow.db From ec8e5fa07cd9b9c5020d6fa98fb78de8869e5e10 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Wed, 2 Mar 2022 19:22:39 +0100 Subject: [PATCH 18/35] Preparing release 1.60 --- Changes.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Changes.md b/Changes.md index 06b30385..aaa4722f 100644 --- a/Changes.md +++ b/Changes.md @@ -6,6 +6,14 @@ SPOPS was developed by the original author of Workflow and the two have worked in parallel for a long time. The Workflow developers have come to a crossroad and focus of resources and efforts are aimed at modernizing workflow. +## 1.60 2022-03-02 bug fix release, update recommended + +- We have discovered a minor regression, founded in our eager to implement more clean code. This has been addressed via PR [#195](https://github.com/jonasbn/perl-workflow/pull/195) by Erik Huelsmann (@ehuelsmann). + + It was followed up by PR [#196](https://github.com/jonasbn/perl-workflow/pull/196/files) by Oliver Welter (@oliwell). + + We are now setting the bar a bit lower for the 1.x releases in regard to best practices and code quality and focus on improving the code for 2.x, so we do not experience any more regressions. + ## 1.59 2022-02-02 bug fix release, update required - Unfortunately we discovered a minor mishap, where a dependency was referenced without being properly declared as a dependency, which could result in inability for the distribution to work in a clean environment. This has now been addressed via PR [#190](https://github.com/jonasbn/perl-workflow/pull/190) From adce2d2df43ecfea8036b42c9b8f9d1d2b784455 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Wed, 2 Mar 2022 19:23:22 +0100 Subject: [PATCH 19/35] Updated from POD --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index aed6358d..9bb55182 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ Workflow - Simple, flexible system to implement workflows # VERSION -This documentation describes version 1.59 of Workflow +This documentation describes version 1.60 of Workflow # SYNOPSIS From 1135ab23612b55559c74b4c143d53eb32414680f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 11 Apr 2022 15:32:46 +0000 Subject: [PATCH 20/35] Bump actions/upload-artifact from 2 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 317e9111..b8b67357 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,7 +56,7 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Upload build results - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: build_results path: build From 298301c96faab72d832e0f7fe8741abd298abc39 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 11 Apr 2022 15:32:43 +0000 Subject: [PATCH 21/35] Bump actions/download-artifact from 2 to 3 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8b67357..b8bb0e25 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,7 +72,7 @@ jobs: steps: - name: Download build results - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: build_results path: build @@ -94,7 +94,7 @@ jobs: steps: - name: Download build results - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: build_results path: build @@ -114,7 +114,7 @@ jobs: steps: - name: Download build results - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: build_results path: build From a04ebf8341dfe35671a53fa14f2ac54a0625cdb0 Mon Sep 17 00:00:00 2001 From: Oliver Welter Date: Mon, 19 Sep 2022 21:11:25 +0200 Subject: [PATCH 22/35] Remove a misleading error condition The removed lines are not related to any local code and will catch up an EVAL_ERROR set inside the caller context of add_history causing this to fail with an error where it must not --- lib/Workflow.pm | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index a6b6ab6a..a5ef2e76 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -208,10 +208,6 @@ sub add_history { workflow_error "I don't know how to add a history of ", "type '", ref($item), "'"; } - - if ($EVAL_ERROR) { - workflow_error "Unable to assert history object"; - } } push @{ $self->{_histories} }, @to_add; $self->notify_observers( 'add history', \@to_add ); From c451c8747a8075794b30cf7ce49f267e8b5dd2f6 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 1 Oct 2022 11:02:39 +0200 Subject: [PATCH 23/35] Preparing release 1.61 --- Changes.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Changes.md b/Changes.md index aaa4722f..542a3034 100644 --- a/Changes.md +++ b/Changes.md @@ -6,6 +6,10 @@ SPOPS was developed by the original author of Workflow and the two have worked in parallel for a long time. The Workflow developers have come to a crossroad and focus of resources and efforts are aimed at modernizing workflow. +## 1.61 2022-10-01 bug fix release, update recommended + +- We have removed some code, which was no longer used, which was causing some grievance see PR [#203](https://github.com/jonasbn/perl-workflow/pull/203) from by Oliver Welter (@oliwell) + ## 1.60 2022-03-02 bug fix release, update recommended - We have discovered a minor regression, founded in our eager to implement more clean code. This has been addressed via PR [#195](https://github.com/jonasbn/perl-workflow/pull/195) by Erik Huelsmann (@ehuelsmann). From 23cff0c33a1b5c0b74fbad353edd4e67ea726bef Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 1 Oct 2022 11:10:56 +0200 Subject: [PATCH 24/35] Bumped version number from 1.60 to 1.61 --- lib/Workflow.pm | 4 ++-- lib/Workflow/Action.pm | 4 ++-- lib/Workflow/Action/InputField.pm | 4 ++-- lib/Workflow/Action/Mailer.pm | 4 ++-- lib/Workflow/Action/Null.pm | 4 ++-- lib/Workflow/Base.pm | 4 ++-- lib/Workflow/Condition.pm | 4 ++-- lib/Workflow/Condition/CheckReturn.pm | 4 ++-- lib/Workflow/Condition/Evaluate.pm | 4 ++-- lib/Workflow/Condition/GreedyOR.pm | 4 ++-- lib/Workflow/Condition/HasUser.pm | 4 ++-- lib/Workflow/Condition/LazyAND.pm | 4 ++-- lib/Workflow/Condition/LazyOR.pm | 4 ++-- lib/Workflow/Condition/Negated.pm | 4 ++-- lib/Workflow/Condition/Nested.pm | 4 ++-- lib/Workflow/Config.pm | 4 ++-- lib/Workflow/Config/Perl.pm | 4 ++-- lib/Workflow/Config/XML.pm | 4 ++-- lib/Workflow/Context.pm | 4 ++-- lib/Workflow/Exception.pm | 4 ++-- lib/Workflow/Factory.pm | 4 ++-- lib/Workflow/History.pm | 4 ++-- lib/Workflow/Persister.pm | 4 ++-- lib/Workflow/Persister/DBI.pm | 4 ++-- lib/Workflow/Persister/DBI/AutoGeneratedId.pm | 4 ++-- lib/Workflow/Persister/DBI/ExtraData.pm | 4 ++-- lib/Workflow/Persister/DBI/SequenceId.pm | 4 ++-- lib/Workflow/Persister/File.pm | 4 ++-- lib/Workflow/Persister/RandomId.pm | 4 ++-- lib/Workflow/Persister/SPOPS.pm | 4 ++-- lib/Workflow/Persister/UUID.pm | 4 ++-- lib/Workflow/State.pm | 6 +++--- lib/Workflow/Validator.pm | 4 ++-- lib/Workflow/Validator/HasRequiredField.pm | 4 ++-- lib/Workflow/Validator/InEnumeratedType.pm | 4 ++-- lib/Workflow/Validator/MatchesDateFormat.pm | 4 ++-- 36 files changed, 73 insertions(+), 73 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index a5ef2e76..bd0018e6 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -16,7 +16,7 @@ my @FIELDS = qw( id type description state last_update time_zone ); my @INTERNAL = qw( _factory _observers ); __PACKAGE__->mk_accessors( @FIELDS, @INTERNAL ); -$Workflow::VERSION = '1.60'; +$Workflow::VERSION = '1.61'; use constant NO_CHANGE_VALUE => 'NOCHANGE'; @@ -373,7 +373,7 @@ Workflow - Simple, flexible system to implement workflows =head1 VERSION -This documentation describes version 1.60 of Workflow +This documentation describes version 1.61 of Workflow =head1 SYNOPSIS diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index bfd28a05..afc37caf 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -12,7 +12,7 @@ use Workflow::Validator::HasRequiredField; use Workflow::Factory qw( FACTORY ); use Carp qw(croak); -$Workflow::Action::VERSION = '1.60'; +$Workflow::Action::VERSION = '1.61'; my @PROPS = qw( name class description group ); my @INTERNAL = qw( _factory ); @@ -167,7 +167,7 @@ Workflow::Action - Base class for Workflow actions =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index c52b5ab7..b441c0c1 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); use English qw( -no_match_vars ); -$Workflow::Action::InputField::VERSION = '1.60'; +$Workflow::Action::InputField::VERSION = '1.61'; my @PROPS = qw( name label description type requirement source_class source_list class ); @@ -121,7 +121,7 @@ Workflow::Action::InputField - Metadata about information required by an Action =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Mailer.pm b/lib/Workflow/Action/Mailer.pm index ef18aae2..37d68c7f 100644 --- a/lib/Workflow/Action/Mailer.pm +++ b/lib/Workflow/Action/Mailer.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Mailer::VERSION = '1.60'; +$Workflow::Action::Mailer::VERSION = '1.61'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Mailer - a stub for a SMTP capable action =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index e236e831..dc235dfb 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Null::VERSION = '1.60'; +$Workflow::Action::Null::VERSION = '1.61'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Null - Workflow action for the terminally lazy =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index 7ebe51f2..46c4fad1 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Class::Accessor ); use Log::Log4perl; -$Workflow::Base::VERSION = '1.60'; +$Workflow::Base::VERSION = '1.61'; sub new { my ( $class, @params ) = @_; @@ -96,7 +96,7 @@ Workflow::Base - Base class with constructor =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index b88e7898..f3488dec 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -9,7 +9,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( workflow_error condition_error ); $Workflow::Condition::CACHE_RESULTS = 1; -$Workflow::Condition::VERSION = '1.60'; +$Workflow::Condition::VERSION = '1.61'; my $log; my @FIELDS = qw( name class ); @@ -118,7 +118,7 @@ Workflow::Condition - Evaluate a condition depending on the workflow state and e =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index a2cc4933..697dc103 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -3,7 +3,7 @@ package Workflow::Condition::CheckReturn; use strict; use warnings; -our $VERSION = '1.60'; +our $VERSION = '1.61'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -90,7 +90,7 @@ Workflow::Condition::CheckReturn =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 6813208e..19841099 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -8,7 +8,7 @@ use Safe; use Workflow::Exception qw( condition_error configuration_error ); use English qw( -no_match_vars ); -$Workflow::Condition::Evaluate::VERSION = '1.60'; +$Workflow::Condition::Evaluate::VERSION = '1.61'; my @FIELDS = qw( test ); __PACKAGE__->mk_accessors(@FIELDS); @@ -68,7 +68,7 @@ Workflow::Condition::Evaluate - Inline condition that evaluates perl code for tr =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/GreedyOR.pm b/lib/Workflow/Condition/GreedyOR.pm index 89d444a8..19ea05d4 100644 --- a/lib/Workflow/Condition/GreedyOR.pm +++ b/lib/Workflow/Condition/GreedyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::GreedyOR; use strict; use warnings; -our $VERSION = '1.60'; +our $VERSION = '1.61'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::GreedyOR =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/HasUser.pm b/lib/Workflow/Condition/HasUser.pm index b3c3fd4e..9722b3c6 100644 --- a/lib/Workflow/Condition/HasUser.pm +++ b/lib/Workflow/Condition/HasUser.pm @@ -6,7 +6,7 @@ use base qw( Workflow::Condition ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( condition_error ); -$Workflow::Condition::HasUser::VERSION = '1.60'; +$Workflow::Condition::HasUser::VERSION = '1.61'; my $DEFAULT_USER_KEY = 'current_user'; @@ -41,7 +41,7 @@ Workflow::Condition::HasUser - Condition to determine if a user is available =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/LazyAND.pm b/lib/Workflow/Condition/LazyAND.pm index 778c9d59..79d13f9a 100644 --- a/lib/Workflow/Condition/LazyAND.pm +++ b/lib/Workflow/Condition/LazyAND.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyAND; use strict; use warnings; -our $VERSION = '1.60'; +our $VERSION = '1.61'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::LazyAND =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/LazyOR.pm b/lib/Workflow/Condition/LazyOR.pm index 37858988..aed43ea1 100644 --- a/lib/Workflow/Condition/LazyOR.pm +++ b/lib/Workflow/Condition/LazyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyOR; use strict; use warnings; -our $VERSION = '1.60'; +our $VERSION = '1.61'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -55,7 +55,7 @@ Workflow::Condition::LazyOR =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Negated.pm b/lib/Workflow/Condition/Negated.pm index 4d33340d..75b5130c 100644 --- a/lib/Workflow/Condition/Negated.pm +++ b/lib/Workflow/Condition/Negated.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Negated; use strict; use warnings; -our $VERSION = '1.60'; +our $VERSION = '1.61'; use base qw( Workflow::Condition ); @@ -36,7 +36,7 @@ Workflow::Condition::Negated - Negate workflow condition result =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Nested.pm b/lib/Workflow/Condition/Nested.pm index 3c1f2a64..db5d7950 100644 --- a/lib/Workflow/Condition/Nested.pm +++ b/lib/Workflow/Condition/Nested.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Nested; use strict; use warnings; -our $VERSION = '1.60'; +our $VERSION = '1.61'; use base qw( Workflow::Condition ); @@ -19,7 +19,7 @@ Workflow::Condition::Nested - Evaluate nested workflow conditions =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index 0031fd03..bb235aaa 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -7,7 +7,7 @@ use Data::Dumper qw( Dumper ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Config::VERSION = '1.60'; +$Workflow::Config::VERSION = '1.61'; # Map the valid type to the top-level XML tag or data # structure to look for. @@ -114,7 +114,7 @@ Workflow::Config - Parse configuration files for the workflow components =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index 00c0668f..147c31b9 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Data::Dumper qw( Dumper ); use English qw( -no_match_vars ); -$Workflow::Config::Perl::VERSION = '1.60'; +$Workflow::Config::Perl::VERSION = '1.61'; sub parse { my ( $self, $type, @items ) = @_; @@ -104,7 +104,7 @@ Workflow::Config::Perl - Parse workflow configurations as Perl data structures =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index 7f597b85..b057b8c9 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Config::XML::VERSION = '1.60'; +$Workflow::Config::XML::VERSION = '1.61'; my ($log); @@ -107,7 +107,7 @@ Workflow::Config::XML - Parse workflow configurations from XML content =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Context.pm b/lib/Workflow/Context.pm index b863d129..f492e13a 100644 --- a/lib/Workflow/Context.pm +++ b/lib/Workflow/Context.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Base ); -$Workflow::Context::VERSION = '1.60'; +$Workflow::Context::VERSION = '1.61'; sub init { @@ -35,7 +35,7 @@ Workflow::Context - Data blackboard for Workflows, Actions, Conditions and Valid =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Exception.pm b/lib/Workflow/Exception.pm index f26efbee..a3b541dc 100644 --- a/lib/Workflow/Exception.pm +++ b/lib/Workflow/Exception.pm @@ -44,7 +44,7 @@ my %TYPE_LOGGING = ( ); -$Workflow::Exception::VERSION = '1.60'; +$Workflow::Exception::VERSION = '1.61'; @Workflow::Exception::ISA = qw( Exporter Exception::Class::Base ); @Workflow::Exception::EXPORT_OK = keys %TYPE_CLASSES; @@ -129,7 +129,7 @@ Workflow::Exception - Base class for workflow exceptions =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index f144832c..7642cc84 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error workflow_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Factory::VERSION = '1.60'; +$Workflow::Factory::VERSION = '1.61'; # Extra action attribute validation is off by default for compatibility. our $VALIDATE_ACTION_CONFIG = 0; @@ -813,7 +813,7 @@ Workflow::Factory - Generates new workflow and supporting objects =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/History.pm b/lib/Workflow/History.pm index 251762ca..9a378af1 100644 --- a/lib/Workflow/History.pm +++ b/lib/Workflow/History.pm @@ -5,7 +5,7 @@ use strict; use base qw( Class::Accessor ); use DateTime; -$Workflow::History::VERSION = '1.60'; +$Workflow::History::VERSION = '1.61'; my @FIELDS = qw( id workflow_id action description date user state time_zone ); @@ -66,7 +66,7 @@ Workflow::History - Recorded work on a workflow action or workflow itself =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index f48cc0f1..a579d907 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -9,7 +9,7 @@ use Workflow::Exception qw( persist_error ); use constant DEFAULT_ID_LENGTH => 8; -$Workflow::Persister::VERSION = '1.60'; +$Workflow::Persister::VERSION = '1.61'; my @FIELDS = qw( name class use_random use_uuid @@ -160,7 +160,7 @@ Workflow::Persister - Base class for workflow persistence =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 34c2ea01..1ef51443 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -19,7 +19,7 @@ use Readonly; Readonly::Scalar my $TRUE => 1; Readonly::Scalar my $FALSE => 0; -$Workflow::Persister::DBI::VERSION = '1.60'; +$Workflow::Persister::DBI::VERSION = '1.61'; my @FIELDS = qw( _wf_fields _hist_fields handle dsn user password driver workflow_table history_table date_format parser autocommit); @@ -463,7 +463,7 @@ Workflow::Persister::DBI - Persist workflow and history to DBI database =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm index 5d93de01..70f5d768 100644 --- a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm +++ b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm @@ -6,7 +6,7 @@ use base qw( Class::Accessor ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.60'; +$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.61'; my @FIELDS = qw( log from_handle handle_property func_property ); __PACKAGE__->mk_accessors(@FIELDS); @@ -65,7 +65,7 @@ Workflow::Persister::DBI::AutoGeneratedId - Pull IDs from databases that autogen =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index b11eec4d..64ee97fb 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::ExtraData::VERSION = '1.60'; +$Workflow::Persister::DBI::ExtraData::VERSION = '1.61'; my @FIELDS = qw( table data_field context_key ); __PACKAGE__->mk_accessors(@FIELDS); @@ -106,7 +106,7 @@ Workflow::Persister::DBI::ExtraData - Fetch extra data with each workflow and pu =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index 58da1018..da278043 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::SequenceId::VERSION = '1.60'; +$Workflow::Persister::DBI::SequenceId::VERSION = '1.61'; my @FIELDS = qw( log sequence_name sequence_select ); __PACKAGE__->mk_accessors(@FIELDS); @@ -53,7 +53,7 @@ Workflow::Persister::DBI::SequenceId - Persister to fetch ID from a sequence =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 5942d666..6b4ba49d 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -11,7 +11,7 @@ use Workflow::Persister::RandomId; use File::Slurp qw(slurp); use English qw( -no_match_vars ); -$Workflow::Persister::File::VERSION = '1.60'; +$Workflow::Persister::File::VERSION = '1.61'; my @FIELDS = qw( path ); __PACKAGE__->mk_accessors(@FIELDS); @@ -179,7 +179,7 @@ Workflow::Persister::File - Persist workflow and history to the filesystem =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/RandomId.pm b/lib/Workflow/Persister/RandomId.pm index 6fb6e784..bc3bc169 100644 --- a/lib/Workflow/Persister/RandomId.pm +++ b/lib/Workflow/Persister/RandomId.pm @@ -8,7 +8,7 @@ use constant DEFAULT_ID_LENGTH => 8; use constant RANDOM_SEED => 26; use constant CONSTANT_INCREMENT => 65; -$Workflow::Persister::RandomId::VERSION = '1.60'; +$Workflow::Persister::RandomId::VERSION = '1.61'; my @FIELDS = qw( id_length ); __PACKAGE__->mk_accessors(@FIELDS); @@ -42,7 +42,7 @@ Workflow::Persister::RandomId - Persister to generate random ID =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/SPOPS.pm b/lib/Workflow/Persister/SPOPS.pm index 93487c6b..579377d4 100644 --- a/lib/Workflow/Persister/SPOPS.pm +++ b/lib/Workflow/Persister/SPOPS.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::SPOPS::VERSION = '1.60'; +$Workflow::Persister::SPOPS::VERSION = '1.61'; my @FIELDS = qw( workflow_class history_class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -143,7 +143,7 @@ Workflow::Persister::SPOPS - Persist workflows using SPOPS =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/UUID.pm b/lib/Workflow/Persister/UUID.pm index b2a8ea21..245d6ab6 100644 --- a/lib/Workflow/Persister/UUID.pm +++ b/lib/Workflow/Persister/UUID.pm @@ -4,7 +4,7 @@ use warnings; use strict; use Data::UUID; -$Workflow::Persister::UUID::VERSION = '1.60'; +$Workflow::Persister::UUID::VERSION = '1.61'; sub new { my ( $class, $params ) = @_; @@ -31,7 +31,7 @@ Workflow::Persister::UUID - Persister to generate Universally Unique Identifiers =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index 8e2d9ff7..7095852e 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -11,7 +11,7 @@ use Exception::Class; use Workflow::Factory qw( FACTORY ); use English qw( -no_match_vars ); -$Workflow::State::VERSION = '1.60'; +$Workflow::State::VERSION = '1.61'; my @FIELDS = qw( state description type ); my @INTERNAL = qw( _test_condition_count _factory _actions _conditions @@ -353,7 +353,7 @@ Workflow::State - Information about an individual state in a workflow =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS @@ -503,7 +503,7 @@ Returns name of action to be used for autorunning the state. =head3 clear_condition_cache ( ) -Deprecated, kept for 1.60 compatibility. +Deprecated, kept for 1.61 compatibility. Used to empties the condition result cache for a given state. diff --git a/lib/Workflow/Validator.pm b/lib/Workflow/Validator.pm index a44e5b39..89dbf4af 100644 --- a/lib/Workflow/Validator.pm +++ b/lib/Workflow/Validator.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Base ); use Carp qw(croak); -$Workflow::Validator::VERSION = '1.60'; +$Workflow::Validator::VERSION = '1.61'; my @FIELDS = qw( name class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -43,7 +43,7 @@ Workflow::Validator - Ensure data are valid =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/HasRequiredField.pm b/lib/Workflow/Validator/HasRequiredField.pm index 56422d7d..0f97ab80 100644 --- a/lib/Workflow/Validator/HasRequiredField.pm +++ b/lib/Workflow/Validator/HasRequiredField.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( validation_error ); -$Workflow::Validator::HasRequiredField::VERSION = '1.60'; +$Workflow::Validator::HasRequiredField::VERSION = '1.61'; sub validate { my ( $self, $wf, @required_fields ) = @_; @@ -34,7 +34,7 @@ Workflow::Validator::HasRequiredField - Validator to ensure certain data are in =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/InEnumeratedType.pm b/lib/Workflow/Validator/InEnumeratedType.pm index 145c1edc..bbbba358 100644 --- a/lib/Workflow/Validator/InEnumeratedType.pm +++ b/lib/Workflow/Validator/InEnumeratedType.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( configuration_error validation_error ); -$Workflow::Validator::InEnumeratedType::VERSION = '1.60'; +$Workflow::Validator::InEnumeratedType::VERSION = '1.61'; sub _init { my ( $self, $params ) = @_; @@ -59,7 +59,7 @@ Workflow::Validator::InEnumeratedType - Ensure a value is one of a declared set =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index d87a4693..ba138ab6 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error validation_error ); use English qw( -no_match_vars ); use Carp qw(carp); -$Workflow::Validator::MatchesDateFormat::VERSION = '1.60'; +$Workflow::Validator::MatchesDateFormat::VERSION = '1.61'; __PACKAGE__->mk_accessors('formatter'); @@ -64,7 +64,7 @@ Workflow::Validator::MatchesDateFormat - Ensure a stringified date matches a giv =head1 VERSION -This documentation describes version 1.60 of this package +This documentation describes version 1.61 of this package =head1 SYNOPSIS From b22e4cd218116ba87e0fd044e0274d080a36e5c3 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 1 Oct 2022 11:27:36 +0200 Subject: [PATCH 25/35] Updated from POD --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9bb55182..cec2eccb 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ Workflow - Simple, flexible system to implement workflows # VERSION -This documentation describes version 1.60 of Workflow +This documentation describes version 1.61 of Workflow # SYNOPSIS From 5807010afb7fc58b127fb0f6ff6f1e42ffd76e73 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Sat, 15 Oct 2022 22:44:06 +0200 Subject: [PATCH 26/35] Fix up documentation for get_current_actions( [$group] ) --- lib/Workflow.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index f7d9b0ae..86d33a54 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -944,14 +944,14 @@ If you want to divide actions in groups (for example state change group, approval group, which have to be shown at different places on the page) add group property to your action - - + + -my @actions = $wf->get_current_actions("approval"); + my @actions = $wf->get_current_actions("approval"); -$group should be string that reperesents desired group name. In @actions you will get +C<$group> should be string that reperesents desired group name. In @actions you will get list of action names available from the current state for the given environment limited by group. -$group is optional parameter. +C<$group> is optional parameter. Returns: list of strings representing available actions From 67eaa62332c3de3346389a234d14dfb6158c1408 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Sat, 15 Oct 2022 20:18:47 +0200 Subject: [PATCH 27/35] Change the location of the 'type' config key Document where the config key is actually expected... --- lib/Workflow/Config.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index b893cb68..4c891191 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -352,6 +352,7 @@ may hold a 'condition' key with one or more named conditions conditions: + type $ condition \@ name $ class $ @@ -392,11 +393,11 @@ keys actions: + type $ action \@ name $ class $ description $ - type $ field \@ name $ is_required yes|no From ba6f730cb56b55f7fad81539cea83fd611a9fcfc Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Fri, 27 Jan 2023 23:37:06 +0100 Subject: [PATCH 28/35] Non-bareword dir handle makes Perl::Critic happy --- lib/Workflow/Persister/File.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 6b4ba49d..11e0a031 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -98,11 +98,11 @@ sub fetch_history { my ( $self, $wf ) = @_; my $history_dir = $self->_get_history_path($wf); $self->log->debug("Trying to read history files from dir '$history_dir'"); - opendir( HISTORY, $history_dir ) + opendir( my $hist, $history_dir ) || persist_error "Cannot read history from '$history_dir': $!"; my @history_files = grep { -f $_ } - map { catfile( $history_dir, $_ ) } readdir HISTORY; - closedir HISTORY; + map { catfile( $history_dir, $_ ) } readdir $hist; + closedir $hist; my @histories = (); foreach my $history_file (@history_files) { From 895ca22ff4f4e9bbf317113060818f513377f2a5 Mon Sep 17 00:00:00 2001 From: Erik Huelsmann Date: Fri, 27 Jan 2023 23:24:41 +0100 Subject: [PATCH 29/35] Do not clobber $EVAL_ERROR by localizing before `eval` --- lib/Workflow.pm | 3 +++ lib/Workflow/Action/InputField.pm | 1 + lib/Workflow/Condition.pm | 2 ++ lib/Workflow/Condition/CheckReturn.pm | 2 ++ lib/Workflow/Condition/Evaluate.pm | 1 + lib/Workflow/Config/Perl.pm | 1 + lib/Workflow/Config/XML.pm | 3 +++ lib/Workflow/Factory.pm | 18 ++++++++++++++++++ lib/Workflow/Persister.pm | 3 +++ lib/Workflow/Persister/DBI.pm | 14 ++++++++++++++ lib/Workflow/Persister/DBI/ExtraData.pm | 1 + lib/Workflow/Persister/DBI/SequenceId.pm | 2 ++ lib/Workflow/Persister/File.pm | 3 +++ lib/Workflow/State.pm | 2 ++ lib/Workflow/Validator/MatchesDateFormat.pm | 1 + 15 files changed, 57 insertions(+) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index e8577345..80b9d062 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -116,6 +116,7 @@ sub execute_action { my $old_state = $self->state; my ( $new_state, $action_return ); + local $EVAL_ERROR = undef; eval { $action->validate($self); $self->log->debug("Action validated ok"); @@ -332,6 +333,8 @@ sub _get_next_state { sub _auto_execute_state { my ( $self, $wf_state ) = @_; my $action_name; + + local $EVAL_ERROR = undef; eval { $action_name = $wf_state->get_autorun_action_name($self); }; if ($EVAL_ERROR) { # we found an error, possibly more than one or none action diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index b441c0c1..72b4f777 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -51,6 +51,7 @@ sub new { if ( my $source_class = $self->source_class ) { $log->debug("Possible values for '$name' from '$source_class'"); unless ( $INCLUDED{$source_class} ) { + local $EVAL_ERROR = undef; eval "require $source_class"; if ($EVAL_ERROR) { configuration_error "Failed to include source class ", diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index f3488dec..d3221f71 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -63,6 +63,8 @@ sub evaluate_condition { ->get_condition( $orig_condition, $wf->type ); $log->debug( "Evaluating condition '$orig_condition'" ); my $return_value; + + local $EVAL_ERROR = undef; eval { $return_value = $condition->evaluate($wf) }; if ($EVAL_ERROR) { diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index 697dc103..cea7ab9c 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -63,11 +63,13 @@ sub evaluate { } elsif ( $arg =~ /^[a-zA-Z0-9_]+$/ ) { # alpha-numeric, plus '_' $argval = $wf->context->param($arg); } else { + local $EVAL_ERROR = undef; $argval = eval $arg; } my $condval = $self->evaluate_condition( $wf, $cond ); + local $EVAL_ERROR = undef; if ( eval "\$condval $op \$argval" ) { return 1; } else { diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 19841099..824b5bea 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -40,6 +40,7 @@ sub evaluate { my $safe = Safe->new(); $safe->share('$context'); + local $EVAL_ERROR = undef; my $rv = $safe->reval($to_eval); if ($EVAL_ERROR) { condition_error diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index 147c31b9..9a4be971 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -84,6 +84,7 @@ sub _translate_perl { my $log = get_logger(); no strict 'vars'; + local $EVAL_ERROR = undef; my $data = eval $config; if ($EVAL_ERROR) { configuration_error "Cannot evaluate perl data structure ", diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index b057b8c9..59209281 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -55,6 +55,8 @@ sub parse { my $file_name = ( ref $item ) ? '[scalar ref]' : $item; $log->info("Will parse '$type' XML config file '$file_name'"); my $this_config; + + local $EVAL_ERROR = undef; eval { $this_config = $self->_translate_xml( $type, $item ); }; # If processing multiple config files, this makes it much easier @@ -81,6 +83,7 @@ sub parse { sub _translate_xml { my ( $self, $type, $config ) = @_; unless ($XML_REQUIRED) { + local $EVAL_ERROR = undef; eval { require XML::Simple }; if ($EVAL_ERROR) { configuration_error "XML::Simple must be installed to parse ", diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index 7642cc84..21f37bc6 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -315,6 +315,8 @@ sub _load_observers { sub _load_class { my ( $self, $class_to_load, $msg ) = @_; + + local $EVAL_ERROR = undef; eval "require $class_to_load"; if ($EVAL_ERROR) { my $full_msg = sprintf $msg, $class_to_load, $EVAL_ERROR; @@ -450,6 +452,8 @@ sub save_workflow { my $wf_config = $self->_get_workflow_config( $wf->type ); my $persister = $self->get_persister( $wf_config->{persister} ); + + local $EVAL_ERROR = undef; eval { $persister->update_workflow($wf); $self->log->info( "Workflow '", $wf->id, "' updated ok" ); @@ -538,6 +542,8 @@ sub _add_action_config { } $self->log->debug( "Trying to include action class '$action_class'..."); + + local $EVAL_ERROR = undef; eval "require $action_class"; if ($EVAL_ERROR) { my $msg = $EVAL_ERROR; @@ -599,6 +605,8 @@ sub _add_persister_config { } $self->log->debug( "Trying to include persister class '$persister_class'..."); + + local $EVAL_ERROR = undef; eval "require $persister_class"; if ($EVAL_ERROR) { configuration_error "Cannot include persister class ", @@ -607,6 +615,8 @@ sub _add_persister_config { $self->log->debug( "Included persister '$name' class '$persister_class' ", "ok; now try to instantiate persister..." ); + + # $EVAL_ERROR already localized above my $persister = eval { $persister_class->new($persister_config) }; if ($EVAL_ERROR) { configuration_error "Failed to create instance of persister ", @@ -678,6 +688,8 @@ sub _add_condition_config { } $self->log->debug( "Trying to include condition class '$condition_class'"); + + local $EVAL_ERROR = undef; eval "require $condition_class"; if ($EVAL_ERROR) { configuration_error "Cannot include condition class ", @@ -686,6 +698,8 @@ sub _add_condition_config { $self->log->debug( "Included condition '$name' class '$condition_class' ", "ok; now try to instantiate condition..." ); + + # $EVAL_ERROR already localized above my $condition = eval { $condition_class->new($condition_config) }; if ($EVAL_ERROR) { configuration_error @@ -764,6 +778,8 @@ sub _add_validator_config { } $self->log->debug( "Trying to include validator class '$validator_class'"); + + local $EVAL_ERROR = undef; eval "require $validator_class"; if ($EVAL_ERROR) { workflow_error @@ -773,6 +789,8 @@ sub _add_validator_config { "Included validator '$name' class '$validator_class' ", " ok; now try to instantiate validator..." ); + + # $EVAL_ERROR already localized above my $validator = eval { $validator_class->new($validator_config) }; if ($EVAL_ERROR) { workflow_error "Cannot create validator '$name': $EVAL_ERROR"; diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index a579d907..67e9af34 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -54,6 +54,8 @@ sub assign_generators { sub init_random_generators { my ( $self, $params ) = @_; my $length = $params->{id_length} || DEFAULT_ID_LENGTH; + + local $EVAL_ERROR = undef; eval { require Workflow::Persister::RandomId }; if (my $msg = $EVAL_ERROR) { $msg =~ s/\\n/ /g; @@ -67,6 +69,7 @@ sub init_random_generators { sub init_uuid_generators { my ( $self, $params ) = @_; + local $EVAL_ERROR = undef; eval { require Workflow::Persister::UUID }; if (my $msg = $EVAL_ERROR) { $msg =~ s/\\n/ /g; diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 1ef51443..56db7428 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -73,6 +73,8 @@ sub create_handle { "key 'dsn' which maps to the first paramter ", "in the DBI 'connect()' call."; } + + local $EVAL_ERROR = undef; my $dbh = eval { DBI->connect( $self->dsn, $self->user, $self->password ) || croak "Cannot connect to database: $DBI::errstr"; @@ -217,6 +219,8 @@ sub create_workflow { } my ($sth); + + local $EVAL_ERROR = undef; eval { $sth = $dbh->prepare($sql); $sth->execute(@values); @@ -253,6 +257,8 @@ sub fetch_workflow { } my ($sth); + + local $EVAL_ERROR = undef; eval { $sth = $self->handle->prepare($sql); $sth->execute($wf_id); @@ -287,6 +293,8 @@ sub update_workflow { } my ($sth); + + local $EVAL_ERROR = undef; eval { $sth = $self->handle->prepare($sql); $sth->execute( $wf->state, $update_date, $wf->id ); @@ -326,6 +334,8 @@ sub create_history { } my ($sth); + + local $EVAL_ERROR = undef; eval { $sth = $dbh->prepare($sql); $sth->execute(@values); @@ -364,6 +374,8 @@ sub fetch_history { } my ($sth); + + local $EVAL_ERROR = undef; eval { $sth = $self->handle->prepare($sql); $sth->execute( $wf->id ); @@ -397,6 +409,7 @@ sub fetch_history { sub commit_transaction { my ( $self, $wf ) = @_; if ( not $self->autocommit() ) { + local $EVAL_ERROR = undef; eval { $self->handle->commit(); }; if ($EVAL_ERROR) { $self->log->error("Caught error committing transaction: $EVAL_ERROR"); @@ -408,6 +421,7 @@ sub commit_transaction { sub rollback_transaction { my ( $self, $wf ) = @_; if ( not $self->autocommit() ) { + local $EVAL_ERROR = undef; eval { $self->handle->rollback(); }; if ($EVAL_ERROR) { $self->log->error("Caught error rolling back transaction: $EVAL_ERROR"); diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index 64ee97fb..3bd35ab9 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -65,6 +65,7 @@ sub fetch_extra_workflow_data { $self->log->debug( "Bind parameters: ", $wf->id ); my ($sth); + local $EVAL_ERROR = undef; eval { $sth = $self->handle->prepare($sql); $sth->execute( $wf->id ); diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index da278043..9526297c 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -27,6 +27,8 @@ sub pre_fetch_id { my $full_select = sprintf $self->sequence_select, $self->sequence_name; $self->log->debug("SQL to fetch sequence: ", $full_select); my ($row); + + local $EVAL_ERROR = undef; eval { my $sth = $dbh->prepare($full_select); $sth->execute; diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 11e0a031..18103ffb 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -61,6 +61,8 @@ sub fetch_workflow { persist_error "No workflow with ID '$wf_id' is available"; } $self->log->debug("File exists, reconstituting workflow"); + + local $EVAL_ERROR = undef; my $wf_info = eval { $self->constitute_object($full_path) }; if ($EVAL_ERROR) { persist_error "Cannot reconstitute data from file for ", @@ -149,6 +151,7 @@ sub constitute_object { my $content = slurp($object_path); no strict; + local $EVAL_ERROR = undef; my $object = eval $content; croak $EVAL_ERROR if ($EVAL_ERROR); return $object; diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index 7095852e..a3ca06c3 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -78,6 +78,7 @@ sub get_available_action_names { sub is_action_available { my ( $self, $wf, $action_name ) = @_; + local $EVAL_ERROR = undef; eval { $self->evaluate_action( $wf, $action_name ) }; # Everything is fine @@ -108,6 +109,7 @@ sub evaluate_action { my $condition_name = $condition->name; my $rv; + local $EVAL_ERROR = undef; eval { $rv = Workflow::Condition->evaluate_condition($wf, $condition_name); }; diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index ba138ab6..89749aec 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -35,6 +35,7 @@ sub validate { return unless ($date_string); # already converted! + local $EVAL_ERROR = undef; if ( ref $date_string and eval { $date_string->isa('DateTime'); } ) { return; } From 62433e5a3774f42051d300dc3f47376bbf908141 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Feb 2023 20:39:19 +0100 Subject: [PATCH 30/35] Change log updated with description of release 1.62 --- Changes.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Changes.md b/Changes.md index 542a3034..05f9c879 100644 --- a/Changes.md +++ b/Changes.md @@ -6,6 +6,12 @@ SPOPS was developed by the original author of Workflow and the two have worked in parallel for a long time. The Workflow developers have come to a crossroad and focus of resources and efforts are aimed at modernizing workflow. +## 1.62 2023-02-11 bug fix/maintenance release, update recommended + +- Minor correction to documentation via PR [#208](https://github.com/jonasbn/perl-workflow/pull/208) from @ehuelsmann + +- Improvement to the overall codebase by localizing `$EVAL_ERROR` in conjunction with `eval` structures, via PR [#211](https://github.com/jonasbn/perl-workflow/pull/211) from @ehuelsmann + ## 1.61 2022-10-01 bug fix release, update recommended - We have removed some code, which was no longer used, which was causing some grievance see PR [#203](https://github.com/jonasbn/perl-workflow/pull/203) from by Oliver Welter (@oliwell) From 54420ceebb6627a5b596989be3cbecef6a1c020e Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Feb 2023 20:42:50 +0100 Subject: [PATCH 31/35] Bumped version number to 1.62 --- lib/Workflow.pm | 4 ++-- lib/Workflow/Action.pm | 4 ++-- lib/Workflow/Action/InputField.pm | 4 ++-- lib/Workflow/Action/Mailer.pm | 4 ++-- lib/Workflow/Action/Null.pm | 4 ++-- lib/Workflow/Base.pm | 4 ++-- lib/Workflow/Condition.pm | 4 ++-- lib/Workflow/Condition/CheckReturn.pm | 4 ++-- lib/Workflow/Condition/Evaluate.pm | 4 ++-- lib/Workflow/Condition/GreedyOR.pm | 4 ++-- lib/Workflow/Condition/HasUser.pm | 4 ++-- lib/Workflow/Condition/LazyAND.pm | 4 ++-- lib/Workflow/Condition/LazyOR.pm | 4 ++-- lib/Workflow/Condition/Negated.pm | 4 ++-- lib/Workflow/Condition/Nested.pm | 4 ++-- lib/Workflow/Config.pm | 4 ++-- lib/Workflow/Config/Perl.pm | 4 ++-- lib/Workflow/Config/XML.pm | 4 ++-- lib/Workflow/Context.pm | 4 ++-- lib/Workflow/Exception.pm | 4 ++-- lib/Workflow/Factory.pm | 4 ++-- lib/Workflow/History.pm | 4 ++-- lib/Workflow/Persister.pm | 4 ++-- lib/Workflow/Persister/DBI.pm | 4 ++-- lib/Workflow/Persister/DBI/AutoGeneratedId.pm | 4 ++-- lib/Workflow/Persister/DBI/ExtraData.pm | 4 ++-- lib/Workflow/Persister/DBI/SequenceId.pm | 4 ++-- lib/Workflow/Persister/File.pm | 4 ++-- lib/Workflow/Persister/RandomId.pm | 4 ++-- lib/Workflow/Persister/SPOPS.pm | 4 ++-- lib/Workflow/Persister/UUID.pm | 4 ++-- lib/Workflow/State.pm | 6 +++--- lib/Workflow/Validator.pm | 4 ++-- lib/Workflow/Validator/HasRequiredField.pm | 4 ++-- lib/Workflow/Validator/InEnumeratedType.pm | 4 ++-- lib/Workflow/Validator/MatchesDateFormat.pm | 4 ++-- 36 files changed, 73 insertions(+), 73 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index 80b9d062..16fdb258 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -16,7 +16,7 @@ my @FIELDS = qw( id type description state last_update time_zone ); my @INTERNAL = qw( _factory _observers ); __PACKAGE__->mk_accessors( @FIELDS, @INTERNAL ); -$Workflow::VERSION = '1.61'; +$Workflow::VERSION = '1.62'; use constant NO_CHANGE_VALUE => 'NOCHANGE'; @@ -376,7 +376,7 @@ Workflow - Simple, flexible system to implement workflows =head1 VERSION -This documentation describes version 1.61 of Workflow +This documentation describes version 1.62 of Workflow =head1 SYNOPSIS diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index afc37caf..9fd34f44 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -12,7 +12,7 @@ use Workflow::Validator::HasRequiredField; use Workflow::Factory qw( FACTORY ); use Carp qw(croak); -$Workflow::Action::VERSION = '1.61'; +$Workflow::Action::VERSION = '1.62'; my @PROPS = qw( name class description group ); my @INTERNAL = qw( _factory ); @@ -167,7 +167,7 @@ Workflow::Action - Base class for Workflow actions =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index 72b4f777..999843a8 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); use English qw( -no_match_vars ); -$Workflow::Action::InputField::VERSION = '1.61'; +$Workflow::Action::InputField::VERSION = '1.62'; my @PROPS = qw( name label description type requirement source_class source_list class ); @@ -122,7 +122,7 @@ Workflow::Action::InputField - Metadata about information required by an Action =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Mailer.pm b/lib/Workflow/Action/Mailer.pm index 37d68c7f..f4ad386d 100644 --- a/lib/Workflow/Action/Mailer.pm +++ b/lib/Workflow/Action/Mailer.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Mailer::VERSION = '1.61'; +$Workflow::Action::Mailer::VERSION = '1.62'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Mailer - a stub for a SMTP capable action =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index dc235dfb..b4ef9cf4 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Action ); -$Workflow::Action::Null::VERSION = '1.61'; +$Workflow::Action::Null::VERSION = '1.62'; sub execute { my ($self) = @_; @@ -23,7 +23,7 @@ Workflow::Action::Null - Workflow action for the terminally lazy =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index 46c4fad1..4479ed54 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Class::Accessor ); use Log::Log4perl; -$Workflow::Base::VERSION = '1.61'; +$Workflow::Base::VERSION = '1.62'; sub new { my ( $class, @params ) = @_; @@ -96,7 +96,7 @@ Workflow::Base - Base class with constructor =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index d3221f71..f89ce649 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -9,7 +9,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( workflow_error condition_error ); $Workflow::Condition::CACHE_RESULTS = 1; -$Workflow::Condition::VERSION = '1.61'; +$Workflow::Condition::VERSION = '1.62'; my $log; my @FIELDS = qw( name class ); @@ -120,7 +120,7 @@ Workflow::Condition - Evaluate a condition depending on the workflow state and e =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index cea7ab9c..100ad900 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -3,7 +3,7 @@ package Workflow::Condition::CheckReturn; use strict; use warnings; -our $VERSION = '1.61'; +our $VERSION = '1.62'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -92,7 +92,7 @@ Workflow::Condition::CheckReturn =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 824b5bea..581096c1 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -8,7 +8,7 @@ use Safe; use Workflow::Exception qw( condition_error configuration_error ); use English qw( -no_match_vars ); -$Workflow::Condition::Evaluate::VERSION = '1.61'; +$Workflow::Condition::Evaluate::VERSION = '1.62'; my @FIELDS = qw( test ); __PACKAGE__->mk_accessors(@FIELDS); @@ -69,7 +69,7 @@ Workflow::Condition::Evaluate - Inline condition that evaluates perl code for tr =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/GreedyOR.pm b/lib/Workflow/Condition/GreedyOR.pm index 19ea05d4..bc47ca27 100644 --- a/lib/Workflow/Condition/GreedyOR.pm +++ b/lib/Workflow/Condition/GreedyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::GreedyOR; use strict; use warnings; -our $VERSION = '1.61'; +our $VERSION = '1.62'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::GreedyOR =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/HasUser.pm b/lib/Workflow/Condition/HasUser.pm index 9722b3c6..aa93d133 100644 --- a/lib/Workflow/Condition/HasUser.pm +++ b/lib/Workflow/Condition/HasUser.pm @@ -6,7 +6,7 @@ use base qw( Workflow::Condition ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( condition_error ); -$Workflow::Condition::HasUser::VERSION = '1.61'; +$Workflow::Condition::HasUser::VERSION = '1.62'; my $DEFAULT_USER_KEY = 'current_user'; @@ -41,7 +41,7 @@ Workflow::Condition::HasUser - Condition to determine if a user is available =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Condition/LazyAND.pm b/lib/Workflow/Condition/LazyAND.pm index 79d13f9a..800110d3 100644 --- a/lib/Workflow/Condition/LazyAND.pm +++ b/lib/Workflow/Condition/LazyAND.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyAND; use strict; use warnings; -our $VERSION = '1.61'; +our $VERSION = '1.62'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -57,7 +57,7 @@ Workflow::Condition::LazyAND =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/LazyOR.pm b/lib/Workflow/Condition/LazyOR.pm index aed43ea1..621ca2a5 100644 --- a/lib/Workflow/Condition/LazyOR.pm +++ b/lib/Workflow/Condition/LazyOR.pm @@ -3,7 +3,7 @@ package Workflow::Condition::LazyOR; use strict; use warnings; -our $VERSION = '1.61'; +our $VERSION = '1.62'; use base qw( Workflow::Condition::Nested ); use Workflow::Exception qw( condition_error configuration_error ); @@ -55,7 +55,7 @@ Workflow::Condition::LazyOR =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Negated.pm b/lib/Workflow/Condition/Negated.pm index 75b5130c..794d6493 100644 --- a/lib/Workflow/Condition/Negated.pm +++ b/lib/Workflow/Condition/Negated.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Negated; use strict; use warnings; -our $VERSION = '1.61'; +our $VERSION = '1.62'; use base qw( Workflow::Condition ); @@ -36,7 +36,7 @@ Workflow::Condition::Negated - Negate workflow condition result =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Condition/Nested.pm b/lib/Workflow/Condition/Nested.pm index db5d7950..83b761c4 100644 --- a/lib/Workflow/Condition/Nested.pm +++ b/lib/Workflow/Condition/Nested.pm @@ -3,7 +3,7 @@ package Workflow::Condition::Nested; use strict; use warnings; -our $VERSION = '1.61'; +our $VERSION = '1.62'; use base qw( Workflow::Condition ); @@ -19,7 +19,7 @@ Workflow::Condition::Nested - Evaluate nested workflow conditions =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 DESCRIPTION diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index 6ce64760..8cf3c0fc 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -7,7 +7,7 @@ use Data::Dumper qw( Dumper ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Config::VERSION = '1.61'; +$Workflow::Config::VERSION = '1.62'; # Map the valid type to the top-level XML tag or data # structure to look for. @@ -114,7 +114,7 @@ Workflow::Config - Parse configuration files for the workflow components =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index 9a4be971..2f208720 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Data::Dumper qw( Dumper ); use English qw( -no_match_vars ); -$Workflow::Config::Perl::VERSION = '1.61'; +$Workflow::Config::Perl::VERSION = '1.62'; sub parse { my ( $self, $type, @items ) = @_; @@ -105,7 +105,7 @@ Workflow::Config::Perl - Parse workflow configurations as Perl data structures =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index 59209281..7f22b7be 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Config::XML::VERSION = '1.61'; +$Workflow::Config::XML::VERSION = '1.62'; my ($log); @@ -110,7 +110,7 @@ Workflow::Config::XML - Parse workflow configurations from XML content =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Context.pm b/lib/Workflow/Context.pm index f492e13a..6a0ccc84 100644 --- a/lib/Workflow/Context.pm +++ b/lib/Workflow/Context.pm @@ -4,7 +4,7 @@ use warnings; use strict; use base qw( Workflow::Base ); -$Workflow::Context::VERSION = '1.61'; +$Workflow::Context::VERSION = '1.62'; sub init { @@ -35,7 +35,7 @@ Workflow::Context - Data blackboard for Workflows, Actions, Conditions and Valid =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Exception.pm b/lib/Workflow/Exception.pm index a3b541dc..f14455ea 100644 --- a/lib/Workflow/Exception.pm +++ b/lib/Workflow/Exception.pm @@ -44,7 +44,7 @@ my %TYPE_LOGGING = ( ); -$Workflow::Exception::VERSION = '1.61'; +$Workflow::Exception::VERSION = '1.62'; @Workflow::Exception::ISA = qw( Exporter Exception::Class::Base ); @Workflow::Exception::EXPORT_OK = keys %TYPE_CLASSES; @@ -129,7 +129,7 @@ Workflow::Exception - Base class for workflow exceptions =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index 21f37bc6..6ac7ae1e 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error workflow_error ); use Carp qw(croak); use English qw( -no_match_vars ); -$Workflow::Factory::VERSION = '1.61'; +$Workflow::Factory::VERSION = '1.62'; # Extra action attribute validation is off by default for compatibility. our $VALIDATE_ACTION_CONFIG = 0; @@ -831,7 +831,7 @@ Workflow::Factory - Generates new workflow and supporting objects =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/History.pm b/lib/Workflow/History.pm index 9a378af1..8d2049ff 100644 --- a/lib/Workflow/History.pm +++ b/lib/Workflow/History.pm @@ -5,7 +5,7 @@ use strict; use base qw( Class::Accessor ); use DateTime; -$Workflow::History::VERSION = '1.61'; +$Workflow::History::VERSION = '1.62'; my @FIELDS = qw( id workflow_id action description date user state time_zone ); @@ -66,7 +66,7 @@ Workflow::History - Recorded work on a workflow action or workflow itself =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index 67e9af34..2f0d3743 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -9,7 +9,7 @@ use Workflow::Exception qw( persist_error ); use constant DEFAULT_ID_LENGTH => 8; -$Workflow::Persister::VERSION = '1.61'; +$Workflow::Persister::VERSION = '1.62'; my @FIELDS = qw( name class use_random use_uuid @@ -163,7 +163,7 @@ Workflow::Persister - Base class for workflow persistence =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 56db7428..5bed7175 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -19,7 +19,7 @@ use Readonly; Readonly::Scalar my $TRUE => 1; Readonly::Scalar my $FALSE => 0; -$Workflow::Persister::DBI::VERSION = '1.61'; +$Workflow::Persister::DBI::VERSION = '1.62'; my @FIELDS = qw( _wf_fields _hist_fields handle dsn user password driver workflow_table history_table date_format parser autocommit); @@ -477,7 +477,7 @@ Workflow::Persister::DBI - Persist workflow and history to DBI database =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm index 70f5d768..c2105021 100644 --- a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm +++ b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm @@ -6,7 +6,7 @@ use base qw( Class::Accessor ); use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error ); -$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.61'; +$Workflow::Persister::DBI::AutoGeneratedId::VERSION = '1.62'; my @FIELDS = qw( log from_handle handle_property func_property ); __PACKAGE__->mk_accessors(@FIELDS); @@ -65,7 +65,7 @@ Workflow::Persister::DBI::AutoGeneratedId - Pull IDs from databases that autogen =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index 3bd35ab9..cf3fbe5e 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -7,7 +7,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::ExtraData::VERSION = '1.61'; +$Workflow::Persister::DBI::ExtraData::VERSION = '1.62'; my @FIELDS = qw( table data_field context_key ); __PACKAGE__->mk_accessors(@FIELDS); @@ -107,7 +107,7 @@ Workflow::Persister::DBI::ExtraData - Fetch extra data with each workflow and pu =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index 9526297c..b5e4f543 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::DBI::SequenceId::VERSION = '1.61'; +$Workflow::Persister::DBI::SequenceId::VERSION = '1.62'; my @FIELDS = qw( log sequence_name sequence_select ); __PACKAGE__->mk_accessors(@FIELDS); @@ -55,7 +55,7 @@ Workflow::Persister::DBI::SequenceId - Persister to fetch ID from a sequence =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 18103ffb..17252f5c 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -11,7 +11,7 @@ use Workflow::Persister::RandomId; use File::Slurp qw(slurp); use English qw( -no_match_vars ); -$Workflow::Persister::File::VERSION = '1.61'; +$Workflow::Persister::File::VERSION = '1.62'; my @FIELDS = qw( path ); __PACKAGE__->mk_accessors(@FIELDS); @@ -182,7 +182,7 @@ Workflow::Persister::File - Persist workflow and history to the filesystem =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/RandomId.pm b/lib/Workflow/Persister/RandomId.pm index bc3bc169..b292cc55 100644 --- a/lib/Workflow/Persister/RandomId.pm +++ b/lib/Workflow/Persister/RandomId.pm @@ -8,7 +8,7 @@ use constant DEFAULT_ID_LENGTH => 8; use constant RANDOM_SEED => 26; use constant CONSTANT_INCREMENT => 65; -$Workflow::Persister::RandomId::VERSION = '1.61'; +$Workflow::Persister::RandomId::VERSION = '1.62'; my @FIELDS = qw( id_length ); __PACKAGE__->mk_accessors(@FIELDS); @@ -42,7 +42,7 @@ Workflow::Persister::RandomId - Persister to generate random ID =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/SPOPS.pm b/lib/Workflow/Persister/SPOPS.pm index 579377d4..649d43e8 100644 --- a/lib/Workflow/Persister/SPOPS.pm +++ b/lib/Workflow/Persister/SPOPS.pm @@ -8,7 +8,7 @@ use Log::Log4perl qw( get_logger ); use Workflow::Exception qw( configuration_error persist_error ); use English qw( -no_match_vars ); -$Workflow::Persister::SPOPS::VERSION = '1.61'; +$Workflow::Persister::SPOPS::VERSION = '1.62'; my @FIELDS = qw( workflow_class history_class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -143,7 +143,7 @@ Workflow::Persister::SPOPS - Persist workflows using SPOPS =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Persister/UUID.pm b/lib/Workflow/Persister/UUID.pm index 245d6ab6..34b104bc 100644 --- a/lib/Workflow/Persister/UUID.pm +++ b/lib/Workflow/Persister/UUID.pm @@ -4,7 +4,7 @@ use warnings; use strict; use Data::UUID; -$Workflow::Persister::UUID::VERSION = '1.61'; +$Workflow::Persister::UUID::VERSION = '1.62'; sub new { my ( $class, $params ) = @_; @@ -31,7 +31,7 @@ Workflow::Persister::UUID - Persister to generate Universally Unique Identifiers =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index a3ca06c3..ab3ca085 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -11,7 +11,7 @@ use Exception::Class; use Workflow::Factory qw( FACTORY ); use English qw( -no_match_vars ); -$Workflow::State::VERSION = '1.61'; +$Workflow::State::VERSION = '1.62'; my @FIELDS = qw( state description type ); my @INTERNAL = qw( _test_condition_count _factory _actions _conditions @@ -355,7 +355,7 @@ Workflow::State - Information about an individual state in a workflow =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS @@ -505,7 +505,7 @@ Returns name of action to be used for autorunning the state. =head3 clear_condition_cache ( ) -Deprecated, kept for 1.61 compatibility. +Deprecated, kept for 1.62 compatibility. Used to empties the condition result cache for a given state. diff --git a/lib/Workflow/Validator.pm b/lib/Workflow/Validator.pm index 89dbf4af..6eb540cf 100644 --- a/lib/Workflow/Validator.pm +++ b/lib/Workflow/Validator.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Base ); use Carp qw(croak); -$Workflow::Validator::VERSION = '1.61'; +$Workflow::Validator::VERSION = '1.62'; my @FIELDS = qw( name class ); __PACKAGE__->mk_accessors(@FIELDS); @@ -43,7 +43,7 @@ Workflow::Validator - Ensure data are valid =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/HasRequiredField.pm b/lib/Workflow/Validator/HasRequiredField.pm index 0f97ab80..ae12aff1 100644 --- a/lib/Workflow/Validator/HasRequiredField.pm +++ b/lib/Workflow/Validator/HasRequiredField.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( validation_error ); -$Workflow::Validator::HasRequiredField::VERSION = '1.61'; +$Workflow::Validator::HasRequiredField::VERSION = '1.62'; sub validate { my ( $self, $wf, @required_fields ) = @_; @@ -34,7 +34,7 @@ Workflow::Validator::HasRequiredField - Validator to ensure certain data are in =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/InEnumeratedType.pm b/lib/Workflow/Validator/InEnumeratedType.pm index bbbba358..17d675f1 100644 --- a/lib/Workflow/Validator/InEnumeratedType.pm +++ b/lib/Workflow/Validator/InEnumeratedType.pm @@ -5,7 +5,7 @@ use strict; use base qw( Workflow::Validator ); use Workflow::Exception qw( configuration_error validation_error ); -$Workflow::Validator::InEnumeratedType::VERSION = '1.61'; +$Workflow::Validator::InEnumeratedType::VERSION = '1.62'; sub _init { my ( $self, $params ) = @_; @@ -59,7 +59,7 @@ Workflow::Validator::InEnumeratedType - Ensure a value is one of a declared set =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index 89749aec..75e90289 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -8,7 +8,7 @@ use Workflow::Exception qw( configuration_error validation_error ); use English qw( -no_match_vars ); use Carp qw(carp); -$Workflow::Validator::MatchesDateFormat::VERSION = '1.61'; +$Workflow::Validator::MatchesDateFormat::VERSION = '1.62'; __PACKAGE__->mk_accessors('formatter'); @@ -65,7 +65,7 @@ Workflow::Validator::MatchesDateFormat - Ensure a stringified date matches a giv =head1 VERSION -This documentation describes version 1.61 of this package +This documentation describes version 1.62 of this package =head1 SYNOPSIS From a05e456c7f6cef186882a864eb4b42b28e4642d7 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Feb 2023 20:45:03 +0100 Subject: [PATCH 32/35] Bumped copyright yeah, even though it is not necessary --- lib/Workflow.pm | 2 +- lib/Workflow/Action.pm | 2 +- lib/Workflow/Action/InputField.pm | 2 +- lib/Workflow/Action/Mailer.pm | 2 +- lib/Workflow/Action/Null.pm | 2 +- lib/Workflow/Base.pm | 2 +- lib/Workflow/Condition.pm | 2 +- lib/Workflow/Condition/CheckReturn.pm | 2 +- lib/Workflow/Condition/Evaluate.pm | 2 +- lib/Workflow/Condition/GreedyOR.pm | 2 +- lib/Workflow/Condition/HasUser.pm | 2 +- lib/Workflow/Condition/LazyAND.pm | 2 +- lib/Workflow/Condition/LazyOR.pm | 2 +- lib/Workflow/Condition/Negated.pm | 2 +- lib/Workflow/Condition/Nested.pm | 2 +- lib/Workflow/Config.pm | 2 +- lib/Workflow/Config/Perl.pm | 2 +- lib/Workflow/Config/XML.pm | 2 +- lib/Workflow/Context.pm | 2 +- lib/Workflow/Exception.pm | 2 +- lib/Workflow/Factory.pm | 2 +- lib/Workflow/History.pm | 2 +- lib/Workflow/Persister.pm | 2 +- lib/Workflow/Persister/DBI.pm | 2 +- lib/Workflow/Persister/DBI/AutoGeneratedId.pm | 2 +- lib/Workflow/Persister/DBI/ExtraData.pm | 2 +- lib/Workflow/Persister/DBI/SequenceId.pm | 2 +- lib/Workflow/Persister/File.pm | 2 +- lib/Workflow/Persister/RandomId.pm | 2 +- lib/Workflow/Persister/SPOPS.pm | 2 +- lib/Workflow/Persister/UUID.pm | 2 +- lib/Workflow/State.pm | 2 +- lib/Workflow/Validator.pm | 2 +- lib/Workflow/Validator/HasRequiredField.pm | 2 +- lib/Workflow/Validator/InEnumeratedType.pm | 2 +- lib/Workflow/Validator/MatchesDateFormat.pm | 2 +- 36 files changed, 36 insertions(+), 36 deletions(-) diff --git a/lib/Workflow.pm b/lib/Workflow.pm index 16fdb258..67f502c9 100644 --- a/lib/Workflow.pm +++ b/lib/Workflow.pm @@ -1404,7 +1404,7 @@ L =head1 COPYRIGHT Copyright (c) 2003 Chris Winters and Arvato Direct; -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action.pm b/lib/Workflow/Action.pm index 9fd34f44..02fb599f 100644 --- a/lib/Workflow/Action.pm +++ b/lib/Workflow/Action.pm @@ -486,7 +486,7 @@ fields. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action/InputField.pm b/lib/Workflow/Action/InputField.pm index 999843a8..f0e08296 100644 --- a/lib/Workflow/Action/InputField.pm +++ b/lib/Workflow/Action/InputField.pm @@ -312,7 +312,7 @@ example. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action/Mailer.pm b/lib/Workflow/Action/Mailer.pm index f4ad386d..9fab8f1b 100644 --- a/lib/Workflow/Action/Mailer.pm +++ b/lib/Workflow/Action/Mailer.pm @@ -49,7 +49,7 @@ I =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Action/Null.pm b/lib/Workflow/Action/Null.pm index b4ef9cf4..106f21b0 100644 --- a/lib/Workflow/Action/Null.pm +++ b/lib/Workflow/Action/Null.pm @@ -60,7 +60,7 @@ it by returning C. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Base.pm b/lib/Workflow/Base.pm index 4479ed54..64096fdc 100644 --- a/lib/Workflow/Base.pm +++ b/lib/Workflow/Base.pm @@ -196,7 +196,7 @@ it in a list. If given neither return an empty list. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition.pm b/lib/Workflow/Condition.pm index f89ce649..77eb958e 100644 --- a/lib/Workflow/Condition.pm +++ b/lib/Workflow/Condition.pm @@ -321,7 +321,7 @@ consider it to be the value returned. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/CheckReturn.pm b/lib/Workflow/Condition/CheckReturn.pm index 100ad900..4ce0bb5b 100644 --- a/lib/Workflow/Condition/CheckReturn.pm +++ b/lib/Workflow/Condition/CheckReturn.pm @@ -166,7 +166,7 @@ above strings map to the following numeric operators internally: =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/Evaluate.pm b/lib/Workflow/Condition/Evaluate.pm index 581096c1..77e83f6a 100644 --- a/lib/Workflow/Condition/Evaluate.pm +++ b/lib/Workflow/Condition/Evaluate.pm @@ -138,7 +138,7 @@ A hashref of all the parameters in the L object =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/GreedyOR.pm b/lib/Workflow/Condition/GreedyOR.pm index bc47ca27..ca38d364 100644 --- a/lib/Workflow/Condition/GreedyOR.pm +++ b/lib/Workflow/Condition/GreedyOR.pm @@ -119,7 +119,7 @@ B =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/HasUser.pm b/lib/Workflow/Condition/HasUser.pm index aa93d133..c9fceb3f 100644 --- a/lib/Workflow/Condition/HasUser.pm +++ b/lib/Workflow/Condition/HasUser.pm @@ -108,7 +108,7 @@ Throws L if evaluation fails =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/LazyAND.pm b/lib/Workflow/Condition/LazyAND.pm index 800110d3..6ca0138a 100644 --- a/lib/Workflow/Condition/LazyAND.pm +++ b/lib/Workflow/Condition/LazyAND.pm @@ -113,7 +113,7 @@ B =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/LazyOR.pm b/lib/Workflow/Condition/LazyOR.pm index 621ca2a5..a744169e 100644 --- a/lib/Workflow/Condition/LazyOR.pm +++ b/lib/Workflow/Condition/LazyOR.pm @@ -111,7 +111,7 @@ B =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/Negated.pm b/lib/Workflow/Condition/Negated.pm index 794d6493..0b0d0952 100644 --- a/lib/Workflow/Condition/Negated.pm +++ b/lib/Workflow/Condition/Negated.pm @@ -73,7 +73,7 @@ See L =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Condition/Nested.pm b/lib/Workflow/Condition/Nested.pm index 83b761c4..8280b5ab 100644 --- a/lib/Workflow/Condition/Nested.pm +++ b/lib/Workflow/Condition/Nested.pm @@ -86,7 +86,7 @@ See L =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Config.pm b/lib/Workflow/Config.pm index 8cf3c0fc..495e2485 100644 --- a/lib/Workflow/Config.pm +++ b/lib/Workflow/Config.pm @@ -494,7 +494,7 @@ For documentation of the other keys, please refer to the respective classes. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Config/Perl.pm b/lib/Workflow/Config/Perl.pm index 2f208720..ce17ad5d 100644 --- a/lib/Workflow/Config/Perl.pm +++ b/lib/Workflow/Config/Perl.pm @@ -151,7 +151,7 @@ The method returns a list of configuration parameters. =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Config/XML.pm b/lib/Workflow/Config/XML.pm index 7f22b7be..6f9b016e 100644 --- a/lib/Workflow/Config/XML.pm +++ b/lib/Workflow/Config/XML.pm @@ -146,7 +146,7 @@ Returns a list of config parameters as a array upon success. =head1 COPYRIGHT -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Context.pm b/lib/Workflow/Context.pm index 6a0ccc84..8ba8bafa 100644 --- a/lib/Workflow/Context.pm +++ b/lib/Workflow/Context.pm @@ -95,7 +95,7 @@ C<$other_context> wins. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Exception.pm b/lib/Workflow/Exception.pm index f14455ea..b7324cd3 100644 --- a/lib/Workflow/Exception.pm +++ b/lib/Workflow/Exception.pm @@ -246,7 +246,7 @@ This exception is thrown via when input data or similar of a workflow =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Factory.pm b/lib/Workflow/Factory.pm index 6ac7ae1e..da5aab7c 100644 --- a/lib/Workflow/Factory.pm +++ b/lib/Workflow/Factory.pm @@ -1238,7 +1238,7 @@ of L configs. See L for details. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/History.pm b/lib/Workflow/History.pm index 8d2049ff..c2e1ab9b 100644 --- a/lib/Workflow/History.pm +++ b/lib/Workflow/History.pm @@ -185,7 +185,7 @@ Sets saved state to true and returns 1 =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister.pm b/lib/Workflow/Persister.pm index 2f0d3743..e302245e 100644 --- a/lib/Workflow/Persister.pm +++ b/lib/Workflow/Persister.pm @@ -336,7 +336,7 @@ we shift parameters in? =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI.pm b/lib/Workflow/Persister/DBI.pm index 5bed7175..83ee5adb 100644 --- a/lib/Workflow/Persister/DBI.pm +++ b/lib/Workflow/Persister/DBI.pm @@ -817,7 +817,7 @@ Returns nothing =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm index c2105021..e065d0ac 100644 --- a/lib/Workflow/Persister/DBI/AutoGeneratedId.pm +++ b/lib/Workflow/Persister/DBI/AutoGeneratedId.pm @@ -130,7 +130,7 @@ database handle, based on the statement handle. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI/ExtraData.pm b/lib/Workflow/Persister/DBI/ExtraData.pm index cf3fbe5e..06102135 100644 --- a/lib/Workflow/Persister/DBI/ExtraData.pm +++ b/lib/Workflow/Persister/DBI/ExtraData.pm @@ -221,7 +221,7 @@ Throws L if retrieval is not successful. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/DBI/SequenceId.pm b/lib/Workflow/Persister/DBI/SequenceId.pm index b5e4f543..5f113539 100644 --- a/lib/Workflow/Persister/DBI/SequenceId.pm +++ b/lib/Workflow/Persister/DBI/SequenceId.pm @@ -114,7 +114,7 @@ This is a I method, use L =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/File.pm b/lib/Workflow/Persister/File.pm index 17252f5c..693fa177 100644 --- a/lib/Workflow/Persister/File.pm +++ b/lib/Workflow/Persister/File.pm @@ -294,7 +294,7 @@ to deserialization attempt. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/RandomId.pm b/lib/Workflow/Persister/RandomId.pm index b292cc55..81e3b5d5 100644 --- a/lib/Workflow/Persister/RandomId.pm +++ b/lib/Workflow/Persister/RandomId.pm @@ -84,7 +84,7 @@ This method is unimplemented at this time, please see the TODO. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/SPOPS.pm b/lib/Workflow/Persister/SPOPS.pm index 649d43e8..d3c11460 100644 --- a/lib/Workflow/Persister/SPOPS.pm +++ b/lib/Workflow/Persister/SPOPS.pm @@ -249,7 +249,7 @@ Returns an array of workflow history objects upon success =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Persister/UUID.pm b/lib/Workflow/Persister/UUID.pm index 34b104bc..a824aa80 100644 --- a/lib/Workflow/Persister/UUID.pm +++ b/lib/Workflow/Persister/UUID.pm @@ -84,7 +84,7 @@ This method is unimplemented at this time, please see the TODO. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/State.pm b/lib/Workflow/State.pm index ab3ca085..ce62a314 100644 --- a/lib/Workflow/State.pm +++ b/lib/Workflow/State.pm @@ -557,7 +557,7 @@ performing some sanity checks like ensuring every action has a =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator.pm b/lib/Workflow/Validator.pm index 6eb540cf..55f042ca 100644 --- a/lib/Workflow/Validator.pm +++ b/lib/Workflow/Validator.pm @@ -147,7 +147,7 @@ get the application context information from the C<$workflow> object. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator/HasRequiredField.pm b/lib/Workflow/Validator/HasRequiredField.pm index ae12aff1..1e24e979 100644 --- a/lib/Workflow/Validator/HasRequiredField.pm +++ b/lib/Workflow/Validator/HasRequiredField.pm @@ -103,7 +103,7 @@ L's are thrown in case of missing fields. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator/InEnumeratedType.pm b/lib/Workflow/Validator/InEnumeratedType.pm index 17d675f1..e80faf19 100644 --- a/lib/Workflow/Validator/InEnumeratedType.pm +++ b/lib/Workflow/Validator/InEnumeratedType.pm @@ -215,7 +215,7 @@ part of the set. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. diff --git a/lib/Workflow/Validator/MatchesDateFormat.pm b/lib/Workflow/Validator/MatchesDateFormat.pm index 75e90289..7d6da032 100644 --- a/lib/Workflow/Validator/MatchesDateFormat.pm +++ b/lib/Workflow/Validator/MatchesDateFormat.pm @@ -141,7 +141,7 @@ parameter, which should adhere to a predefined date format. =head1 COPYRIGHT -Copyright (c) 2003-2022 Chris Winters. All rights reserved. +Copyright (c) 2003-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. From cf9befe7e0f8e1b667952648090887bb303add95 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Feb 2023 20:45:17 +0100 Subject: [PATCH 33/35] Updated from POD --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index cec2eccb..1cfecd1a 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ Workflow - Simple, flexible system to implement workflows # VERSION -This documentation describes version 1.61 of Workflow +This documentation describes version 1.62 of Workflow # SYNOPSIS @@ -505,14 +505,14 @@ If you want to divide actions in groups (for example state change group, approval group, which have to be shown at different places on the page) add group property to your action -<action name="terminate request" group="state change" class="MyApp::Action::Terminate" /> -<action name="approve request" group="approval" class="MyApp::Action::Approve" /> + + -my @actions = $wf->get\_current\_actions("approval"); + my @actions = $wf->get_current_actions("approval"); -$group should be string that reperesents desired group name. In @actions you will get +`$group` should be string that reperesents desired group name. In @actions you will get list of action names available from the current state for the given environment limited by group. -$group is optional parameter. +`$group` is optional parameter. Returns: list of strings representing available actions @@ -894,7 +894,7 @@ The code is kept under revision control using Git: # COPYRIGHT Copyright (c) 2003 Chris Winters and Arvato Direct; -Copyright (c) 2004-2022 Chris Winters. All rights reserved. +Copyright (c) 2004-2023 Chris Winters. All rights reserved. This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. From 7c9936d5c2412b7cd618e4205d64354e012dabbd Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Feb 2023 21:19:24 +0100 Subject: [PATCH 34/35] Updated checkout action to v3 from v2, Node version in v2 is deprecated --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8bb0e25..1e94c43c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: steps: - name: Check out repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Extract author information run: | echo AUTHOR_NAME="$(git log -1 ${GITHUB_REF} --pretty='%aN')" >> $GITHUB_ENV From dfdb8d1bdb660dfbfb8e947422937004e9d704a7 Mon Sep 17 00:00:00 2001 From: jonasbn Date: Sat, 11 Feb 2023 21:26:48 +0100 Subject: [PATCH 35/35] Updated test matric and exchanged 5.26 for 5.34 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e94c43c..5107bd74 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -66,7 +66,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - perl: [ "5.14", "5.20", "5.26", "5.30" ] + perl: [ "5.14", "5.20", "5.30", "5.34" ] name: linux ${{ matrix.perl }}