refactor(slack-bot): decouple scrapers

oxenprogrammer · oxenprogrammer · commit fd6b9b1f2e32 · 2021-02-02T20:45:36.000+03:00
diff --git a/lib/crawler/image_scraper.rb b/lib/crawler/image_scraper.rb
@@ -0,0 +1,12 @@
+# Text Scraper
+class ImageScraper
+  def initialize
+    @base_url = 'https://www.hongkiat.com/blog/programming-jokes/'
+    unparsed_page = HTTParty.get(@base_url)
+    @parsed_page = Nokogiri::HTML(unparsed_page.body)
+  end
+
+  def scraper
+    @parsed_page
+  end
+end
diff --git a/lib/crawler/joke_image.rb b/lib/crawler/joke_image.rb
@@ -1,17 +1,13 @@
 require 'httparty'
 require 'nokogiri'
 
+require_relative './image_scraper'
+
 # Image based jokes implementation
 class ImageClone
-  def initialize
-    @base_url = 'https://www.hongkiat.com/blog/programming-jokes/'
-    unparsed_page = HTTParty.get(@base_url)
-    @parsed_page = Nokogiri::HTML(unparsed_page.body)
-  end
-
-  def image_jokes
+  def image_jokes(scrap)
     my_array = []
-    img_tags = @parsed_page.css('figure.entry-image img[src]').select { |image| image['src'].start_with?('https') }
+    img_tags = scrap.css('figure.entry-image img[src]').select { |image| image['src'].start_with?('https') }
     if img_tags.is_a? Array
       img_tags.map { |t| t[:src] }
     else
@@ -20,8 +16,9 @@ def image_jokes
   end
 
   def image_random_joke
-    if image_jokes.any?
-      image_jokes.sample
+    image = ImageScraper.new
+    if image_jokes(image.scraper).any?
+      image_jokes(image.scraper).sample
     else
       'Whoops, something is not quite right!, try again'
     end
@@ -30,3 +27,5 @@ def image_random_joke
   private :image_jokes
 end
 
+image_clone = ImageClone.new
+puts image_clone.image_random_joke
diff --git a/lib/crawler/joke_text.rb b/lib/crawler/joke_text.rb
@@ -1,17 +1,13 @@
 require 'httparty'
 require 'nokogiri'
 
+require_relative './text_scraper'
+
 # Text based jokes implementation
 class TextClone
-  def initialize
-    @text_url = 'https://upjoke.com/programmer-jokes'
-    unparsed_page_text = HTTParty.get(@text_url)
-    @parsed_page_text = Nokogiri::HTML(unparsed_page_text.body)
-  end
-
-  def text_jokes
+  def text_jokes(scrap)
     my_array = []
-    my_text_jokes = @parsed_page_text.css('.joke-wrapper').map(&:text)
+    my_text_jokes = scrap.css('.joke-wrapper').map(&:text)
     if my_text_jokes.is_a? Array
       my_text_jokes
     else
@@ -20,8 +16,9 @@ def text_jokes
   end
 
   def text_random_joke
-    if text_jokes.any?
-      text_jokes.sample
+    my_jokes = TextScraper.new
+    if text_jokes(my_jokes.scraper).any?
+      text_jokes(my_jokes.scraper).sample
     else
       'Whoops, something is not quite right!, try again'
     end
diff --git a/lib/crawler/text_scraper.rb b/lib/crawler/text_scraper.rb
@@ -0,0 +1,12 @@
+# Text Scraper
+class TextScraper
+  def initialize
+    @text_url = 'https://upjoke.com/programmer-jokes'
+    unparsed_page_text = HTTParty.get(@text_url)
+    @parsed_page_text = Nokogiri::HTML(unparsed_page_text.body)
+  end
+
+  def scraper
+    @parsed_page_text
+  end
+end
