feat(slack-bot): add singleton methods

oxenprogrammer · oxenprogrammer · commit 97b1e489e86a · 2021-02-01T19:57:09.000+03:00
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -0,0 +1,2 @@
+Style/FrozenStringLiteralComment:
+  Enable: false
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -80,7 +80,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.9.0)
+    rubocop (1.9.1)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
diff --git a/Procfile b/Procfile
@@ -1,2 +1,2 @@
-dev: puma
-web: puma
+dev: bundle exec rackup
+web: bundle exec rackup -p 9292
diff --git a/bin/bot.rb b/bin/bot.rb
@@ -3,32 +3,3 @@
 require 'slack-ruby-bot'
 require_relative './../lib/command/slack_command'
 require_relative './../lib/slack-bot'
-
-require 'httparty'
-require 'nokogiri'
-class Web
-  def initialize
-    @base_url = 'https://www.hongkiat.com/blog/programming-jokes/'
-    unparsed_page = HTTParty.get(@base_url)
-    @parsed_page = Nokogiri::HTML(unparsed_page.body)
-
-    @text_url = 'https://upjoke.com/programmer-jokes'
-    unparsed_page_text = HTTParty.get(@text_url)
-    @parsed_page_text = Nokogiri::HTML(unparsed_page_text.body)
-  end
-
-  def images
-    imgs = @parsed_page.css('figure.entry-image img[src]').select { |image| image['src'].start_with?('https') }
-    images_urls = imgs.map { |t| t[:src] } 
-    puts images_urls
-  end
-
-  def text_jokes
-    my_jokes  = @parsed_page_text.css('.joke-wrapper').map(&:text)
-    puts my_jokes.sample
-  end
-end
-
-web = Web.new
-web.images
-
diff --git a/lib/command/slack_command.rb b/lib/command/slack_command.rb
@@ -5,11 +5,11 @@ module JokerTheNerd
   module Commands
     class Jokes < SlackRubyBot::Commands::Base
       command 'jokes_image' do |client, data, _match|
-        client.say(channel: data.channel, text: JokesImage.image_jokes)
+        client.say(channel: data.channel, text: JokesImage.image_random_joke)
       end
 
       command 'jokes_text' do |client, data, _match|
-        client.say(channel: data.channel, text: JokesText.text_jokes)
+        client.say(channel: data.channel, text: JokesText.text_random_joke)
       end
 
       command 'say_hello' do |client, data, _match|
@@ -20,7 +20,7 @@ class Jokes < SlackRubyBot::Commands::Base
 
   class HelloText
     def self.say_hello
-      'Hello, Joker the Nerd Here'
+      'Heyyy, ready for some humors?'
     end
   end
 
@@ -29,8 +29,11 @@ def self.text_jokes
       @text_url = 'https://upjoke.com/programmer-jokes'
       unparsed_page_text = HTTParty.get(@text_url)
       @parsed_page_text = Nokogiri::HTML(unparsed_page_text.body)
-      my_jokes = @parsed_page_text.css('.joke-wrapper').map(&:text)
-      my_jokes.sample
+      @parsed_page_text.css('.joke-wrapper').map(&:text)
+    end
+
+    def self.text_random_joke
+      text_jokes.sample
     end
   end
 
@@ -40,8 +43,11 @@ def self.image_jokes
       unparsed_page = HTTParty.get(@base_url)
       @parsed_page = Nokogiri::HTML(unparsed_page.body)
       imgs = @parsed_page.css('figure.entry-image img[src]').select { |image| image['src'].start_with?('https') }
-      images_urls = imgs.map { |t| t[:src] } 
-      images_urls.sample
+      imgs.map { |t| t[:src] }
+    end
+
+    def self.image_random_joke
+      image_jokes.sample
     end
   end
 end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Style/FrozenStringLiteralComment:`
	`2`	`+ Enable: false`