Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oneapi-src/unified-memory-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: oneapi-src/unified-memory-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: umf-fixes-nov-pulldown
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 25, 2024

  1. Fix disabling of pci support in hwloc 

    The flag that hwloc recognize is --disable-pci, not --disable-pciaccess.
    @PatKamin @lukaszstolarczuk
    PatKamin authored and lukaszstolarczuk committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4598a5b View commit details
    Browse the repository at this point in the history

  2. Fix output directory on Windows with non-VS generators 

    On Windows when configuring CMake with the Ninja generator and
`-DUMF_BUILD_SHARED_LIBRARY=ON` the `umf.dll` is output to the
`${CMAKE_BINARY_DIR}/bin/$<CONFIG>` directory, this is
problematic as it breaks tools like `urinfo.exe` and `sycl-ls.exe` in
development builds as they rely on `umf.dll` residing in the same
directory in order to be loaded.

This behavior is desirable when using Visual Studio generators, however.
Therefore, this patch changes the logic to check if `CMAKE_GENERATOR`
matches the `"Visual Studio"` string before appending `$<CONFIG>` to the
output directory.
    @kbenzie @lukaszstolarczuk
    kbenzie authored and lukaszstolarczuk committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    30443a0 View commit details
    Browse the repository at this point in the history

  3. Disable libudev in hwloc builds 

    UMF does not link with libudev.
Fixes the error on linking with a hwloc static library on systems with libudev installed:
ld.lld: error: undefined symbol: udev_device_new_from_subsystem_sysname
    @PatKamin @lukaszstolarczuk
    PatKamin authored and lukaszstolarczuk committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a7b6152 View commit details
    Browse the repository at this point in the history
Loading