Skip to content

DDB: add types and TaggingService #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DDB: add types and TaggingService #13256

wants to merge 2 commits into from

Conversation

@giograno
Copy link
Member

@giograno giograno commented Oct 13, 2025

Motivation

Changes

@giograno giograno self-assigned this Oct 13, 2025
@giograno giograno added docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   16m 18s ⏱️ +41s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit b0b4c00. ± Comparison against base commit 098d7a1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   18m 6s ⏱️ - 1h 46m 44s
1 220 tests  - 3 596  1 151 ✅  - 3 316  69 💤  - 268  0 ❌  - 12 
1 222 runs   - 3 596  1 151 ✅  - 3 316  71 💤  - 268  0 ❌  - 12 

Results for commit b0b4c00. ± Comparison against base commit 098d7a1.

This pull request removes 3596 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Test Results - Alternative Providers

57 tests   53 ✅  1m 12s ⏱️
 1 suites   4 💤
 1 files     0 ❌

Results for commit b0b4c00.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 18s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit b0b4c00. ± Comparison against base commit 098d7a1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   35m 16s ⏱️
1 244 tests 1 176 ✅ 68 💤 0 ❌
1 250 runs  1 176 ✅ 74 💤 0 ❌

Results for commit b0b4c00.

♻️ This comment has been updated with latest results.

@giograno
adding tagging service
b0b4c00 
# Conflicts:
#	localstack-core/localstack/services/dynamodb/provider.py
#	localstack-core/localstack/services/dynamodb/v2/provider.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni viren-nadkarni will be requested when the pull request is marked ready for review viren-nadkarni is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@giograno giograno

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giograno