Skip to content

Feature/scheduler/extend tests coverage #12114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Feature/scheduler/extend tests coverage #12114

wants to merge 7 commits into from

Conversation

@maxhoheiser
Copy link
Member

@maxhoheiser maxhoheiser commented Jan 8, 2025 •
edited
Loading

Motivation

A user reported a regression for get_schedule error code if the schedule was not found. To better understand this and also other discovered regressions and response errors from MOTO (used for implementing event bridge scheduler. And as a preparation for implementing a native localstack event bridge scheduler this PR adds AWS snapshot tests for the CRUD functionality of event bridge scheduler (https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/scheduler.html)

The regressions are fixed in moto is this PR: getmoto/moto#8478

Changes

Add AWS snapshot tests for CRUD for schedules and schedule groups

@maxhoheiser maxhoheiser added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases aws:scheduler Amazon EventBridge Scheduler labels Jan 8, 2025
@maxhoheiser maxhoheiser self-assigned this Jan 8, 2025
@maxhoheiser maxhoheiser mentioned this pull request Jan 8, 2025
Closed
@github-actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0   2 suites  ±0   48s ⏱️ - 1h 43m 2s
101 tests  - 4 833  67 ✅  - 4 090  2 💤  - 775  32 ❌ +32 
103 runs   - 4 833  67 ✅  - 4 090  4 💤  - 775  32 ❌ +32 

For more details on these failures, see this check.

Results for commit c3d3dd1. ± Comparison against base commit 6004587.

This pull request removes 4930 and adds 97 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_delete_schedule
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_delete_schedule_not_found
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-DELETE-False-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-DELETE-False-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-DELETE-True-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-DELETE-True-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-NONE-False-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-NONE-False-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-NONE-True-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_get_schedule[FLEXIBLE-DISABLED-NONE-True-True]
…

♻️ This comment has been updated with latest results.

This was referenced Jan 8, 2025
Closed
Merged
@silv-io silv-io added this to the Playground milestone Jan 27, 2025
@joe4dev joe4dev removed their request for review March 17, 2025 17:03
@maxhoheiser maxhoheiser force-pushed the feature/eventbridge_scheduler/extend-tests-coverage branch from 108ac09 to ad50d37 Compare July 23, 2025 08:53
@maxhoheiser maxhoheiser requested review from bentsku and removed request for zaingz July 23, 2025 08:54
@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 39s ⏱️ +14s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c3d3dd1. ± Comparison against base commit 6004587.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c3d3dd1. ± Comparison against base commit 6004587.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files   5 suites   9m 5s ⏱️
125 tests 91 ✅ 2 💤 32 ❌
131 runs  91 ✅ 8 💤 32 ❌

For more details on these failures, see this check.

Results for commit c3d3dd1.

♻️ This comment has been updated with latest results.

bentsku
bentsku reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like lots of tests are still failing, might be worth putting the PR back in draft 😄 only had a comment unrelated to the failures that can already be addressed

tests/aws/services/scheduler/test_scheduler.py Outdated
Comment on lines 209 to 210
)

Copy link
Contributor

@bentsku bentsku Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure we need to snapshot this call, only snapshotting one create_schedule call in a non parametrized test should be enough. Here, we are recording 32 calls that are identical

@maxhoheiser maxhoheiser marked this pull request as draft July 23, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentsku bentsku bentsku left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@maxhoheiser maxhoheiser

Labels

aws:scheduler Amazon EventBridge Scheduler semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

4 participants

@maxhoheiser @bentsku @silv-io