-
Notifications
You must be signed in to change notification settings - Fork 124
Closed
Description
The Change Log shows one critical fix (#252) plus a significant number of performance regression fixes ready for release in 0.9.2.
I think we should release 0.9.2.
In respect of our open PRs and tickets:
- I commented on Remove MDB_UNSIGNEDKEY, add a builder for Dbi, add MDB_INTEGERKEY comparators #276 and suggested we defer it to 0.10.0 and provided reasons there
- Regarding Iterator performance #270, I think similar comments would apply, but as it is marked as a draft I am deferring reviewing it for now. I also believe we should merge Remove MDB_UNSIGNEDKEY, add a builder for Dbi, add MDB_INTEGERKEY comparators #276 before Iterator performance #270, as Remove MDB_UNSIGNEDKEY, add a builder for Dbi, add MDB_INTEGERKEY comparators #276 touches on a wider surface area and Iterator performance #270 would be easier to follow if Remove MDB_UNSIGNEDKEY, add a builder for Dbi, add MDB_INTEGERKEY comparators #276 was already in place
- My only concern is CursorIterable used with BACKWARD_AT_LEAST and BACKWARD_CLOSED is not returning expected ranges of results when using DUPSORT #267, but I see this will get fixed as part of the broader refactoring in Iterator performance #270. As such I
don't mind making an exception to my usual "zero bug policy" in this release, as CursorIterable used with BACKWARD_AT_LEAST and BACKWARD_CLOSED is not returning expected ranges of results when using DUPSORT #267 is not being ignored - the fix is just being deferred for semantic versioning reasons and there is already code that fixes it
As such, are we happy to release 0.9.2?
Comments, @stroomdev66, @at055612?
Metadata
Metadata
Assignees
Labels
No labels