fix: address remaining PR review comments

kacpersaw · kacpersaw · commit 762b59f2fa25 · 2025-12-15T14:32:11.000Z
- Fix safety check logic: check INTEGRATION_TEST_UNSAFE env var
  before calling t.Fatalf, not after
- Fix .gitignore: add coder-logstream-kube and build/ on separate lines
diff --git a/.gitignore b/.gitignore
@@ -1 +1,3 @@
+coder-logstream-kube
 coder-logstream-kube-*
+build/
diff --git a/integration_test.go b/integration_test.go
@@ -42,7 +42,7 @@ func getKubeClient(t *testing.T) kubernetes.Interface {
 	// Safety check: ensure we're connecting to a KinD cluster.
 	// KinD clusters run on localhost or have "kind" in the host.
 	// This prevents accidentally running destructive tests against production clusters.
-	if config.Host != "" {
+	if config.Host != "" && os.Getenv("INTEGRATION_TEST_UNSAFE") != "1" {
 		isKind := strings.Contains(config.Host, "127.0.0.1") ||
 			strings.Contains(config.Host, "localhost") ||
 			strings.Contains(strings.ToLower(config.Host), "kind")
@@ -53,11 +53,6 @@ func getKubeClient(t *testing.T) kubernetes.Interface {
 		}
 	}
 
-	// Allow bypassing the safety check for CI or special cases
-	if os.Getenv("INTEGRATION_TEST_UNSAFE") == "1" {
-		t.Log("WARNING: INTEGRATION_TEST_UNSAFE=1 is set, bypassing KinD cluster check")
-	}
-
 	client, err := kubernetes.NewForConfig(config)
 	require.NoError(t, err, "failed to create kubernetes client")
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+coder-logstream-kube`
`1`	`2`	`coder-logstream-kube-*`
	`3`	`+build/`