fix: web-fragments#83 - only show console logs in dev mode

CaptinKraken · CaptinKraken · commit 332c98b1d483 · 2024-09-12T10:07:09.000-05:00
diff --git a/.changeset/two-weeks-own.md b/.changeset/two-weeks-own.md
@@ -0,0 +1,5 @@
+---
+"reframed": patch
+---
+
+fix: #83 - only show console logs in dev mode
diff --git a/packages/reframed/src/reframed.ts b/packages/reframed/src/reframed.ts
@@ -145,11 +145,12 @@ async function reframeWithFetch(
 			.pipeThrough(new TextDecoderStream())
 			.pipeTo(new WritableDOMStream(target))
 			.finally(() => {
-				console.log("reframing done (reframeWithFetch)!", {
-					source: reframedSrc,
-					target,
-					title: iframe.contentDocument?.title,
-				});
+				import.meta.env.DEV &&
+					console.log("reframing done (reframeWithFetch)!", {
+						source: reframedSrc,
+						target,
+						title: iframe.contentDocument?.title,
+					});
 				resolve();
 			});
 	});
@@ -188,10 +189,11 @@ async function reframeFromTarget(
 			);
 		});
 
-		console.log("reframing done (reframeFromTarget)!", {
-			source,
-			title: document.defaultView!.document.title,
-		});
+		import.meta.env.DEV &&
+			console.log("reframing done (reframeFromTarget)!", {
+				source,
+				title: document.defaultView!.document.title,
+			});
 		resolve();
 	});
 
diff --git a/packages/web-fragments/tsconfig.base.json b/packages/web-fragments/tsconfig.base.json
@@ -17,6 +17,7 @@
 		"moduleResolution": "Bundler",
 		"resolveJsonModule": true,
 		"isolatedModules": true,
-		"jsx": "react-jsx"
+		"jsx": "react-jsx",
+		"types": ["vite/client"]
 	}
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -5,6 +5,7 @@
 		"module": "ES2022",
 		"lib": ["ESNext", "DOM", "DOM.Iterable"],
 		"skipLibCheck": true,
+		"types": ["vite/client"],
 
 		/* Bundler mode */
 		"moduleResolution": "bundler",

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"reframed": patch
 +---
++
 +fix: #83 - only show console logs in dev mode
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`"moduleResolution": "Bundler",`
`18`	`18`	`"resolveJsonModule": true,`
`19`	`19`	`"isolatedModules": true,`
`20`		`- "jsx": "react-jsx"`
	`20`	`+ "jsx": "react-jsx",`
	`21`	`+ "types": ["vite/client"]`
`21`	`22`	`}`
`22`	`23`	`}`