Use Trace.write for warnings to align with tracing system

Pastoray · Pastoray · commit c9583f934758 · 2025-05-02T18:54:49.000+01:00
diff --git a/packages/core/image-asset/image-asset-common.ts b/packages/core/image-asset/image-asset-common.ts
@@ -1,6 +1,7 @@
 import { ImageAsset as ImageAssetDefinition, ImageAssetOptions } from '.';
 import { Observable } from '../data/observable';
 import { Screen } from '../platform';
+import { Trace } from '../trace/index';
 
 export class ImageAssetBase extends Observable implements ImageAssetDefinition {
 	private _options: ImageAssetOptions;
@@ -54,7 +55,7 @@ export function getRequestedImageSize(src: { width: number; height: number }, op
 		if (!isNaN(parsedWidth)) {
 			optionsCopy.width = parsedWidth;
 		} else {
-			console.warn('Invalid width value provided: ', optionsCopy.width);
+			Trace.write('Invalid width value provided: ' + optionsCopy.width, Trace.categories.Debug, Trace.messageType.warn);
 			delete optionsCopy.width;
 		}
 	}
@@ -64,7 +65,7 @@ export function getRequestedImageSize(src: { width: number; height: number }, op
 		if (!isNaN(parsedHeight)) {
 			optionsCopy.height = parsedHeight;
 		} else {
-			console.warn('Invalid height value provided: ', options.height);
+			Trace.write('Invalid height value provided: ' + optionsCopy.height, Trace.categories.Debug, Trace.messageType.warn);
 			delete optionsCopy.height;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`import { ImageAsset as ImageAssetDefinition, ImageAssetOptions } from '.';`
`2`	`2`	`import { Observable } from '../data/observable';`
`3`	`3`	`import { Screen } from '../platform';`
	`4`	`+import { Trace } from '../trace/index';`
`4`	`5`
`5`	`6`	`export class ImageAssetBase extends Observable implements ImageAssetDefinition {`
`6`	`7`	`private _options: ImageAssetOptions;`
`@@ -54,7 +55,7 @@ export function getRequestedImageSize(src: { width: number; height: number }, op`
`54`	`55`	`if (!isNaN(parsedWidth)) {`
`55`	`56`	`optionsCopy.width = parsedWidth;`
`56`	`57`	`} else {`
`57`		`- console.warn('Invalid width value provided: ', optionsCopy.width);`
	`58`	`+ Trace.write('Invalid width value provided: ' + optionsCopy.width, Trace.categories.Debug, Trace.messageType.warn);`
`58`	`59`	`delete optionsCopy.width;`
`59`	`60`	`}`
`60`	`61`	`}`
`@@ -64,7 +65,7 @@ export function getRequestedImageSize(src: { width: number; height: number }, op`
`64`	`65`	`if (!isNaN(parsedHeight)) {`
`65`	`66`	`optionsCopy.height = parsedHeight;`
`66`	`67`	`} else {`
`67`		`- console.warn('Invalid height value provided: ', options.height);`
	`68`	`+ Trace.write('Invalid height value provided: ' + optionsCopy.height, Trace.categories.Debug, Trace.messageType.warn);`
`68`	`69`	`delete optionsCopy.height;`
`69`	`70`	`}`
`70`	`71`	`}`